From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ah8ru-0007sn-8n for mharc-grub-devel@gnu.org; Sat, 19 Mar 2016 00:52:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ah8rr-0007rb-0N for grub-devel@gnu.org; Sat, 19 Mar 2016 00:52:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ah8rm-0003IB-7e for grub-devel@gnu.org; Sat, 19 Mar 2016 00:52:02 -0400 Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:35922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ah8rl-0003Ho-V8 for grub-devel@gnu.org; Sat, 19 Mar 2016 00:51:58 -0400 Received: by mail-lf0-x234.google.com with SMTP id d82so31603086lfe.3 for ; Fri, 18 Mar 2016 21:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=ZA7CU9x9hnqy7UMIrFl8gEBqkcr2Da/odv8iOMQRs54=; b=wF363fmAO+BeX5ePKlnpoq1nmh+/vvj0+gR8HGlV+ldrMKGhvkga6kkJiI5hQIh07U vUaIgW8vvTE+2S3DJEQ9jGNGwoewRmAj176nDTDP8HL3kVHFbyGuqmexrlpJMxzRo0rQ JspffZuRqEFjvCz4NF2+WupK6lK3gk6lDc5//QGaV9u68oTGbCfasrqrOjc7imoslqzT wLy3AV6CRgDLwVuHftc5Has5DfFl6IsmSLBT61xgSR78kF4oD4IbAxHFUR+wTi8yY32Q X+2jgY+tpOnLPkiRqQKH3lj13PobumxynzbSUzgEOuQJS4nGZSx7CwqrAS4hwSq03k+9 pQpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=ZA7CU9x9hnqy7UMIrFl8gEBqkcr2Da/odv8iOMQRs54=; b=FXV2Q2neMZd/2qHPRRYxIHZyHzfJvMqkENB3rDMGTGzOwVYK+8X1jlrAWmT+wHoc7A rwWAFfga258OxgdZj7R6oIXssrs32+7ivplAnnH+aaWAadZPPxVxpvZcTbYP83qbIBpa YiMye84ItE6BSvi12/70RI2KovV1hUZhU35vhifcwRzSsa4mVhfCAphZxVWiNDppfZFC umoupvgg2ut+L+yfVUOb8AE4mRGe3Du1eml7gM+u0HzXX4+bmI+01kv43/RKX3khew4B h8orHow++Q0vdnP7ux4ymuO5+tUhTOTRAu4jcwttvJM23E61nmeAu7KN71qdR1nnRt/q UeGA== X-Gm-Message-State: AD7BkJJHGqzTU4hz9wQijS1CDt82r26hZk2XXHlXP+h53qsEzgkRIbTCqJrzVYm5A+iVMQ== X-Received: by 10.25.135.8 with SMTP id j8mr7094531lfd.64.1458363117092; Fri, 18 Mar 2016 21:51:57 -0700 (PDT) Received: from [192.168.1.42] (ppp109-252-76-159.pppoe.spdop.ru. [109.252.76.159]) by smtp.gmail.com with ESMTPSA id xf10sm2724164lbb.23.2016.03.18.21.51.55 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 18 Mar 2016 21:51:56 -0700 (PDT) Subject: Re: [PATCH][WiP] native DHCPv4 support in net_bootp To: "Rivard, Matthew T" , The development of GNU GRUB References: <55FB8A5F.6040404@gmail.com> <561DF29D.70702@gmail.com> <561E990D.90205@gmail.com> <561EB696.5070909@gmail.com> <569BB641.4040609@gmail.com> From: Andrei Borzenkov Message-ID: <56ECDAEB.8090602@gmail.com> Date: Sat, 19 Mar 2016 07:51:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Mar 2016 04:52:04 -0000 19.03.2016 04:03, Rivard, Matthew T пишет: > Thanks for the patch, finally had an opportunity to apply it and test > it. It did require disabling -Werror in order for the diff that was > originally supplied to compile, as there's a couple of variables that > were throwing uninitialized warnings. > Build log would be helpful. > > -----Original Message----- From: Andrei Borzenkov > [mailto:arvidjaar@gmail.com] Sent: Sunday, January 17, 2016 7:42 AM > To: Rivard, Matthew T ; The development > of GNU GRUB Subject: [PATCH][WiP] native DHCPv4 > support in net_bootp > > 14.10.2015 23:09, Andrei Borzenkov пишет: >> 14.10.2015 21:09, Rivard, Matthew T пишет: >>> Just going by these definitions of bootp and dhcp here: >>> https://technet.microsoft.com/en-us/library/cc781243%28v=ws.10%29.asp >>> >>> x >>> >>> The net_bootp only works with a bootp enabled scope on the dhcp >>> server after chaining from iPXE to grub2. Without a "bootp" >>> scope setup on the dhcp, calling net_bootp on the adapter fails >>> to get an IP address. >>> >>> So, I guess I could more clearly word that the bootp protocol >>> works when calling net_bootp, but standard dhcp isn't. >>> >> >> Hmm ... you are right; we are actually doing BOOTP here, not DHCP. >> > > This patch adds support for native DHCPv4 and removes requirement for > BOOTP compatibility support in DHCP server. > > This is work in progress, but this works for me in test environment. > > Patch changes net_bootp to implement full DHCP transaction. it still > /should/ work with BOOTP pure server (untested, I do not have one). > It also re-implements option processing to support overloaded fields > and consolidates it in one place. > > What is currently not implemented > > - per interface, per transaction stage retransmit timer. Will be > done. > > - DHCP server selection. We take first DHCPOFFER or BOOTPREPLY. No > plans to implement. > > - DHCP option concatenation (RFC3396). I do not expect to hit it in > real life; could be implemented relatively easy if needed. > > - client identifier (RFC6842). I do not expect to hit it in real > life; could be added easily if needed. >