From: Cole Robinson <crobinso@redhat.com>
To: Stefan Berger <stefanb@us.ibm.com>,
mst@redhat.com, qemu-devel@nongnu.org
Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] acpi: Fix TPM ACPI description to make TPM usable on Windows
Date: Mon, 21 Mar 2016 11:32:22 -0400 [thread overview]
Message-ID: <56F01406.4040100@redhat.com> (raw)
In-Reply-To: <1458570071-1935-1-git-send-email-stefanb@us.ibm.com>
On 03/21/2016 10:21 AM, Stefan Berger wrote:
> This patch addresses BZ 1281413.
>
That is, https://bugzilla.redhat.com/show_bug.cgi?id=1281413 . Fedora 23 bug
report from a TPM user
> Fix the APCI description to make it work on Windows again. The ACPI
> description was broken in commit 9e47226.
>
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> ---
> hw/i386/acpi-build.c | 26 ++++++++++++--------------
> 1 file changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 325d8ce..c6e90b6 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -2334,22 +2334,20 @@ build_dsdt(GArray *table_data, GArray *linker,
> Aml *scope = aml_scope("PCI0");
> /* Scan all PCI buses. Generate tables to support hotplug. */
> build_append_pci_bus_devices(scope, bus, pm->pcihp_bridge_en);
> -
> - if (misc->tpm_version != TPM_VERSION_UNSPEC) {
> - dev = aml_device("ISA.TPM");
> - aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0C31")));
> - aml_append(dev, aml_name_decl("_STA", aml_int(0xF)));
> - crs = aml_resource_template();
> - aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE,
> - TPM_TIS_ADDR_SIZE, AML_READ_WRITE));
> - aml_append(crs, aml_irq_no_flags(TPM_TIS_IRQ));
> - aml_append(dev, aml_name_decl("_CRS", crs));
> - aml_append(scope, dev);
> - }
> -
> - aml_append(sb_scope, scope);
> }
> }
> +
> + if (misc->tpm_version != TPM_VERSION_UNSPEC) {
> + dev = aml_device("TPM");
> + aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0C31")));
> + aml_append(dev, aml_name_decl("_STA", aml_int(0xF)));
> + crs = aml_resource_template();
> + aml_append(crs, aml_memory32_fixed(TPM_TIS_ADDR_BASE,
> + TPM_TIS_ADDR_SIZE, AML_READ_WRITE));
> + //aml_append(crs, aml_irq_no_flags(TPM_TIS_IRQ));
> + aml_append(dev, aml_name_decl("_CRS", crs));
> + aml_append(sb_scope, dev);
> + }
> aml_append(dsdt, sb_scope);
> }
>
>
After this, TPM shows up as functional in windows 10 device manager. Prior to
this patch it had a warning icon.
Tested-by: Cole Robinson <crobinso@redhat.com>
- Cole
next prev parent reply other threads:[~2016-03-21 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 14:21 [Qemu-devel] [PATCH] acpi: Fix TPM ACPI description to make TPM usable on Windows Stefan Berger
2016-03-21 15:32 ` Cole Robinson [this message]
2016-03-30 13:33 ` Igor Mammedov
2016-03-31 4:03 ` Stefan Berger
2016-03-31 9:50 ` Igor Mammedov
2016-03-31 14:07 ` Igor Mammedov
2016-04-01 18:50 ` Stefan Berger
2016-04-02 19:35 ` Igor Mammedov
2016-04-03 13:33 ` Michael S. Tsirkin
2016-04-04 11:05 ` Marcel Apfelbaum
2016-03-30 13:35 ` [Qemu-devel] [PATCH] pc: acpi: tpm: add missing MMIO resource to PCI0._CRS Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F01406.4040100@redhat.com \
--to=crobinso@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanb@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.