From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: [PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver Date: Mon, 21 Mar 2016 16:49:03 +0100 Message-ID: <56F017EF.8020401@hartkopp.net> References: <1457019515-21158-1-git-send-email-ramesh.shanmugasundaram@bp.renesas.com> <1458035294-8150-1-git-send-email-ramesh.shanmugasundaram@bp.renesas.com> <56E80422.9000902@hartkopp.net> <56E864AC.2040605@hartkopp.net> <56E92BCF.1080508@hartkopp.net> <56E9CE32.6050504@hartkopp.net> <56EB17BB.9030308@hartkopp.net> <56EC5AB0.1080107@hartkopp.net> <56F013B3.6050301@hartkopp.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.220]:47460 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756030AbcCUPtQ (ORCPT ); Mon, 21 Mar 2016 11:49:16 -0400 In-Reply-To: Sender: linux-can-owner@vger.kernel.org List-ID: To: Ramesh Shanmugasundaram , "mkl@pengutronix.de" , "wg@grandegger.com" Cc: "linux-can@vger.kernel.org" On 03/21/2016 04:43 PM, Ramesh Shanmugasundaram wrote: >>> /* The R-Car CAN FD controller can operate in either one of the below >> two modes >>> * - CAN FD only mode >>> * - Classical CAN (CAN 2.0) only mode >>> * >>> * This driver puts the controller in CAN FD only mode by default. In >>> this >> >> This driver does not support the Classical CAN (CAN 2.0) mode of the >> controller which is handled by a different register set and therefore puts >> the controller in CAN FD only mode by default. In this > > With a slight re-wording if I may > > "This driver puts the controller in CAN FD only mode by default. In this mode, the > controller acts as a CAN FD node that can also interoperate with CAN 2.0 nodes. > > As of now, this driver does not support the classical CAN (CAN 2.0) mode, which > is handled by a different register map compared to CAN FD only mode" > > It kind of implies "can only" mode patch will come next & we consciously submitted CAN FD only first to keep it simple :-) ACK :-) Thanks, Oliver