From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai2aL-0002t0-Eb for qemu-devel@nongnu.org; Mon, 21 Mar 2016 12:21:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai2aF-000849-6l for qemu-devel@nongnu.org; Mon, 21 Mar 2016 12:21:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai2aE-000838-MV for qemu-devel@nongnu.org; Mon, 21 Mar 2016 12:21:35 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 61B35804EF for ; Mon, 21 Mar 2016 16:21:34 +0000 (UTC) References: <1456151945-11225-1-git-send-email-pbonzini@redhat.com> <1456151945-11225-4-git-send-email-pbonzini@redhat.com> <87k2kvzu0z.fsf@blackfin.pond.sub.org> From: Paolo Bonzini Message-ID: <56F01F8A.2090902@redhat.com> Date: Mon, 21 Mar 2016 17:21:30 +0100 MIME-Version: 1.0 In-Reply-To: <87k2kvzu0z.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] block: remove legacy_dinfo at blk_detach_dev time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , qemu-devel@nongnu.org, Max Reitz On 21/03/2016 17:15, Markus Armbruster wrote: > * Explicitly with x-blockdev-del > > Fails unless no other reference exists. Where is the legacy_dinfo > released? Can a -drive block device be deleted with x-blockdev-del even?!? In other words, you said "This looks like DriveInfo now owns a reference to BlockBackend, even though the pointer still goes in the other direction". I say, "I thought this was the idea all along"... Shall I add a check to x-blockdev-del that gives an error if the BlockBackend has a DriveInfo attached? Paolo > * Implicitly via warty automatic deletion > > Your PATCH 01 has the necessary replacement of blk_unref(blk) by > blkdev_del_drive(blk) for some devices (virtio-blk.c, scsi-bus.c, > xen_disk,c, piix.c), butas far as I can see not for others such as > nvme.c.