From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 22 Mar 2016 08:23:31 +0100 Subject: [U-Boot] [PATCH v5 3/4] drivers:usb:common:fsl-dt-fixup: Add device-tree fixup support for xhci controller In-Reply-To: <1458630612-19627-4-git-send-email-sriram.dash@nxp.com> References: <1458630612-19627-1-git-send-email-sriram.dash@nxp.com> <1458630612-19627-4-git-send-email-sriram.dash@nxp.com> Message-ID: <56F0F2F3.5060305@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/22/2016 08:10 AM, Sriram Dash wrote: > Enables usb device-tree fixup code to incorporate xhci controller > > Signed-off-by: Ramneek Mehresh > Signed-off-by: Sriram Dash > --- > Changes in v5: > - Make the array static const > Changes in v4: > - Use a terminating entry in the array for getting node type for controller > Changes in v3: > - Modify the Makefile to remove comparison > - Put the supported controllers in array and checking from array > Changes in v2: > - Remove the #defines from the patch and adding controller support > > drivers/usb/common/Makefile | 1 + > drivers/usb/common/fsl-dt-fixup.c | 33 +++++++++++++++++---------------- > include/fdt_support.h | 4 ++-- > 3 files changed, 20 insertions(+), 18 deletions(-) > > diff --git a/drivers/usb/common/Makefile b/drivers/usb/common/Makefile > index a38ee4a..2f3d43d 100644 > --- a/drivers/usb/common/Makefile > +++ b/drivers/usb/common/Makefile > @@ -4,3 +4,4 @@ > # > > obj-$(CONFIG_USB_EHCI_FSL) += fsl-dt-fixup.o > +obj-$(CONFIG_USB_XHCI_FSL) += fsl-dt-fixup.o > diff --git a/drivers/usb/common/fsl-dt-fixup.c b/drivers/usb/common/fsl-dt-fixup.c > index eb13f12..13f9fb8 100644 > --- a/drivers/usb/common/fsl-dt-fixup.c > +++ b/drivers/usb/common/fsl-dt-fixup.c > @@ -19,27 +19,28 @@ > #define CONFIG_USB_MAX_CONTROLLER_COUNT 1 > #endif > > +static const char compat_usb_fsl[] = { > + "fsl-usb2-mph" "\0" > + "fsl-usb2-dr" "\0" > + "snps,dwc3" "\0" > +}; This is supposed to be static constant array of strings. Can you tell me, based on your knowledge of the C language, what is wrong with this construct ? Best regards, Marek Vasut