From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932644AbcCVILm (ORCPT ); Tue, 22 Mar 2016 04:11:42 -0400 Received: from mail-bl2on0066.outbound.protection.outlook.com ([65.55.169.66]:40518 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758378AbcCVILZ (ORCPT ); Tue, 22 Mar 2016 04:11:25 -0400 Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH 2/3] x86/topology: Fix AMD core count To: Borislav Petkov , Huang Rui References: <20160318150345.146716865@infradead.org> <20160318150538.551407299@infradead.org> <20160318164101.GG7817@pd.tnic> <20160321030744.GA26269@hr-amur2> <20160321082129.GP6344@twins.programming.kicks-ass.net> <20160321094611.GB26555@hr-amur2> <20160321135734.GE15904@pd.tnic> CC: Peter Zijlstra , , , , , , Gang Long From: Sherry Hurwitz Message-ID: <56F0FDE7.8010802@amd.com> Date: Tue, 22 Mar 2016 03:10:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160321135734.GE15904@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2602:306:3398:d30:7caf:3706:896f:63a9] X-ClientProxiedBy: CY1PR19CA0006.namprd19.prod.outlook.com (25.162.38.144) To BN1PR12MB0049.namprd12.prod.outlook.com (25.160.81.151) X-MS-Office365-Filtering-Correlation-Id: b6e67cc9-74f7-4cd1-0c83-08d352298e37 X-Microsoft-Exchange-Diagnostics: 1;BN1PR12MB0049;2:DQ4o7bMtFvNsE96cp4UxYkrRbul/X9UYAeeZeXzzr2aKIp1zw594bFw23/axWKLit2UoiHNq3xTztdMAn4BahYG/FanVVn4su/5HcqyAap71T2iOVAe31QHaJZxpuK1menGs4fNCylEw9tkAdhqJBDsI9GLprMIxfhYTBBkHpDZWdRwMPnET+WM3Cb11gWr5;3:g+h5lf9LRdLcrRBX4hASwAtF6319e60Wvdzsuor1XtMPbS1ID2nO9nqlJLS0uSuM0cBHl3ld0oWY3i5DOiacJWfQ3gThK/kcxYk5KvUrljKHYiOdeykwpcLJE0X0Hg+w;25:Akj+sKpC/8d5HY5C3qqCheaMlq3zOpJtXGSCFgeItXTSs9fgxb8Zxqt1597BTWNPPyYjbkTdca7u9LqINXLt8SjeiVHELg7dN1qfoDeSSl87uTScU/wdT6jMa3VEdOwW7IczJIdYYlDq5D77RHbdK83rEElLxnt2/Y0FQd3xCj0o1n1jeoJ2GqV48Coj0sET0B5jz3xjYDNJ73RrzvAhvasfgxsqu6GnBu3FQJhKlXymFq+XYjLRyr/3eJ6wgFS8mji9T6ZUfkCprdpS1s/VX2m2vGNbzHkEPIOE+vuaYoaLIRGL6d/9QyMZK682mrfzlAVj2ZRSiG5eJ89MLQvovldLpHN1lnU6BFTgC8SRsyvkQla9c98bVUgWJ5LH5HLHZgk0T9rGiLdScHSPZVsxelhGdU7SyF1/dK+/4ykKPA3bJxXdg30QSBAJ4qhncSXWPNsQjTxRIMwm2JTnaNiSdg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR12MB0049; X-Microsoft-Exchange-Diagnostics: 1;BN1PR12MB0049;20:eRFOkuhO6qVlxXdZvdbmu8f8PuViglFET3/RoM4vzVHizwciiJFh8bjFVfSoAbpnuBWlHlzDDP49S4A97WWZomj4ZTKEilzd4NA29bFriD5kGZScoy6XElyVpsRBz0fzsIEjOIVxxcty5qLwscIdjAmmBfPPe5vJWasZj4lWHKvDqwimmFiNGNiud9A82yP+//7qqi5TYWjeeOquUbqZfHV0ELHghpgcOf7I4iWdcdsnblCfFW+VbcbNGDEuqU5SQwqFfKd484n8PqoLa5miIuDMxXpdyzR6w4dxJXeSVyitgFgCHAzT+jNSFR3wDRZsqTEiv21c7GYz0EjEwsZAy+wULijAgWpZI0AsEUZHjKjnnNAE57j6BqoeGxZx0+WZz2Csv6cMnPXacLDp1+CDe4MSWdyDd1m+i3BiYD3HAnJkPzidKvWhxaRu/q2Qg+4pVrD8+ThAgbjLc8OYprZvBgi7pmul0cI7jKZphmip25yKGqwkKuF4iHLmK3dwO4e6;4:Kvbl/G4jwnTRSK2pExx5UfPWnKV4ykkkBnZuW/2dDaZiSjitdRmT4aMsLZKTCCU1Qdtvr4supGFsNjauupHcWrWGoMAujJ1GYOeneNSH+nBZzRA5s/7CHZWNQU5rStMoc5FUFBnLJNWeuGAYEFu+r2REVTkxMMZCdJQbsMkgG7Q2mz9zWdHiRKHRBnghJaT3+hfq/YXqhduN8sBoKINFJBWuhokDPkgcyXD33eM9BZvALVDwfr91L2QYqrPmO0tG8cio4SJOt92f4GLIglwyWSD8iemV7ZMDMEpz/49bHzjPXjGOZxTXwKJUjCCS+BIRbLYF+meN+G3jUliuP9n2MSyWGXmtQC1WmMoOXf28EZRduO0hgN8Tna2ZkkgPYs5C X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BN1PR12MB0049;BCL:0;PCL:0;RULEID:;SRVR:BN1PR12MB0049; X-Forefront-PRVS: 08897B549D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(377454003)(93886004)(59896002)(230700001)(36756003)(65816999)(65806001)(65956001)(76176999)(87266999)(50986999)(54356999)(47776003)(2906002)(4326007)(42186005)(83506001)(50466002)(5001770100001)(5008740100001)(86362001)(5004730100002)(92566002)(586003)(23676002)(33656002)(1096002)(189998001)(81166005)(77096005)(6116002)(64126003)(2950100001)(4001350100001)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR12MB0049;H:[IPv6:2602:306:3398:d30:7caf:3706:896f:63a9];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFQUjEyTUIwMDQ5OzIzOitlWHZyWmlkRURORERIRWd6ei9ycTFrcGNn?= =?utf-8?B?TXk2cG1KQ2N6b3dBNzcvTnRHMnpwc242cjhUU2dJSkk0aDRyKzJ4UUEvNitG?= =?utf-8?B?UmdwWFlNVG1IWnhpTE9nenY4YzZCNjUvcGFSbk9NczZYTHB6VU5rditHekd5?= =?utf-8?B?WFZ3eUZld0ZmaTVaSldFb2Y5Vll2UE1LMjJqTkVrSHArdHRLMk1uTUpKbUVq?= =?utf-8?B?QWlaWjhQdjJEUVhvSzB4RmVUOW1odXpDeVU5ZHFKc1cwbmpJU0tVREpoOXVW?= =?utf-8?B?UVR2WHBoWWtvRVJYREFQa3FEUTMxY0Qvb1c4SWxldEdLdkNjVWdoaDdnZW1u?= =?utf-8?B?S3AySlZXdEwvSFY5Rzd2dGxBWk5INHRabFcvcVJLOSsyQko2cTdNTGQySW5I?= =?utf-8?B?YThpY2lNRWhyZ2xLeldFdzVtTzRsRWUyUmphSFpaMTloSnBsRzJtUTNuTXY1?= =?utf-8?B?dmRGb3ozUlVVeG1sVkd5Nk9KTk9YUzR4N3hiNSsvVktPem9jWDJLU2xROSs4?= =?utf-8?B?YVQyTTZNRTZLcGdhWTR5KzJKanQ0UDBYcyt1M2grOVcyRk9uMlpwNERhOXMy?= =?utf-8?B?S1JMOXUzeGFqSVJjWXkvbDFrUDRJUzVvQjgzYmZxS2Z3UmdBZUxPVytRaDB0?= =?utf-8?B?UFJzN2RDNnNEclg5K1lBRkJxNE9yVTBYYkNOd0orTFgzMjkwMnZOR0M4aGJR?= =?utf-8?B?aTVuNk9WOE9hZk0reVhqYkxQaklMUE1rT2VraFJSYXRGbCsrdDE2anIyVEFO?= =?utf-8?B?OVZya0JXSzgvSmdMbGxFam5vMDNXdEp4aGVwWkpSODVCY3VuWC8rSkRZQVFI?= =?utf-8?B?MFM1WkhSWElUTS8yb2JMYWJjeDl6MVV2RTZzSC9uNm4zWnJBM3dKTHZ1VEFI?= =?utf-8?B?bWZwTUk5ejNSUDhsRDJFT0ZuQ3gyVWF5Z2tNTDFqbzhjYU5iOVdwdVliVnRQ?= =?utf-8?B?dUVjR3g3V2UrN3JONjYxcTAyWEJiWGR0T0lhelY4TnBtSXFjV3NYV2RwbzNj?= =?utf-8?B?M0ZleVBkOTdISGoyWmtCc2R2OWFSencwUGpCWUhkVVltS0pnZUVIK2FLMGVq?= =?utf-8?B?YjlmeWRwVjh6TnVTemJESSt1a2lRb3NPamxwczBtTDlwZi91d3c5WjBYVWpS?= =?utf-8?B?eXJjSG02Sld5bitENXIxN2lSUUlybFR6YXBqUldoR1pJWWVoVUdDRXVxSUFW?= =?utf-8?B?aVNDcndDRUlaakJDRUlublZESnZDeUtWQUIrT0pOaWFESTA2eUZ6ZlJoLzdE?= =?utf-8?B?aVE2dFhpdG0xUUMxRVRxYWZGNVhRWklXNWo4blRGampCQXdYelpFenNnNFVv?= =?utf-8?B?b2o1UnNnbzZMUUlvQ2ZqdWE3OCtNNzAxT3R5dWJaR2ErTGMrV2JWekwwLzRB?= =?utf-8?B?cVdHeC9LRkF2d2FNbWpZdWdjQi9mczN0SVFSQm93PT0=?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR12MB0049;5:xsbZ4NR/0l8GJk6B+ZG40CI6/YqhNHT7Q1Yni6EVRjSxKrIt7t0yRX2qQ4+M3LD90+GbHekJjK99TzgdigacFmMCYIEiCp7IxaKPbw5+7QlayE1SbsxuInqwtkBv20RjA8PkLueKAWo0Tz5DnmzKpA==;24:qhRJG6wV/I+VBBUK8Y/YoaNSyRjPplrFnsNXZkOCnfS8Did74COIHq815YazZqQsD1JQvGLFtYAGgQSRydoKECTCiaH/Me5eCO7R8yoYwnM=;20:Z23Fu/lcUQx2JSGHjNc84WiFPIlyO5t56DYWBCgivHYTqi1DIpSO2UfPJ5jqupLTYUGq0figp/Hj7rSRW1wHcO+fvL2Md0F05egpycyr/nZ2CsTGa9C/VJY8Kaz/ZmasTV5NnTV0u4o0glWyj+dwDvgwcRoF9crOcfy7Hun/mLOuyfmc46cVAWrG/g2yalzXSxAd5mqQ9yjEjldz6b/4oZkpBPQgdDdw9/eMgfrL/iuHoKXecc2XHfaoXbxVkkJA X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2016 08:11:20.1699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR12MB0049 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/21/2016 08:57 AM, Borislav Petkov wrote: > +- AMD: the number of cores in a processor. On a system where cores are > +clustered in groups of 2, 4 or more in compute units, this variable > +denotes the number of*compute units* on the node. > + > +In both cases, the number of scheduling threads is computed by doing: > + > + x86_max_cores * smp_num_siblings > + > +This means: > + > +* smp_num_siblings: the number of siblings in a core. On AMD with > +compute units, this number is the number of compute unit siblings, > +i.e., compute unit cores in a single compute unit, according to their > +nomenclature. > -- hr Boris, this documentation will help tremendously. In just this line of code: nr_local_cpus = nr_cores * nr_siblings we have an Intel HT = AMD core = logical_cpu and core = AMD compute unit. Anybody surprised there was a bug? The surprising thing is that running lscpu on a 32 core 2 socket 6300 Opteron system without the patches I get the same output as with the patches and it matches Ray's. I don't see an impact.