From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] testpmd: fix build on FreeBSD
Date: Tue, 22 Mar 2016 09:44:23 +0000 [thread overview]
Message-ID: <56F113F7.5070309@intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E14ECA4FA@SHSMSX103.ccr.corp.intel.com>
On 22/03/2016 03:30, Liu, Yong wrote:
> Hi Pablo & Sergio,
>
>> -----Original Message-----
>> From: De Lara Guarch, Pablo
>> Sent: Monday, March 21, 2016 5:40 PM
>> To: Gonzalez Monroy, Sergio; Liu, Yong; dev@dpdk.org
>> Subject: RE: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD
>>
>>
>>
>>> -----Original Message-----
>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
>>> Monroy
>>> Sent: Monday, March 21, 2016 9:13 AM
>>> To: Liu, Yong; dev@dpdk.org
>>> Subject: Re: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD
>>>
>>> On 21/03/2016 01:44, Marvin Liu wrote:
>>>> Build log:
>>>> /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named
>>>> 's6_addr32' in 'struct in6_addr'
>>>> rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]);
>>>>
>>>> This is caused by macro "s6_addr32" not defined on FreeBSD.
>>>>
>>>> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>>>>
>>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>>>> index 9d52b8c..51ad23b 100644
>>>> --- a/app/test-pmd/cmdline.c
>>>> +++ b/app/test-pmd/cmdline.c
>>>> @@ -6684,7 +6684,11 @@ cmd_tunnel_filter_parsed(void *parsed_result,
>>>> int i;
>>>> for (i = 0; i < 4; i++) {
>>>> tunnel_filter_conf.ip_addr.ipv6_addr[i] =
>>>> +#ifdef RTE_EXEC_ENV_BSDAPP
>>>> + rte_be_to_cpu_32(res-
>>>> ip_value.addr.ipv6.__u6_addr.__u6_addr32[i]);
>>>> +#else
>>>> rte_be_to_cpu_32(res-
>>>> ip_value.addr.ipv6.s6_addr32[i]);
>>>> +#endif
>>> Why not always use .__u6_addr.__u6_addr32[i] and avoid ifdef?
>>>
> Because of structures between BSD an Linux have different names.
> On linux, it will be "__in6_u. __u6_addr32".
Duh!
Sorry about that. I should drink coffee before replying emails.
Sergio
>>> Sergio
>>>
>>>> }
>>>> tunnel_filter_conf.ip_type = RTE_TUNNEL_IPTYPE_IPV6;
>>>> }
>> Also, can you include the missing "Fixes" line?
>>
> Sure, I will add it and send out v2.
>
>> Thanks,
>> Pablo
> Best regards,
> Marvin
>
next prev parent reply other threads:[~2016-03-22 9:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 1:44 [PATCH] testpmd: fix build on FreeBSD Marvin Liu
2016-03-21 8:59 ` Mrzyglod, DanielX T
2016-03-21 9:13 ` Sergio Gonzalez Monroy
2016-03-21 9:40 ` De Lara Guarch, Pablo
2016-03-21 14:57 ` Bruce Richardson
2016-03-22 3:30 ` Liu, Yong
2016-03-22 9:44 ` Sergio Gonzalez Monroy [this message]
2016-03-22 6:50 ` [PATCH v2] " Marvin Liu
2016-03-22 9:05 ` Qiu, Michael
2016-03-23 9:20 ` Liu, Yong
2016-03-23 2:17 ` Wu, Jingjing
2016-03-23 15:17 ` Thomas Monjalon
2016-03-25 12:10 ` Bruce Richardson
2016-03-25 12:15 ` Bruce Richardson
2016-03-25 18:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F113F7.5070309@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.