From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH] net: mediatek: fix checking for NULL instead of IS_ERR() in .probe Date: Wed, 23 Mar 2016 10:00:50 +0100 Message-ID: <56F25B42.5030005@gmail.com> References: <1458687964-9690-1-git-send-email-vz@mleia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org To: Vladimir Zapolskiy , "David S. Miller" , Felix Fietkau , John Crispin Return-path: Received: from mail-wm0-f41.google.com ([74.125.82.41]:35618 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753702AbcCWJAy (ORCPT ); Wed, 23 Mar 2016 05:00:54 -0400 Received: by mail-wm0-f41.google.com with SMTP id l68so185709098wml.0 for ; Wed, 23 Mar 2016 02:00:53 -0700 (PDT) In-Reply-To: <1458687964-9690-1-git-send-email-vz@mleia.com> Sender: netdev-owner@vger.kernel.org List-ID: On 23/03/16 00:06, Vladimir Zapolskiy wrote: > devm_ioremap_resource() returns ERR_PTR() value on error, it never > returns NULL, fix it and propagate the returned error upwards. > > Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623 ethernet") > Signed-off-by: Vladimir Zapolskiy > --- Reviewed-by: Matthias Brugger > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 7f2126b..e0b68af 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -1690,8 +1690,8 @@ static int mtk_probe(struct platform_device *pdev) > return -ENOMEM; > > eth->base = devm_ioremap_resource(&pdev->dev, res); > - if (!eth->base) > - return -EADDRNOTAVAIL; > + if (IS_ERR(eth->base)) > + return PTR_ERR(eth->base); > > spin_lock_init(ð->page_lock); > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthias.bgg@gmail.com (Matthias Brugger) Date: Wed, 23 Mar 2016 10:00:50 +0100 Subject: [PATCH] net: mediatek: fix checking for NULL instead of IS_ERR() in .probe In-Reply-To: <1458687964-9690-1-git-send-email-vz@mleia.com> References: <1458687964-9690-1-git-send-email-vz@mleia.com> Message-ID: <56F25B42.5030005@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 23/03/16 00:06, Vladimir Zapolskiy wrote: > devm_ioremap_resource() returns ERR_PTR() value on error, it never > returns NULL, fix it and propagate the returned error upwards. > > Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623 ethernet") > Signed-off-by: Vladimir Zapolskiy > --- Reviewed-by: Matthias Brugger > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 7f2126b..e0b68af 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -1690,8 +1690,8 @@ static int mtk_probe(struct platform_device *pdev) > return -ENOMEM; > > eth->base = devm_ioremap_resource(&pdev->dev, res); > - if (!eth->base) > - return -EADDRNOTAVAIL; > + if (IS_ERR(eth->base)) > + return PTR_ERR(eth->base); > > spin_lock_init(ð->page_lock); > >