From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755597AbcC2BRl (ORCPT ); Mon, 28 Mar 2016 21:17:41 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:48337 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755204AbcC2BRh (ORCPT ); Mon, 28 Mar 2016 21:17:37 -0400 X-AuditID: cbfee68d-f79e86d0000012da-79-56f9d7af60a8 Message-id: <56F9D7AE.9010909@samsung.com> Date: Tue, 29 Mar 2016 10:17:34 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Shawn Lin , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops References: <1454470004-21408-1-git-send-email-shawn.lin@rock-chips.com> <56B2EC67.4010909@samsung.com> <56BDC527.9090002@rock-chips.com> In-reply-to: <56BDC527.9090002@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgkeLIzCtJLcpLzFFi42JZI2JSqLv++s8wg8ZpvBaXd81hszjyv5/R 4s6T9awWx9eGO7B43Lm2h83j76z9LB6fN8kFMEdx2aSk5mSWpRbp2yVwZczZsImlYKlwxdru eWwNjK/4uhg5OSQETCQ2Hv3GCGGLSVy4t56ti5GLQ0hgBaPEj49LWWCK7uz+wgyRWMoo8fTd fCYI5wGjxLLT98CqeAW0JC5v7AAbxSKgKrH59HKwOJuAjsT2b8eZQGxRgTCJB+v2skLUC0r8 mAzRKyLgJ7F1x1Y2EJtZwFri549WsBphAXeJz0cms0As62aUaJjxnx0kwSmgJzHv6gsgmwOo QU/i/kUtiF55ic1r3jJDXL2KXaLtczTEPQIS3yYfYgEplxCQldh0AKpEUuLgihssExjFZiG5 aBbC0FlIhi5gZF7FKJpakFxQnJReZKhXnJhbXJqXrpecn7uJERhBp/89693BePuA9SFGAQ5G JR5ehgU/w4RYE8uKK3MPMZoCHTGRWUo0OR8Yp3kl8YbGZkYWpiamxkbmlmZK4ryKUj+DhQTS E0tSs1NTC1KL4otKc1KLDzEycXBKNTDWXvojsqz624xNco997D+1VlwrUf3w1k5FSdXcoqTr fa2P5pzfvPfnznH+167w4+92Fb/vuROLL34xm7821TBY9ie3pq7AHpM++aNL+Oq+Fut3pKhs bH288Chv4/tqe+H/D2YVd/tWOgq0iZ3Y/sQ/59+Unq0sx79UODkH1MhoPlJJuztTRl6JpTgj 0VCLuag4EQA79jo5mwIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGIsWRmVeSWpSXmKPExsVy+t9jAd3113+GGRzcwWFxedccNosj//sZ Le48Wc9qcXxtuAOLx51re9g8/s7az+LxeZNcAHNUA6NNRmpiSmqRQmpecn5KZl66rZJ3cLxz vKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtA2JYWyxJxSoFBAYnGxkr4dpgmhIW66FjCNEbq+ IUFwPUYGaCBhDWPGnA2bWAqWCles7Z7H1sD4iq+LkZNDQsBE4s7uL8wQtpjEhXvr2boYuTiE BJYySjx9N58JwnnAKLHs9D0WkCpeAS2Jyxs7GEFsFgFVic2nl4PF2QR0JLZ/O84EYosKhEk8 WLeXFaJeUOLHZIheEQE/ia07trKB2MwC1hI/f7SC1QgLuEt8PjKZBWJZN6NEw4z/7CAJTgE9 iXlXXwDZHEANehL3L2pB9MpLbF7zlnkCo8AsJCtmIVTNQlK1gJF5FaNEakFyQXFSeq5RXmq5 XnFibnFpXrpecn7uJkZwnD6T3sF4eJf7IUYBDkYlHl6GBT/DhFgTy4orcw8xSnAwK4nwtlwD CvGmJFZWpRblxxeV5qQWH2I0BYbBRGYp0eR8YArJK4k3NDYxM7I0Mje0MDI2VxLnffx/XZiQ QHpiSWp2ampBahFMHxMHp1QD42wThv15ifI9F479utr/P+9ahpB4RRzngVkzFYJNis+WZT6+ /cgwbMLym7s4TjSeXbL77Z/4hCuuuo/lba+Iqix+LcnA/m66QmCzxY1pdyRPxvW48Mx8uuNR e/+uY6cP3/A9sqg0RSy9IcNyIevlu1XPfJMlhMzn5zOnnyu8WpGsvS5lpYQmnxJLcUaioRZz UXEiAEVwFZvpAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, Sorry for applying late. Applied on my repository. Best Regards, Jaehoon Chung On 02/12/2016 08:42 PM, Shawn Lin wrote: > On 2016/2/4 14:15, Jaehoon Chung wrote: >> Hi, Shawn. >> >> On 02/03/2016 12:26 PM, Shawn Lin wrote: >>> dw_mci_rockchip_pmops just copy-paste what dw_mci_pltfm_pmops >>> have done. Let's remove it. >> >> Yep, it's possible to remove. >> I'm not sure but i want to know there is no plan to add the specific code of rockchip in suspend/resume. >> Could you check this? > > Jaehoon, > > :) I can't say "never plan to add anything" in case of some broken Socs > need something special to do in the future. But I will that would not happen, and personally we not going to add specific code here. > > Thanks for sharing your thought. > >> >> Best Regards, >> Jaehoon Chung >> >>> >>> Signed-off-by: Shawn Lin >>> --- >>> >>> drivers/mmc/host/dw_mmc-rockchip.c | 22 +--------------------- >>> 1 file changed, 1 insertion(+), 21 deletions(-) >>> >>> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c >>> index d9c92f3..3438ab3 100644 >>> --- a/drivers/mmc/host/dw_mmc-rockchip.c >>> +++ b/drivers/mmc/host/dw_mmc-rockchip.c >>> @@ -276,33 +276,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev) >>> return dw_mci_pltfm_register(pdev, drv_data); >>> } >>> >>> -#ifdef CONFIG_PM_SLEEP >>> -static int dw_mci_rockchip_suspend(struct device *dev) >>> -{ >>> - struct dw_mci *host = dev_get_drvdata(dev); >>> - >>> - return dw_mci_suspend(host); >>> -} >>> - >>> -static int dw_mci_rockchip_resume(struct device *dev) >>> -{ >>> - struct dw_mci *host = dev_get_drvdata(dev); >>> - >>> - return dw_mci_resume(host); >>> -} >>> -#endif /* CONFIG_PM_SLEEP */ >>> - >>> -static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops, >>> - dw_mci_rockchip_suspend, >>> - dw_mci_rockchip_resume); >>> - >>> static struct platform_driver dw_mci_rockchip_pltfm_driver = { >>> .probe = dw_mci_rockchip_probe, >>> .remove = dw_mci_pltfm_remove, >>> .driver = { >>> .name = "dwmmc_rockchip", >>> .of_match_table = dw_mci_rockchip_match, >>> - .pm = &dw_mci_rockchip_pmops, >>> + .pm = &dw_mci_pltfm_pmops, >>> }, >>> }; >>> >>> >> >> >> >> > >