From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [RFC v1 04/17] selftest/seccomp: Fix the seccomp(2) signature Date: Tue, 29 Mar 2016 09:38:52 -0600 Message-ID: <56FAA18C.4040406@osg.samsung.com> References: <1458784008-16277-1-git-send-email-mic@digikod.net> <1458784008-16277-5-git-send-email-mic@digikod.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: owner-linux-security-module@vger.kernel.org To: Kees Cook , =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Cc: linux-security-module , Andreas Gruenbacher , Andy Lutomirski , Andy Lutomirski , Arnd Bergmann , Casey Schaufler , Daniel Borkmann , David Drysdale , Eric Paris , James Morris , Jeff Dike , Julien Tinnes , Michael Kerrisk , Paul Moore , Richard Weinberger , "Serge E . Hallyn" , Stephen Smalley , Tetsuo Handa , Will Drewry , Linux API , "kernel-hardening@lists.openwall.com" , Shuah Khan List-Id: linux-api@vger.kernel.org On 03/23/2016 10:36 PM, Kees Cook wrote: > On Wed, Mar 23, 2016 at 6:46 PM, Micka=C3=ABl Sala=C3=BCn wrote: >> Signed-off-by: Micka=C3=ABl Sala=C3=BCn >> Cc: Kees Cook >> Cc: Andy Lutomirski >> Cc: Will Drewry >=20 > Another good catch. Shuah, can you take this one too? >=20 > Acked-by: Kees Cook >=20 > -Kees Hi Michael, Could you please send me the patch. I can't find it in my Inbox. I can = get this into rc-2 with Kees Cook's ack. thanks, -- Shuah >=20 >> --- >> tools/testing/selftests/seccomp/seccomp_bpf.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/t= esting/selftests/seccomp/seccomp_bpf.c >> index 9c1460f277c2..150829dd7998 100644 >> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c >> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c >> @@ -1502,10 +1502,10 @@ TEST_F(TRACE_syscall, syscall_dropped) >> #endif >> >> #ifndef seccomp >> -int seccomp(unsigned int op, unsigned int flags, struct sock_fprog = *filter) >> +int seccomp(unsigned int op, unsigned int flags, void *args) >> { >> errno =3D 0; >> - return syscall(__NR_seccomp, op, flags, filter); >> + return syscall(__NR_seccomp, op, flags, args); >> } >> #endif >> >> -- >> 2.8.0.rc3 >> >=20 >=20 >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-securit= y-module" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Reply-To: kernel-hardening@lists.openwall.com References: <1458784008-16277-1-git-send-email-mic@digikod.net> <1458784008-16277-5-git-send-email-mic@digikod.net> From: Shuah Khan Message-ID: <56FAA18C.4040406@osg.samsung.com> Date: Tue, 29 Mar 2016 09:38:52 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: [kernel-hardening] Re: [RFC v1 04/17] selftest/seccomp: Fix the seccomp(2) signature To: Kees Cook , =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Cc: linux-security-module , Andreas Gruenbacher , Andy Lutomirski , Andy Lutomirski , Arnd Bergmann , Casey Schaufler , Daniel Borkmann , David Drysdale , Eric Paris , James Morris , Jeff Dike , Julien Tinnes , Michael Kerrisk , Paul Moore , Richard Weinberger , "Serge E . Hallyn" , Stephen Smalley , Tetsuo Handa , Will Drewry , Linux API , "kernel-hardening@lists.openwall.com" , Shuah Khan List-ID: On 03/23/2016 10:36 PM, Kees Cook wrote: > On Wed, Mar 23, 2016 at 6:46 PM, Mickaël Salaün wrote: >> Signed-off-by: Mickaël Salaün >> Cc: Kees Cook >> Cc: Andy Lutomirski >> Cc: Will Drewry > > Another good catch. Shuah, can you take this one too? > > Acked-by: Kees Cook > > -Kees Hi Michael, Could you please send me the patch. I can't find it in my Inbox. I can get this into rc-2 with Kees Cook's ack. thanks, -- Shuah > >> --- >> tools/testing/selftests/seccomp/seccomp_bpf.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c >> index 9c1460f277c2..150829dd7998 100644 >> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c >> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c >> @@ -1502,10 +1502,10 @@ TEST_F(TRACE_syscall, syscall_dropped) >> #endif >> >> #ifndef seccomp >> -int seccomp(unsigned int op, unsigned int flags, struct sock_fprog *filter) >> +int seccomp(unsigned int op, unsigned int flags, void *args) >> { >> errno = 0; >> - return syscall(__NR_seccomp, op, flags, filter); >> + return syscall(__NR_seccomp, op, flags, args); >> } >> #endif >> >> -- >> 2.8.0.rc3 >> > > >