From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akw5J-0007WM-ER for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:01:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akw5D-0005r5-TG for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:01:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akw5D-0005qc-My for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:01:31 -0400 References: <1459161798-32120-1-git-send-email-den@openvz.org> <1459161798-32120-4-git-send-email-den@openvz.org> From: Eric Blake Message-ID: <56FAA6D9.8070800@redhat.com> Date: Tue, 29 Mar 2016 10:01:29 -0600 MIME-Version: 1.0 In-Reply-To: <1459161798-32120-4-git-send-email-den@openvz.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FhFI8TQQXSoqWAXvpNwjNjg5WnSGgNvu5" Subject: Re: [Qemu-devel] [PATCH 3/3] NBD proto: add "Command flags" section List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , nbd-general@lists.sourceforge.net, qemu-devel@nongnu.org Cc: Wouter Verhelst , Pavel Borzenkov , Alex Bligh This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FhFI8TQQXSoqWAXvpNwjNjg5WnSGgNvu5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/28/2016 04:43 AM, Denis V. Lunev wrote: > From: Pavel Borzenkov >=20 > Add separate "Command flags" section to make it clear which flags are > currently defined by the protocol. >=20 > Signed-off-by: Pavel Borzenkov > Reviewed-by: Roman Kagan > Signed-off-by: Denis V. Lunev > CC: Wouter Verhelst > CC: Eric Blake > CC: Alex Bligh > --- > doc/proto.md | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/doc/proto.md b/doc/proto.md > index 036d6d9..662f741 100644 > --- a/doc/proto.md > +++ b/doc/proto.md > @@ -485,6 +485,16 @@ The following request types exist: > Currently one such message is known: `NBD_CMD_CACHE`, with type se= t to > 5, implemented by xnbd. > =20 > +#### Command flags > + I think that this new content would belong better as a subsection under '#### Flag Fields', alongside the mention of all other flags. I'm going to propose a v2 of this patch with that alternate position, for compariso= n. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FhFI8TQQXSoqWAXvpNwjNjg5WnSGgNvu5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW+qbaAAoJEKeha0olJ0Nqd1MH/1bBn9CnAuE8XAyB3g0HL9RV zyCS8K8l1duMyi8uMW4Uz2o5Nr/HQR3CdmY7evcCldgWXtIIw3kYgI9M52gHnObY 9GicHUeKgQITY99lo8tLucOyTM3MlOzGW7jOMsbu0QMN8knWjo8PUwyxCw9su4OZ eW1hXjzJ88wT8Vde9oQvmdDwXeSpFFf4o2aB/l1TfdBz9h8vlRh3FDoBuzuzjS4W KGg75j4+cv2P5kuqL5m+bwAUgwEcEG3xLTsRDlqheADXObp+Re87MNi4WgrFqWcI 9oAJQvAAR2utuRzLO7gp4O/UsetIxaqfwXYyf8pB5GgWOGKE99Ecg55M2ynm3V0= =h3Ws -----END PGP SIGNATURE----- --FhFI8TQQXSoqWAXvpNwjNjg5WnSGgNvu5--