From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akw7M-0001ZL-Rx for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:03:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akw7H-0006as-1s for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:03:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akw7G-0006ak-OG for qemu-devel@nongnu.org; Tue, 29 Mar 2016 12:03:38 -0400 References: <1459161798-32120-1-git-send-email-den@openvz.org> <1459161798-32120-4-git-send-email-den@openvz.org> <56FAA6D9.8070800@redhat.com> From: Eric Blake Message-ID: <56FAA759.70801@redhat.com> Date: Tue, 29 Mar 2016 10:03:37 -0600 MIME-Version: 1.0 In-Reply-To: <56FAA6D9.8070800@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VKaLjln8xHFNBvh6QKJSFOd50tfmHFuKm" Subject: Re: [Qemu-devel] [PATCH 3/3] NBD proto: add "Command flags" section List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" , nbd-general@lists.sourceforge.net, qemu-devel@nongnu.org Cc: Wouter Verhelst , Pavel Borzenkov , Alex Bligh This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VKaLjln8xHFNBvh6QKJSFOd50tfmHFuKm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/29/2016 10:01 AM, Eric Blake wrote: > On 03/28/2016 04:43 AM, Denis V. Lunev wrote: >> From: Pavel Borzenkov >> >> Add separate "Command flags" section to make it clear which flags are >> currently defined by the protocol. >> >> Signed-off-by: Pavel Borzenkov >> Reviewed-by: Roman Kagan >> Signed-off-by: Denis V. Lunev >> CC: Wouter Verhelst >> CC: Eric Blake >> CC: Alex Bligh >> --- >> doc/proto.md | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/doc/proto.md b/doc/proto.md >> index 036d6d9..662f741 100644 >> --- a/doc/proto.md >> +++ b/doc/proto.md >> @@ -485,6 +485,16 @@ The following request types exist: >> Currently one such message is known: `NBD_CMD_CACHE`, with type s= et to >> 5, implemented by xnbd. >> =20 >> +#### Command flags >> + >=20 > I think that this new content would belong better as a subsection under= > '#### Flag Fields', alongside the mention of all other flags. I'm goin= g > to propose a v2 of this patch with that alternate position, for compari= son. Hmm, maybe not. I just looked again, and '#### Flag fields' is a subsection of '### Handshake phase', while you are correct that command flags belong to '### Transmission phase'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VKaLjln8xHFNBvh6QKJSFOd50tfmHFuKm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW+qdZAAoJEKeha0olJ0NqQD0IAKwx/uP7hbC8+5SzNBro7wwX 3eM0Z1CWsU5Vj3/FSFEPhaYqalzscM3lG33CQkyRH3LXiWupEUAEKALh33KDNeR/ 9DlbG7eGg4ewzE4DnvDoMipEpqsRBw9wNWRlYLLAX2RnJc/Ry8eFLiklbYECjXII 1xoyYlWCAatpc5LoLBpahtcYe6Pjk/p+gDxWzkMmAb5l85RQafhb+AX08eQJK3iu 4ltDHIT9Opthxs1QBYGfkNhJq/X5BGT2vRmwxtjTqnenHUi90awxYJHg4BI1GHB6 PtmA5PU34yNMdLYv/j2j9m83Uga6/BabUPkFaZTW/ezR+cTmNoNTHGmvyTiCLbE= =8OmG -----END PGP SIGNATURE----- --VKaLjln8xHFNBvh6QKJSFOd50tfmHFuKm--