Re: [PATCH v2 03/15] MIPS: PCI: Compatibility with ARM-like PCI host drivers

From: Florian Fainelli <f.fainelli@gmail.com>
To: Paul Burton <paul.burton@imgtec.com>,
	linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Cc: Joshua Kinard <kumba@gentoo.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
	Jens Axboe <axboe@fb.com>,
	linux-kernel@vger.kernel.org, Yijing Wang <wangyijing@huawei.com>,
	John Crispin <blogic@openwrt.org>,
	Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH v2 03/15] MIPS: PCI: Compatibility with ARM-like PCI host drivers
Date: Tue, 29 Mar 2016 16:19:44 -0700	[thread overview]
Message-ID: <56FB0D90.8000200@gmail.com> (raw)
In-Reply-To: <1454499045-5020-4-git-send-email-paul.burton@imgtec.com>

Le 03/02/2016 03:30, Paul Burton a écrit :
> Introduce support for struct hw_pci & the associated pci_common_init_dev
> function as used by the PCI drivers written for ARM platforms under
> drivers/pci. This is in preparation for reusing the xilinx-pcie driver
> on the MIPS Boston board.
> 
> Platforms that make use of this more generic code will need to select
> CONFIG_MIPS_GENERIC_PCI. Platforms which don't will continue to work as
> they have, with the intent that PCI drivers be migrated towards struct
> hw_pci & drivers/pci/ over time.
> 
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> ---

[snip]

> +		if (hw->preinit)
> +			hw->preinit();
> +
> +		ret = hw->setup(i, &ctl->sysdata);
> +		if (ret < 0) {

This needs to be ret <= 0 to be compliant with what ARM PCI host
controllers do, which is return 1 in case they could get hw->setup to
finish with success, and 0 or negative if they could not, see
arch/arm/kernel/bios32.c.
-- 
Florian