From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758421AbcC2Xqt (ORCPT ); Tue, 29 Mar 2016 19:46:49 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:18442 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751209AbcC2Xqq (ORCPT ); Tue, 29 Mar 2016 19:46:46 -0400 X-AuditID: cbfec7f4-f796c6d000001486-04-56fb13e2a339 Subject: Re: [PATCH V2 3/3] cpufreq: exynos: Use generic platdev driver To: Viresh Kumar , Arnd Bergmann References: <81a8da75a0e7783e2b47f9e04297f167e8134afe.1459233524.git.viresh.kumar@linaro.org> <3810049.oQlCXiQ5bk@wuerfel> Cc: "linux-arm-kernel@lists.infradead.org" , Rafael Wysocki , Arnd Bergmann , Kukjin Kim , Kukjin Kim , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Feng Xiao , Matthew McClintock , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , linux-samsung-soc , Linaro Kernel Mailman List From: Krzysztof Kozlowski Message-id: <56FB13DC.2090902@samsung.com> Date: Wed, 30 Mar 2016 08:46:36 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t/xa7qPhH+HGcxuYLZY2eNt8XfSMXaL /49es1q8fmFo0bvgKptF/+PXzBbvDz1jttj0+BqrxeVdc9gsPvceYbSYcX4fk8WnNxOZLM6c vsRqsfGrh8XWLT3sDvwev39NYvS43NfL5LFpVSebx51re9g8Ni+p97j97zGzx5ar7Swef2ft Z/Ho27KK0WP7tXnMHp83yQVwR3HZpKTmZJalFunbJXBldNzvZC/o4qw4++gZWwNjI3sXIyeH hICJxOGfJ1khbDGJC/fWs3UxcnEICSxllNi/4ysjhPOUUeL+o2dgVcIC7hLr721kBLFFBDwl Fh7cwQxR9IVRYvfNzcwgCWaBGywSu67WgNhsAsYSm5cvYQOxeQW0JC4eugFWwyKgKrH15Xsw W1QgQuLJ3JOMEDWCEj8m32MBsTkFgiU+HTwIdCoH0Ex1iSlTciHGy0tsXvOWeQKjwCwkHbMQ qmYhqVrAyLyKUTS1NLmgOCk911CvODG3uDQvXS85P3cTIyTSvuxgXHzM6hCjAAejEg9vxKKf YUKsiWXFlbmHGCU4mJVEeJ/y/w4T4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjt31/sQIYH0xJLU 7NTUgtQimCwTB6dUA2NRPXO5yv3TTSphu/l9TN30T5sqvavwv+YRycmguunAlSdh5178tKpb lqU7vy+2d29owL7zccndPWsKCvhiV9quZtz75VGumxBfwdaP4Q+XBqqwGc22cMv26rm6av87 g+dJwou8rytf+n23zNvxz4TjO/MtlJ4IHfj7MNuwj1V/fqXLXdYli5RYijMSDbWYi4oTAQlr qUewAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.03.2016 00:22, Viresh Kumar wrote: > On 29 March 2016 at 20:34, Arnd Bergmann wrote: >> On Tuesday 29 March 2016 12:09:49 Viresh Kumar wrote: >>> -static void __init exynos_cpufreq_init(void) >>> -{ >>> - struct device_node *root = of_find_node_by_path("/"); >>> - const struct of_device_id *match; >>> - >>> - match = of_match_node(exynos_cpufreq_matches, root); >>> - if (!match) { >>> - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); >>> - return; >>> - } >>> - >>> - platform_device_register_simple(match->data, -1, NULL, 0); >>> -} >> >> How is the "exynos-cpufreq" case handled now? Is that no longer used now? >> I assume the patch is correct based on Krzysztof's review, but it might be >> good to explain this better. > > That's stale code, the driver got removed some time back. Yeah, that's old driver, no longer existing. It makes sense to split the patch - first remove the stale exynos-cpufreq and then move cpufreq-dt. This would help avoid confusion when grepping through the history. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Wed, 30 Mar 2016 08:46:36 +0900 Subject: [PATCH V2 3/3] cpufreq: exynos: Use generic platdev driver In-Reply-To: References: <81a8da75a0e7783e2b47f9e04297f167e8134afe.1459233524.git.viresh.kumar@linaro.org> <3810049.oQlCXiQ5bk@wuerfel> Message-ID: <56FB13DC.2090902@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30.03.2016 00:22, Viresh Kumar wrote: > On 29 March 2016 at 20:34, Arnd Bergmann wrote: >> On Tuesday 29 March 2016 12:09:49 Viresh Kumar wrote: >>> -static void __init exynos_cpufreq_init(void) >>> -{ >>> - struct device_node *root = of_find_node_by_path("/"); >>> - const struct of_device_id *match; >>> - >>> - match = of_match_node(exynos_cpufreq_matches, root); >>> - if (!match) { >>> - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); >>> - return; >>> - } >>> - >>> - platform_device_register_simple(match->data, -1, NULL, 0); >>> -} >> >> How is the "exynos-cpufreq" case handled now? Is that no longer used now? >> I assume the patch is correct based on Krzysztof's review, but it might be >> good to explain this better. > > That's stale code, the driver got removed some time back. Yeah, that's old driver, no longer existing. It makes sense to split the patch - first remove the stale exynos-cpufreq and then move cpufreq-dt. This would help avoid confusion when grepping through the history. Best regards, Krzysztof