From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alAOt-0005mx-UU for qemu-devel@nongnu.org; Wed, 30 Mar 2016 03:18:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alAOp-0004dc-UA for qemu-devel@nongnu.org; Wed, 30 Mar 2016 03:18:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alAOp-0004dW-OQ for qemu-devel@nongnu.org; Wed, 30 Mar 2016 03:18:43 -0400 References: <1458902535-9715-1-git-send-email-109lozanoi@gmail.com> From: Thomas Huth Message-ID: <56FB7DD0.7070501@redhat.com> Date: Wed, 30 Mar 2016 09:18:40 +0200 MIME-Version: 1.0 In-Reply-To: <1458902535-9715-1-git-send-email-109lozanoi@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] util: Improved qemu_hexmap() to include an ascii dump of the buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaac Lozano <109lozanoi@gmail.com>, qemu-devel@nongnu.org, jasowang@redhat.com Cc: Peter Crosthwaite , jsnow@redhat.com, kraxel@redhat.com There's a typo in the title: qemu_hexmap should be qemu_hexdump/ instead. On 25.03.2016 11:42, Isaac Lozano wrote: > qemu_hexdump() in util/hexdump.c has been changed to give also include = a > ascii dump of the buffer. Also, calls to hex_dump() in net/net.c have > been replaced with calls to qemu_hexdump(). This takes care of two misc > BiteSized Tasks. >=20 > Signed-off-by: Isaac Lozano <109lozanoi@gmail.com> > --- >=20 > v2: Fixed code-style and made debug line smaller. >=20 > net/net.c | 30 +----------------------------- > util/hexdump.c | 33 ++++++++++++++++++++++----------- > 2 files changed, 23 insertions(+), 40 deletions(-) [...] Code looks fine now, thanks for taking care of this! Reviewed-by: Thomas Huth Jason, since there is no explicit maintainer for util/hexdump.c, could you maybe take this through your net tree, since this patch touches net/net.c as well? Thomas