From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754058AbcC3NxH (ORCPT ); Wed, 30 Mar 2016 09:53:07 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:58478 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753005AbcC3NxE (ORCPT ); Wed, 30 Mar 2016 09:53:04 -0400 Subject: Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child To: Felipe Balbi , "Thang Q. Nguyen" , Greg Kroah-Hartman , , , , , Arnd Bergmann , "Karicheri, Muralidharan" , Peter Ujfalusi References: <1457594332-7490-1-git-send-email-tqnguyen@apm.com> <1457594332-7490-3-git-send-email-tqnguyen@apm.com> <87mvpgi02f.fsf@intel.com> CC: Phong Vo , Loc Ho , , Santosh Shilimkar , "Ben Dooks (embedded platforms)" From: Grygorii Strashko Message-ID: <56FBDA0D.4030507@ti.com> Date: Wed, 30 Mar 2016 16:52:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <87mvpgi02f.fsf@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/30/2016 04:10 PM, Felipe Balbi wrote: > "Thang Q. Nguyen" writes: > >> [ text/plain ] >> From: "Thang Q. Nguyen" >> >> The xhci-hcd child node needs to inherit archdata attribute to use >> dma_ops functions and attributes. This patch enables the USB DWC3 >> driver to pass archdata attributes to its xhci-hcd child node. >> >> Changes from v2: >> - None >> >> Changes from v1: >> - None > > changes should be between tearline and diffstat. > uh. This become a real problem :(, especially with LPAE enabled. DMA properties need to be inherited not only here, but also in usb_add_gadget_udc_release(). And probably in other places where devices are created manually - the worst case : device is created manually but doesn't belong to any bus. And DMA configuration must include dma_pfn_offset also! And how about iommu staff? FYI. Solution used for PCI c49b8fc of/pci: Add of_pci_dma_configure() to update DMA configuration Rejected: introduce dma_init_dev_from_parent() or smth. like this http://permalink.gmane.org/gmane.linux.ports.arm.kernel/378317 https://lkml.org/lkml/2014/11/4/519 -- regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH v3 2/2] usb:dwc3: pass arch data to xhci-hcd child Date: Wed, 30 Mar 2016 16:52:13 +0300 Message-ID: <56FBDA0D.4030507@ti.com> References: <1457594332-7490-1-git-send-email-tqnguyen@apm.com> <1457594332-7490-3-git-send-email-tqnguyen@apm.com> <87mvpgi02f.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87mvpgi02f.fsf@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Felipe Balbi , "Thang Q. Nguyen" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm@lists.infradead.org, Arnd Bergmann , "Karicheri, Muralidharan" , Peter Ujfalusi Cc: Phong Vo , Loc Ho , patches@apm.com, Santosh Shilimkar , "Ben Dooks (embedded platforms)" List-Id: linux-omap@vger.kernel.org On 03/30/2016 04:10 PM, Felipe Balbi wrote: > "Thang Q. Nguyen" writes: > >> [ text/plain ] >> From: "Thang Q. Nguyen" >> >> The xhci-hcd child node needs to inherit archdata attribute to use >> dma_ops functions and attributes. This patch enables the USB DWC3 >> driver to pass archdata attributes to its xhci-hcd child node. >> >> Changes from v2: >> - None >> >> Changes from v1: >> - None > > changes should be between tearline and diffstat. > uh. This become a real problem :(, especially with LPAE enabled. DMA properties need to be inherited not only here, but also in usb_add_gadget_udc_release(). And probably in other places where devices are created manually - the worst case : device is created manually but doesn't belong to any bus. And DMA configuration must include dma_pfn_offset also! And how about iommu staff? FYI. Solution used for PCI c49b8fc of/pci: Add of_pci_dma_configure() to update DMA configuration Rejected: introduce dma_init_dev_from_parent() or smth. like this http://permalink.gmane.org/gmane.linux.ports.arm.kernel/378317 https://lkml.org/lkml/2014/11/4/519 -- regards, -grygorii