From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1alIQL-0000bs-QV for mharc-grub-devel@gnu.org; Wed, 30 Mar 2016 11:52:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alIQJ-0000XK-7b for grub-devel@gnu.org; Wed, 30 Mar 2016 11:52:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alIQI-0005K1-BR for grub-devel@gnu.org; Wed, 30 Mar 2016 11:52:47 -0400 Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:36706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alIQI-0005JS-4y for grub-devel@gnu.org; Wed, 30 Mar 2016 11:52:46 -0400 Received: by mail-wm0-x235.google.com with SMTP id 127so102912335wmu.1 for ; Wed, 30 Mar 2016 08:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=QGNdcob0GaOAQuuBsJvDgj+OB+DpIAiOwr8TXnlRY1U=; b=NhaNoWL57+1L874UMWb+p+016Pr9u23JLtAwojNuicgRLYFPd+bDdX1Ch3pnoghp9P j3lqkjv9m5oDKUA6pyzgV6C0/QLBKuTzKlaihe3+8SeM0ilTmS8ZRI0B/GwuPR7HtSzd OlC9ul3BE8Kl91xiL+HUwM5zYPTxkHKq3CVwo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=QGNdcob0GaOAQuuBsJvDgj+OB+DpIAiOwr8TXnlRY1U=; b=FdrDBT7dpiF2cFM9DMH/mPQMkvAxeoxLaaduw6v93UzePSKzEyFvQLnWCHy+l2kP99 /mKPs2ajJ0wgpJkFrazFh7iIE16Q8ypsnMf4lOFuVUDdnyZwX6JlhpRg8CAjxRDOirjv L/MUR4bx7xuD1mxWN+KQqzaNkQDUoFj4/0yWSnZ+mq9g+lN0++T2ZNiIM9ecnWCswrB+ wNDtmFNzJZwOr80EPaxeDZtFbamn5+Bj+U0Wgf5Yd6IhGIhVmjQnB8Z+OQCq2xqzi7AP d+6iB2bgOqgy+9e60aEBodbF5chAeqMIeje+ogrvf1Qfu+O5BRG/09FCWpm/SlKdhQW4 NG+Q== X-Gm-Message-State: AD7BkJIZBNU8T6XRrvg/qIncgXfXB222ISzkUfNR+VWQpzw4nbVXhZ3aqcjACGA0HPtyDQgS X-Received: by 10.28.63.68 with SMTP id m65mr11376708wma.95.1459353165165; Wed, 30 Mar 2016 08:52:45 -0700 (PDT) Received: from ?IPv6:::1? ([2001:41d0:1:6c23::1]) by smtp.gmail.com with ESMTPSA id w184sm5104655wmb.1.2016.03.30.08.52.44 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 30 Mar 2016 08:52:44 -0700 (PDT) Subject: Re: [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64 To: grub-devel@gnu.org References: <1455899332-9054-1-git-send-email-julien.grall@linaro.org> From: Julien Grall Message-ID: <56FBF64A.5050105@linaro.org> Date: Wed, 30 Mar 2016 16:52:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1455899332-9054-1-git-send-email-julien.grall@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::235 Cc: ian.campbell@citrix.com, steve.capper@arm.com, phcoder@gmail.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2016 15:52:48 -0000 Hello, Ping? Regards, On 19/02/16 16:28, Julien Grall wrote: > Xen is currently crashing because of malformed compatible property for > the boot module. This is because the property string is not > null-terminated as requested by the ePAR spec. > --- > grub-core/loader/arm64/xen_boot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/grub-core/loader/arm64/xen_boot.c b/grub-core/loader/arm64/xen_boot.c > index a914eb8..8ae43d7 100644 > --- a/grub-core/loader/arm64/xen_boot.c > +++ b/grub-core/loader/arm64/xen_boot.c > @@ -156,7 +156,7 @@ prepare_xen_module_params (struct xen_boot_binary *module, void *xen_boot_fdt) > grub_fdt_add_subnode (xen_boot_fdt, chosen_node, module_name); > > retval = grub_fdt_set_prop (xen_boot_fdt, module_node, "compatible", > - MODULE_CUSTOM_COMPATIBLE, sizeof(MODULE_CUSTOM_COMPATIBLE) - 1); > + MODULE_CUSTOM_COMPATIBLE, sizeof(MODULE_CUSTOM_COMPATIBLE)); > if (retval) > return grub_error (GRUB_ERR_IO, "failed to update FDT"); > > -- Julien Grall