From: Li Zhijian <lizhijian@cn.fujitsu.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
Gui jianfeng <guijianfeng@cn.fujitsu.com>,
Jason Wang <jasowang@redhat.com>,
"eddie.dong" <eddie.dong@intel.com>,
qemu devel <qemu-devel@nongnu.org>,
Yang Hongyang <hongyang.yang@easystack.cn>
Subject: Re: [Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet comparison thread
Date: Thu, 31 Mar 2016 10:17:53 +0800 [thread overview]
Message-ID: <56FC88D1.8080902@cn.fujitsu.com> (raw)
In-Reply-To: <20160330114143.GA7580@work-vm>
On 03/30/2016 07:41 PM, Dr. David Alan Gilbert wrote:
[...]
>> >@@ -433,7 +532,9 @@ static void compare_pri_chr_in(void *opaque, const uint8_t *buf, int size)
>> > if (ret == 1) {
>> > if (packet_enqueue(s, PRIMARY_IN)) {
>> > error_report("primary: unsupported packet in");
>> >- compare_chr_send(s->chr_out, buf, size);
>> >+ compare_chr_send(s->chr_out, s->pri_rs.buf, s->pri_rs.packet_len);
> Doesn't that change belong in an earlier patch?
>
>> >+ } else {
>> >+ qemu_event_set(&s->event);
> Also these - why are these in this patch?
This event is to wakeup comparison thread to do compare.
Do you think we should put event related code to patch 2 ?
Thanks
Li
>
>> > }
next prev parent reply other threads:[~2016-03-31 2:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 8:35 [Qemu-devel] [PATCH V2 0/3] Introduce COLO-compare Zhang Chen
2016-03-30 8:35 ` [Qemu-devel] [PATCH V2 1/3] colo-compare: introduce colo compare initlization Zhang Chen
2016-03-30 9:25 ` Dr. David Alan Gilbert
2016-03-31 1:41 ` Zhang Chen
2016-03-31 7:25 ` Zhang Chen
2016-03-31 9:24 ` Dr. David Alan Gilbert
2016-04-01 5:11 ` Jason Wang
2016-04-01 5:41 ` Li Zhijian
2016-04-13 2:02 ` Zhang Chen
2016-03-30 8:35 ` [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and enqueue packet Zhang Chen
2016-03-30 10:36 ` Dr. David Alan Gilbert
2016-03-31 2:09 ` Li Zhijian
2016-03-31 8:47 ` Dr. David Alan Gilbert
2016-03-31 4:06 ` Zhang Chen
2016-03-31 4:23 ` Li Zhijian
2016-03-31 4:44 ` Zhang Chen
2016-03-30 8:35 ` [Qemu-devel] [PATCH V2 3/3] colo-compare: introduce packet comparison thread Zhang Chen
2016-03-30 11:41 ` Dr. David Alan Gilbert
2016-03-31 2:17 ` Li Zhijian [this message]
2016-03-31 8:50 ` Dr. David Alan Gilbert
2016-03-31 6:00 ` Zhang Chen
2016-03-30 12:05 ` [Qemu-devel] [PATCH V2 0/3] Introduce COLO-compare Dr. David Alan Gilbert
2016-03-31 3:01 ` Li Zhijian
2016-03-31 9:43 ` Dr. David Alan Gilbert
2016-04-01 1:40 ` Li Zhijian
2016-03-31 6:48 ` Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC88D1.8080902@cn.fujitsu.com \
--to=lizhijian@cn.fujitsu.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=hongyang.yang@easystack.cn \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.