From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40358)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1alU9A-0004av-6P
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 00:23:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1alU96-0007E6-6H
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 00:23:52 -0400
Received: from [59.151.112.132] (port=39731 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lizhijian@cn.fujitsu.com>) id 1alU92-0007DK-Fi
	for qemu-devel@nongnu.org; Thu, 31 Mar 2016 00:23:48 -0400
References: <1459326950-17708-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<1459326950-17708-3-git-send-email-zhangchen.fnst@cn.fujitsu.com>
	<20160330103640.GC2471@work-vm> <56FCA237.5040507@cn.fujitsu.com>
From: Li Zhijian <lizhijian@cn.fujitsu.com>
Message-ID: <56FCA64D.8020208@cn.fujitsu.com>
Date: Thu, 31 Mar 2016 12:23:41 +0800
MIME-Version: 1.0
In-Reply-To: <56FCA237.5040507@cn.fujitsu.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V2 2/3] colo-compare: track connection and
	enqueue packet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Gui jianfeng <guijianfeng@cn.fujitsu.com>, Jason Wang <jasowang@redhat.com>, "eddie.dong" <eddie.dong@intel.com>, qemu devel <qemu-devel@nongnu.org>, Yang Hongyang <hongyang.yang@easystack.cn>



On 03/31/2016 12:06 PM, Zhang Chen wrote:
>>>
>>> +static void packet_destroy(void *opaque, void *user_data)
>>> +{
>>> +    Packet *pkt = opaque;
>>> +
>>> +    g_free(pkt->data);
>>> +    g_slice_free(Packet, pkt);
>>> +}
>>> +
>>> +static inline void colo_flush_connection(void *opaque, void *user_data)
>>> +{
>> Is this used?
>
> will be used, like lizhijian said.

I mean you should remove this now, and re-introduce when you integrate to COLO frame

Thanks
Li Zhijian