From: Igor Fedotov <ifedotov@mirantis.com>
To: Allen Samuels <Allen.Samuels@sandisk.com>, Sage Weil <sage@newdream.net>
Cc: ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: Adding compression/checksum support for bluestore.
Date: Thu, 31 Mar 2016 20:18:24 +0300 [thread overview]
Message-ID: <56FD5BE0.4040801@mirantis.com> (raw)
In-Reply-To: <CY1PR0201MB1897E7C6A58679883F375F60E8990@CY1PR0201MB1897.namprd02.prod.outlook.com>
On 31.03.2016 19:32, Allen Samuels wrote:
>> But do we really need to store checksums as metadata? What's about
>> pre(post)fixing 4K-4(?) blob with the checksum and store this pair to
>> the disk. IMO we always need checksum values along with blob data
>> thus let's store and read them together. This immediately eliminates
>> the question about the granularity and corresponding overhead... Have
>> I missed something?
> If you store them inline with the data then nothing lines up on boundaries that the HW designers expect and you end up doing things like extra-copying of every data buffer. This will kill performance.
Perhaps you are right.
But not sure I fully understand what HW designers you mean here. Are you
considering the case when Ceph is embedded into some hardware and
incoming RW requests always operate aligned data and supposed to have
the same alignment for data saved to disk?
IMHO proper data alignment in the incoming requests is a particular
case. Generally we don't have such a trait. Moreover compression
completely destroys it if any. Thus in many cases we can easily append
an additional data portion containing a checksum.
>
> If you store them in a separate place (not in metadata, not contiguous to data) then you'll have a full extra I/O that might even move the head (yikes!). Plus you'll have to deal with the RMW of these tiny things.
Agree - that's not an option.
> Putting them in the metadata is really the only viable option.
next prev parent reply other threads:[~2016-03-31 17:18 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 19:46 Adding compression/checksum support for bluestore Allen Samuels
2016-03-30 20:41 ` Vikas Sinha-SSI
2016-03-30 22:24 ` Sage Weil
2016-03-30 22:35 ` Allen Samuels
2016-03-31 16:31 ` Igor Fedotov
2016-03-30 22:15 ` Sage Weil
2016-03-30 22:22 ` Gregory Farnum
2016-03-30 22:30 ` Sage Weil
2016-03-30 22:43 ` Allen Samuels
2016-03-30 22:32 ` Allen Samuels
2016-03-30 22:52 ` Allen Samuels
2016-03-30 22:57 ` Sage Weil
2016-03-30 23:03 ` Gregory Farnum
2016-03-30 23:08 ` Allen Samuels
2016-03-31 23:02 ` Milosz Tanski
2016-04-01 3:56 ` Chris Dunlop
2016-04-01 4:56 ` Sage Weil
2016-04-01 5:28 ` Chris Dunlop
2016-04-01 14:58 ` Sage Weil
2016-04-01 19:49 ` Chris Dunlop
2016-04-01 23:08 ` Allen Samuels
2016-04-02 2:23 ` Allen Samuels
2016-04-02 2:51 ` Gregory Farnum
2016-04-02 5:05 ` Chris Dunlop
2016-04-02 5:48 ` Allen Samuels
2016-04-02 6:18 ` Gregory Farnum
2016-04-03 13:27 ` Sage Weil
2016-04-04 15:33 ` Chris Dunlop
2016-04-04 15:51 ` Chris Dunlop
2016-04-04 17:58 ` Allen Samuels
2016-04-04 15:26 ` Chris Dunlop
2016-04-04 17:56 ` Allen Samuels
2016-04-02 5:08 ` Allen Samuels
2016-04-02 4:07 ` Chris Dunlop
2016-04-02 5:38 ` Allen Samuels
2016-04-04 15:00 ` Chris Dunlop
2016-04-04 23:58 ` Allen Samuels
2016-04-05 12:35 ` Sage Weil
2016-04-05 15:10 ` Chris Dunlop
2016-04-06 6:38 ` Chris Dunlop
2016-04-06 15:47 ` Allen Samuels
2016-04-06 17:17 ` Chris Dunlop
2016-04-06 18:06 ` Allen Samuels
2016-04-07 0:43 ` Chris Dunlop
2016-04-07 0:52 ` Allen Samuels
2016-04-07 2:59 ` Chris Dunlop
2016-04-07 9:51 ` Willem Jan Withagen
2016-04-07 12:21 ` Atchley, Scott
2016-04-07 15:01 ` Willem Jan Withagen
2016-04-07 9:51 ` Chris Dunlop
2016-04-08 23:16 ` Allen Samuels
2016-04-05 20:41 ` Allen Samuels
2016-04-05 21:14 ` Sage Weil
2016-04-05 12:57 ` Dan van der Ster
2016-04-05 20:50 ` Allen Samuels
2016-04-06 7:15 ` Dan van der Ster
2016-03-31 16:27 ` Igor Fedotov
2016-03-31 16:32 ` Allen Samuels
2016-03-31 17:18 ` Igor Fedotov [this message]
2016-03-31 17:39 ` Piotr.Dalek
2016-03-31 18:44 ` Allen Samuels
2016-03-31 16:58 ` Igor Fedotov
2016-03-31 18:38 ` Allen Samuels
2016-04-04 12:14 ` Igor Fedotov
2016-04-04 14:44 ` Allen Samuels
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD5BE0.4040801@mirantis.com \
--to=ifedotov@mirantis.com \
--cc=Allen.Samuels@sandisk.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.