From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758737AbcDAKn2 (ORCPT ); Fri, 1 Apr 2016 06:43:28 -0400 Received: from mga04.intel.com ([192.55.52.120]:1479 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbcDAKn0 (ORCPT ); Fri, 1 Apr 2016 06:43:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,427,1455004800"; d="scan'208";a="949525651" Message-ID: <56FE5251.5020806@linux.intel.com> Date: Fri, 01 Apr 2016 13:49:53 +0300 From: Mathias Nyman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Rajesh Bhagat CC: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sriram Dash Subject: Re: [PATCH] usb: xhci: Fix incomplete PM resume operation due to XHCI commmand timeout References: <1458284463-12743-1-git-send-email-rajesh.bhagat@nxp.com> <56EBE485.1060301@linux.intel.com> <56EFBBD1.6080600@intel.com> <56F1350B.7000006@linux.intel.com> <56F2A697.1000701@linux.intel.com> <56FAB97F.4030206@linux.intel.com> <56FD35F4.3020005@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.04.2016 06:55, Rajesh Bhagat wrote: >>> >>> Please share your opinion on other changes for patch submission as well as resume >> time. >>> > >> >> I think more effort should be put into investigating why this happens in the first place. >> What is the root cause? why doesn't xhci start properly after resume in this case. >> > Hello Mathias, > > I understand your point and would surely debug the root cause of the issue. But implementing the > fallback mechanism in SW, if HW does not respond well seems to a better solution to me. > Yes, I'll add something like this, at least the xhci parts to make sure the completions are called. This is not really a fallback, it's just a better burial for xhci. It will be unusable after this. -Mathias