All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>
To: Felix Kuehling <Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 1/3] drm/radeon: Make CIK support in Radeon conditional (v2)
Date: Mon, 10 Apr 2017 09:56:41 +0900	[thread overview]
Message-ID: <56a29a84-7b92-a666-5d0b-b6c2f3395b21@daenzer.net> (raw)
In-Reply-To: <1491596149-3709-1-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>

On 08/04/17 05:15 AM, Felix Kuehling wrote:
> Advertise CIK PCI IDs only when they are not supported by amdgpu.
> Use the CONFIG_DRM_AMDGPU_CIK to check so that a single option in
> the kernel config keeps both drivers in sync.
> 
> This is the simplest possible change. A more complete solution
> may want to conditionally disable more CIK-specific code in the
> Radeon driver.
> 
> v2: Add CONFIG_DRM_RADEON_FORCE_CIK option
> 
> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>

I don't think this is good enough a solution.

I want to be able to choose the driver to use at runtime, for each GPU
individually. To make that possible, we probably need some kind of
kernel command line option which is respected by both radeon and amdgpu
drivers, plus possibly additional per-driver module parameters which can
override that kernel command line option.

CONFIG_DRM_AMDGPU_CIK/SI would then simply define which driver gets to
drive CIK/SI GPUs by default.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2017-04-10  0:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 20:15 [PATCH 1/3] drm/radeon: Make CIK support in Radeon conditional (v2) Felix Kuehling
     [not found] ` <1491596149-3709-1-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
2017-04-07 20:15   ` [PATCH 2/3] drm/radeon: Make SI support in Radeon conditional Felix Kuehling
     [not found]     ` <1491596149-3709-2-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
2017-04-12 14:58       ` Li, Samuel
2017-04-07 20:15   ` [PATCH 3/3] drm/amdgpu: CIK support is no longer experimental Felix Kuehling
     [not found]     ` <1491596149-3709-3-git-send-email-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
2017-04-08  8:50       ` Nicolai Hähnle
     [not found]         ` <f1c88cc8-9c62-52eb-fb21-a5048f771c7e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-10 22:06           ` Felix Kuehling
     [not found]             ` <5ba7f549-d3b3-e817-8673-cdfbe8539314-5C7GfCeVMHo@public.gmane.org>
2017-04-13 16:41               ` Nicolai Hähnle
     [not found]                 ` <30b88eb7-6b6b-fd52-fcb2-0fd11c9155f6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-04-13 19:51                   ` Marek Olšák
2017-04-08  8:47   ` [PATCH 1/3] drm/radeon: Make CIK support in Radeon conditional (v2) Christian König
2017-04-08 15:42   ` Emil Velikov
2017-04-10  0:56   ` Michel Dänzer [this message]
     [not found]     ` <56a29a84-7b92-a666-5d0b-b6c2f3395b21-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-04-10  1:28       ` Michel Dänzer
     [not found]         ` <64d15f06-1560-825c-c186-2209f87908fc-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-04-10 18:13           ` Felix Kuehling
     [not found]             ` <74d677b8-6b81-e137-af67-ec4834c72bcc-5C7GfCeVMHo@public.gmane.org>
2017-04-10 18:50               ` Alex Deucher
     [not found]                 ` <CADnq5_Pz-NymmWd6ExLNxRJ=UVygHsQcaua26ULZstZ409LZzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-04-10 20:09                   ` Felix Kuehling
2017-04-11  1:39               ` Michel Dänzer
     [not found]                 ` <5aad3a06-180b-ff87-e9c9-c0399ddcf67b-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-04-11 16:13                   ` Felix Kuehling
     [not found]                     ` <bb600a20-2679-004f-15e9-9dd12ae305c1-5C7GfCeVMHo@public.gmane.org>
2017-04-12  2:30                       ` Michel Dänzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56a29a84-7b92-a666-5d0b-b6c2f3395b21@daenzer.net \
    --to=michel-otuistvhuppr7s880joybq@public.gmane.org \
    --cc=Felix.Kuehling-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.