All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gal Pressman <gal@nvidia.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Coco Li <lixiaoyan@google.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net-next] gro: add ability to control gro max packet size
Date: Sun, 9 Jan 2022 16:43:01 +0200	[thread overview]
Message-ID: <56b6d708-b05f-6871-1779-45798a2eccdb@nvidia.com> (raw)
In-Reply-To: <20220105104838.2246803-1-eric.dumazet@gmail.com>

On 05/01/2022 12:48, Eric Dumazet wrote:
> From: Coco Li <lixiaoyan@google.com>
>
> Eric Dumazet suggested to allow users to modify max GRO packet size.
>
> We have seen GRO being disabled by users of appliances (such as
> wifi access points) because of claimed bufferbloat issues,
> or some work arounds in sch_cake, to split GRO/GSO packets.
>
> Instead of disabling GRO completely, one can chose to limit
> the maximum packet size of GRO packets, depending on their
> latency constraints.
>
> This patch adds a per device gro_max_size attribute
> that can be changed with ip link command.
>
> ip link set dev eth0 gro_max_size 16000
>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Coco Li <lixiaoyan@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>

I wonder if this parameter should apply to HW-GRO as well, I assume it could benefit from that as well?


      parent reply	other threads:[~2022-01-09 14:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05 10:48 [PATCH net-next] gro: add ability to control gro max packet size Eric Dumazet
2022-01-06 12:40 ` patchwork-bot+netdevbpf
2022-01-09 14:43 ` Gal Pressman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56b6d708-b05f-6871-1779-45798a2eccdb@nvidia.com \
    --to=gal@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=kuba@kernel.org \
    --cc=lixiaoyan@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.