From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05227C636C9 for ; Wed, 21 Jul 2021 17:48:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B1606121F for ; Wed, 21 Jul 2021 17:48:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B1606121F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 24BFD6B006C; Wed, 21 Jul 2021 13:48:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FBF56B0070; Wed, 21 Jul 2021 13:48:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0767E6B0071; Wed, 21 Jul 2021 13:48:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E0F4D6B006C for ; Wed, 21 Jul 2021 13:48:47 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8A955184F1702 for ; Wed, 21 Jul 2021 17:48:47 +0000 (UTC) X-FDA: 78387330294.39.41105ED Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf16.hostedemail.com (Postfix) with ESMTP id 0BC7FF004262 for ; Wed, 21 Jul 2021 17:48:46 +0000 (UTC) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16LHklWX025725; Wed, 21 Jul 2021 17:48:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=ciYTohclfoqStTstzFNa2IMOnRAkvUC6nVzJXxhh1u8=; b=eosC5Z3NLMBeAShwXHNx81vu9iZuEEiS5c97OTMcsQcHD0MQGsk9NIXCRoV6Kb3E3S9W lt0cEeBYpMAcMhfBsMRNO3sOIZWJLofSGHb40+oIFR2CS9p50v4GoklVMqTZaXFG7QiC y7PUs5vkcnGEklg4xq+cyzNXt3M+JSHou5mZxFuehuPgNVitK4RCDnC769LV7fq8UoD3 +tRVQMJdrpidx5acLoUJunyTowYNZOm1WwVklC81GG8abhGnecQ0o5ZL1Gul+Z0xKRt/ JTBSJeeFgqtvbg69Y9283x64ZZ414gtyTkeuBjZ+bPYKne6Rw0XhoN31OREp1LqPf90G 8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=ciYTohclfoqStTstzFNa2IMOnRAkvUC6nVzJXxhh1u8=; b=Q+C1gNGcKXWHYn6rYF0EkBt52rDtyEd7VlmTGMfj+QgOzb3cXPEiGA1tfUKzh9e4wbJI p//IJEk6/BYmHFyRyvw03vfXTXrZ+C8Auv5vUa7kjPPimY+EWDeWa0sydLSiDDv07Z4O 3qoupCUVktMS1kWfudO9EGgIq9m8UAb+VQCPSXUTxc7EqvJarLAXlqpBogeRwC/u9DsB Eb9phFbnN3s44hAIdcD+1bqavdSXrseVR9WZRwgU08YmsbDmPJzt38FlCoDNyRpUbgp1 MJQlRIN1QrYKKfTMvhtn9TagTzDHF6/0jLDtVSq30AibRbjsDBHQMoGqYKr8xocZA31A ug== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 39wvr8bfxs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Jul 2021 17:48:27 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16LHjMjr056702; Wed, 21 Jul 2021 17:48:26 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam08lp2047.outbound.protection.outlook.com [104.47.73.47]) by aserp3030.oracle.com with ESMTP id 39wunmdc4j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Jul 2021 17:48:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f8JjFkGhZh8yjev70C4e8k1DeZKwkV0NkZewKheR09Rmb1goC1spxK+jTNICEadJPM2OnR472GdwtoVCI9p2RoaLbMtWxoO/TEwOWq6amI5NeWyavptj4h0K20RyVN+KHhLtoK4ukj+dptSu+CJhR8+dQ72UYhq482O8MJz7JK89VvphADcAyu+H9Fq/Rm66VgG7OpOiXTmtYbjWxzMIUskmMVtTTucqMIdL7H3FG/SwteoatkQqwFaOG4JEdSVwGGXLqwTfu5+UuPjOSvIdNMGubnGiMVVeVgn9dXk9QOp9RBUMZ/RXmE2hLqFGlKDCj7LPoIl68JWeff/rBxhC9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ciYTohclfoqStTstzFNa2IMOnRAkvUC6nVzJXxhh1u8=; b=K/pjTCSr6kXbius5JChh/yrnUMgQdOP1OtkbzTz2rAyM/6bgcVbRVYLh3ml20585wTtnIt4p68kCltZWFt93Nyso3ed2+hVbOPDJ8A5L8PhyF1sWlObnhR5AYO7uiMbkfSpl/gWwoalxhMZm66xvfwrqFp3tfR8AYDX594SUzhjEsRu+vLWFqJGgIRj2gsiznkl0RUevf9uGtMfdb2VEi+fV1/fMaVab1wycM4wT2WYhB6SGUzyB9zPjG+XRheeUkIPCt8xtYUHPZL39TPo83Lv4NFfVof7GZw/B4vdYefDBLVhH7eD6wuBomgn8/KyfC0iF1mvCzkORLoKQGLDlIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ciYTohclfoqStTstzFNa2IMOnRAkvUC6nVzJXxhh1u8=; b=uLjOdegLzL8hXTEu7D5DNem9z5BC5S7X6m7f4/fjTIA2zoxpGqu+d69NG94egSbqJj8yVxlQuorMQdk2rm0nkJLwIFVYH1zVMLRIORxN0rNHQewKRRmRip+yof7DQz/whE1VMonFH/Wpei0MBE1A3RL6ejKW39N7oPf+7PA1p3k= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by BYAPR10MB2951.namprd10.prod.outlook.com (2603:10b6:a03:84::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.29; Wed, 21 Jul 2021 17:48:24 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::8d2a:558d:ab4a:9c2a]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::8d2a:558d:ab4a:9c2a%5]) with mapi id 15.20.4331.034; Wed, 21 Jul 2021 17:48:24 +0000 Subject: Re: [Bug 213785] New: hugetlbfs scrambles mode when sticky bit is set To: Matthew Wilcox Cc: Andrew Morton , bugs+kernel.org@dtnr.ch, David Howells , Al Viro , bugzilla-daemon@bugzilla.kernel.org, linux-mm@kvack.org References: <20210720150704.59f78224be810a0cf9dd5f39@linux-foundation.org> <4a02aa78-c600-f2f4-c7d3-d79164c2c8a1@oracle.com> From: Mike Kravetz Message-ID: <56c26b2b-0919-8d71-7846-8b6c9100c0a8@oracle.com> Date: Wed, 21 Jul 2021 10:48:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CO2PR05CA0008.namprd05.prod.outlook.com (2603:10b6:102:2::18) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.112] (50.38.35.18) by CO2PR05CA0008.namprd05.prod.outlook.com (2603:10b6:102:2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.10 via Frontend Transport; Wed, 21 Jul 2021 17:48:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 953995d3-591e-49df-0dab-08d94c6fbca8 X-MS-TrafficTypeDiagnostic: BYAPR10MB2951: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IAIvz6a/ZDv/imMs35dkX1G4cHbenXKUbi8jzBcaI6cDLniiWXrdSLFGYBCNwL5deWiyDsG+Wz8YKx9mXPIB98crbOxHAPzPjJfN5ZBeZM6oA3fYFZYVFAjzvnHT8ecNnAs+HEACFMCSZkB98gn0thCaHf5alVJ/YWEnndHYzVP8+E4P7b2zGHXlTeQZ8XcQSsIQ9qlqpMXtjN6fcc4DtZrRnyFwxmUeRZFjDF+EbiTUyF3yTIkygl52wGZA3YqOJPcFDCca0LbK3TJFDSBREFz+7YiEzESGz8ekQn/y9I1rgsnRbd/m8pygRm1Z40/yVustDcE5tE6vAH1lbRIOXOax+L6T375QmK3rkXl2y1YF6cM4447YQf0vPv31EX0WkSb7rDb0CKNh2RK/zfKs234plptLuwRZdyeJmniO0fgBgl/P49MnwIUU4z2IVNNvyzm0pmVUv4DxD82/6rqpKZIkSYXcYk0ti6kLMdWjQqs237QRZnOVnRhPw3m08N+f65dZ6wGDiQEgevslqD4jlTtnqWgje8HULCgpjS0Uod3lZIj8xEgrI7vqzWMI7Mt1a1GiR42h2MH92j/LQXTqmxL8B+4lFKDrIEreCemvnJH5Mq0LMQFADtmwlfYlOzs7xHS9kFalglHDALSmIinuSwGhakkAjY4laNzpqoclzlI2fITqQroxOM7hir6tjVFpJFfuS01XubhshO6bZ7eSmvwDSfCO2EE8GNe0u2SUwZFNHSQzEaRwlIKU957M9inU+M+NcSoy4bp1mh4/3zYs01Fzyy6Rl/G8ZLntm13xq1ZIF7K/hoN4S0gYouiOTDoI2Ykk/OACwlt76lpLpHGbMo4KJeny2XH+L2TNOJiUgMw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(346002)(39860400002)(366004)(396003)(52116002)(2906002)(31696002)(54906003)(956004)(44832011)(186003)(36756003)(478600001)(31686004)(2616005)(66946007)(53546011)(5660300002)(966005)(66556008)(66476007)(4326008)(6486002)(16576012)(6916009)(26005)(8676002)(316002)(38100700002)(38350700002)(8936002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aytnTFVVOTNhTDE4Y2FyZEh3bjArVTQ2ZllpUi8zeGFXYVMyZklGVjNYUnMv?= =?utf-8?B?cGRWdTZ5RVd5TEtCelVjczhvSmRYMElyQi9LWCt5T0F3STV2ODBtREgwMWRU?= =?utf-8?B?aU1xTmdicUFJSmpuWm9oNmhNWUxtK09QVkdQTVFGT1FUaEJKTDFBWTlxSkQv?= =?utf-8?B?VDVjZ1JlRzB1bDZMZDhIZThCS0ZEUlo1REdDemw1ejl1N3RrYXRkRFp4RWZw?= =?utf-8?B?SEdncXNEQ2huSVlGT04vemU0V1c3eE5KZktTOEpxSE5LOVVJM0cvWmh2Slk0?= =?utf-8?B?eWc5WlFMMVN2eEIyYzZFL3FlS2FJYWhJRUlzdHdHVWVsYVZUNVVFTGx6NUJ6?= =?utf-8?B?aWR4NVlHbjJ2Y3QyRlIyazBMSWpVTVIvSTFRV2Z3NnhCdDR1UHo1bDdlSVcy?= =?utf-8?B?bytaOXlwUjkzZ3AxWC8yNHZEUkptancxT2R5Ymx5cGluYTJ4VjJnbGY3OENE?= =?utf-8?B?VVJOMzZRUHRJb3QyRkN3aitrQ1NURGZNSlk3eVZRV3lQSnRzZk1XSVY3QVcx?= =?utf-8?B?R3J2U21VblFyQ25iZTBpbFh3OVpTOHlnVGlvNk5vZ1loOW0yVW1jd1NFVHFz?= =?utf-8?B?dHJPOW1WajZFcTdEcExoc0VNTUFIVm9FNlM0R2l6Uk5lUWZUS2dkY0FkUjF6?= =?utf-8?B?T2JzSFNZRzZVOXY2b2pxY09TOHUxYXVEV290UWh4M3NQeU9jdzN3SjRiZXI0?= =?utf-8?B?TWxuaURDK0NQSVVORitJdmlDQ0lzczBjWSthLzFIZDI2M3h1ekQ5SWI2N2dz?= =?utf-8?B?Sk9rMVlzQ0NXa2FONE1Bb3JybVZ0RG5zT1B3SXZoYTkrSzY4RWFaTHJyNFlF?= =?utf-8?B?MlRVbnhZTDIwZEQvTlc3cHk5U2h6aWRER3BoQ0tUZ0JsaGhhVEMvSTVpSTFi?= =?utf-8?B?Q1JTMmVqZ1lSeGlrVlAwSTc5d2lKWElNYzhqUjE4NURvOTJxSFNBaVlvS0xG?= =?utf-8?B?c3JjSHFBVWFsa3RKcWZuczNtZmJzWXk2NXc2TmN0cXVpWTlhVWtWZUovOUM1?= =?utf-8?B?Y1YwS0J1bmtsWHZOdHNrZEJxVGhNM0JnbmVodEhlbXR4TFkwWTE2dFVCalBS?= =?utf-8?B?c0E3TVYvZytqQ2tEQVI5S0FHMjJoMlpyNFMwd25sOTFxdThGamYvMFRieGtC?= =?utf-8?B?RkhOTzNUNUxCNW9jeVhYRXdHTWVtVDFXWUZoZ2YwWklhNTQxQUh4cDJpWUYy?= =?utf-8?B?NXhlM2syTmZMbXFNQjJNUGY4KzZBMFl0YTdKVm5Vcmt1UHV6ZnpQcURvQ0RU?= =?utf-8?B?V2x0U2V6bkVJb0w5V2ZTYWxXRHQzS0FqaFlDQjNXMnREVDM2Z0hSMHZReWtr?= =?utf-8?B?QXovV215RGk4eXVOVEdXbmJwajUzMm9HdUhkalVJNEwvdWc2T3pmd3lWUEh0?= =?utf-8?B?VFJFOVQxcDR6am5PZ1VLeVl6eWg1RzhuY2JuL21OVk5PdVFNMXhOQzhMZ3BK?= =?utf-8?B?MUw1Z2UzSE80clZhZHpZcHIvMlk5SVYrY1VTZWZDWVpMb3B3SEpGS3lRbTlo?= =?utf-8?B?dEVzdzNDOHZFRlhNL0FlT2VYbXlWYVd0cjZKRmRYN0tpVllxWS9PMUdLMHU1?= =?utf-8?B?cXdzd1ZRZVpCcjlHMTE4RU90SlY0MFdNeGY0eENEWFRqQStaelo3Qk9qSTVI?= =?utf-8?B?eUVJMEY4RCtrQVRLWWNQRnBrZkpjSjJITE51RVNKYnJ2K01lY2F5bHJLa0Ny?= =?utf-8?B?NlhUVGVLNVQwSXl2N3pwdlgwSlluTzdNcm1va1VUd0dPK2ZSNXFmNkZNTk16?= =?utf-8?Q?bvYWgQuW46cn2vqh8eKjo1AG4+QtGQAqxgMCaLn?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 953995d3-591e-49df-0dab-08d94c6fbca8 X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2021 17:48:24.2549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IJrbsNXnmYwmfuOP6kydIZ0fEbSTzzEXLmYtN2Vpa2eMhf+J05QCflQ5M1FxdkNcgZsHixLH3rBiXXEKPsBB6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2951 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10052 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107210104 X-Proofpoint-GUID: XSncAhv8BkvGpHbsmLN0VwBW5XHaG9Q7 X-Proofpoint-ORIG-GUID: XSncAhv8BkvGpHbsmLN0VwBW5XHaG9Q7 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=eosC5Z3N; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=Q+C1gNGc; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=uLjOdegL; spf=none (imf16.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspamd-Server: rspam05 X-Stat-Signature: q4ne1j5moipj7m77zrw4n3eingrtu5yn X-Rspamd-Queue-Id: 0BC7FF004262 X-HE-Tag: 1626889726-865104 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/21/21 4:57 AM, Matthew Wilcox wrote: > On Tue, Jul 20, 2021 at 09:38:48PM -0700, Mike Kravetz wrote: >> Add David, Al >> >> On 7/20/21 3:07 PM, Andrew Morton wrote: >>>> https://bugzilla.kernel.org/show_bug.cgi?id=213785 >> >> I took a quick look and believe a change in behavior was caused by >> commit 32021982a324 "Convert the hugetlbfs to use the fs_context >> during mount". >> >> Prior to the commit, code processing the mode option used >> match_octal() to convert the command line string to a numeric value. >> Since match_octal expects a string representing an octal value, it does >> not require a leading '0'. As a result, prior to this commit the >> argument 'mode=1700' would result in a mode value of 01700. After the >> commit one must precede octal values with 0. So, mode=1700 would result >> in a mode value of 03244 (& 01777U) = 1244. >> >> If my analysis is correct, I am not sure how to proceed. IMO, the >> current behavior is 'more correct'. However, until v5.1 a preceeding 0 >> was not required when specifying mode for hugetlbfs. So, this was >> certainly a change in behavior. Suggestions? > > Probably should follow what shmem does: > > mm/shmem.c: fsparam_u32oct("mode", Opt_mode), > > (also several other filesystems) > Thanks Matthew! That looks to be exactly what is needed. -- Mike Kravetz