From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Tue, 29 Jan 2019 16:03:00 +0000 Subject: Re: [PATCH 3/7] sh_eth: offload RX checksum on R7S72100 Message-Id: <56c41482-bffe-a831-2126-24e711623235@cogentembedded.com> List-Id: References: <0476beba-ea1f-7675-aa08-573b74e84f4e@cogentembedded.com> <20190128122053.vb5ifhf34zbnuclp@verge.net.au> <916ed105-d499-4ca1-8418-4743b5a7a60d@cogentembedded.com> <20190129080004.blc3jrt5y2j7dauo@verge.net.au> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chris Brandt , Simon Horman Cc: "netdev@vger.kernel.org" , "David S. Miller" , "linux-renesas-soc@vger.kernel.org" , "linux-sh@vger.kernel.org" On 01/29/2019 06:02 PM, Chris Brandt wrote: >>> As you may have guessed the implication of my question is that >>> IMHO it would be best only to add this feature to SoCs where >>> it has been tested. >> >> You don't trust the manuals? :-) >> >> MBR, Sergei > > How were you testing this feature with the R8A77980? Like Simon, I used perf/netperf, you can see it in the patch #2's description. You have other ideas? > Chris MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB082C282D0 for ; Tue, 29 Jan 2019 16:03:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B39C2087E for ; Tue, 29 Jan 2019 16:03:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="U990pfNr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727848AbfA2QDF (ORCPT ); Tue, 29 Jan 2019 11:03:05 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:34347 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbfA2QDF (ORCPT ); Tue, 29 Jan 2019 11:03:05 -0500 Received: by mail-lf1-f66.google.com with SMTP id p6so15067320lfc.1 for ; Tue, 29 Jan 2019 08:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OCrDEoi5EV/DxP4f8L1fcapH9mjP4WbEcD6U/OaGpGc=; b=U990pfNreEpEboGvw4Z6J0SGPN6fRQUjrbHDKt2+Fp+1hIshLLk/n3b1i2DbBiVdu9 +zEXwTPlYS4jcfOhcQXs/UeRUhopO57B/5bJXo7D8U9J4Q8GyN1YCA1Yd88fWmw4FOc1 RH2OaLB16jfGXmW3oNJjWCLrgKLy7WE+CqTzOK+1GUYN0WLjRd2afMAlIexzzi+5Sqzu MHUUgbex8MDPKV2edCmToyQGEKws+kR9tQANdvrrmxjkEA0HtRcFh7p85E/1j+UthSHV exN86ZuNYhjIYDwtWFPtRQwDXu7DSMUfUlyWCthltcMPrzeW91zF5DHnPnGRuScmdFwB OnmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=OCrDEoi5EV/DxP4f8L1fcapH9mjP4WbEcD6U/OaGpGc=; b=Xk8G1Tsga2/S5Cq1CISetDYbE4rAIibvdCJEkJYFGHIALkW/YlPLbcxHZIXNikqwky BRAlECRcHN7ykBqSY/gz/c9LTY1CT5Dw72tT2K2HeIRyyoTU4Yz/BqCcSTUzmc6z2a7r HnjCGYZ/I3G51x9J+XXWnQi+dae4a1dqwayq6slPeknnchJrQOOegIRw78Ggan9Qzafw lZ/KQnLpUQ/QlQ/fNEJwSM/DEzIAkc0WLfewWrMqPzSTIeZtsBS+iU50RxsbkpBIf1/n 7URwMiEu6o73SDR2BcSVlO3Fq4Ckc0FTtJWfPAw9zn6Z3HuqQv2GY5ueh+go7eTqFfOL gLwA== X-Gm-Message-State: AJcUuke99h6ZGQSsdzmioUbRNsR8Cj+BavbiK02OMHnT+GjvfBzK2hm9 uKfCfFze4d9fsLOs2Giu2VafkQ== X-Google-Smtp-Source: ALg8bN4gNeR6BhMe07ICJIhgV7Eka/m47uiYlj1z6FWgwwmHCYaTbsYiBO+tzrr8x/zOt+UlICqegA== X-Received: by 2002:a19:7d42:: with SMTP id y63mr20906073lfc.47.1548777783086; Tue, 29 Jan 2019 08:03:03 -0800 (PST) Received: from wasted.cogentembedded.com ([31.173.84.149]) by smtp.gmail.com with ESMTPSA id g15sm3517492lfb.1.2019.01.29.08.03.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 08:03:01 -0800 (PST) Subject: Re: [PATCH 3/7] sh_eth: offload RX checksum on R7S72100 To: Chris Brandt , Simon Horman Cc: "netdev@vger.kernel.org" , "David S. Miller" , "linux-renesas-soc@vger.kernel.org" , "linux-sh@vger.kernel.org" References: <0476beba-ea1f-7675-aa08-573b74e84f4e@cogentembedded.com> <20190128122053.vb5ifhf34zbnuclp@verge.net.au> <916ed105-d499-4ca1-8418-4743b5a7a60d@cogentembedded.com> <20190129080004.blc3jrt5y2j7dauo@verge.net.au> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <56c41482-bffe-a831-2126-24e711623235@cogentembedded.com> Date: Tue, 29 Jan 2019 19:03:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/29/2019 06:02 PM, Chris Brandt wrote: >>> As you may have guessed the implication of my question is that >>> IMHO it would be best only to add this feature to SoCs where >>> it has been tested. >> >> You don't trust the manuals? :-) >> >> MBR, Sergei > > How were you testing this feature with the R8A77980? Like Simon, I used perf/netperf, you can see it in the patch #2's description. You have other ideas? > Chris MBR, Sergei