All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: Adrian Perez de Castro <aperez@igalia.com>, buildroot@buildroot.org
Cc: Pierre Ducroquet <pinaraf@pinaraf.info>
Subject: Re: [Buildroot] [PATCH 1/1] package/kf5/kf5-extra-cmake-modules: do not build documentation
Date: Thu, 3 Feb 2022 21:39:53 +0100	[thread overview]
Message-ID: <56d88177-6e09-dba3-6b27-2119cd55db52@mind.be> (raw)
In-Reply-To: <20220113233758.110264-1-aperez@igalia.com>



On 14/01/2022 00:37, Adrian Perez de Castro wrote:
> Pass needed CMake options to disable generating documentations. The
> documentation is built using python-sphinx, which is not packaged in
> Buildroot.
> 
> Prior to this change, if the build host would have a Python installation
> with the sphinx module installed the automatic detection tried to build
> documentation, which would fail in cases where the sphinxcontrib-qthelp
> package is missing from the host Python installation. The error message
> in this case was:
> 
>    Extension error:
>    Could not import extension ecm (exception: cannot import name
>      'htmlescape' from 'sphinx.util.pycompat'
>      (/usr/lib/python3.10/site-packages/sphinx/util/pycompat.py))
> 
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

  Applied to master, thanks.

  (AFAICS the v2 was in fact identical)

  Regards,
  Arnout

> ---
>   .../kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk   | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/package/kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk b/package/kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk
> index 3c4281b960..ba2748456e 100644
> --- a/package/kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk
> +++ b/package/kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk
> @@ -14,4 +14,9 @@ KF5_EXTRA_CMAKE_MODULES_DEPENDENCIES = host-pkgconf
>   KF5_EXTRA_CMAKE_MODULES_INSTALL_STAGING = YES
>   KF5_EXTRA_CMAKE_MODULES_INSTALL_TARGET = NO
>   
> +KF5_EXTRA_CMAKE_MODULES_CONF_OPTS += \
> +	-DBUILD_HTML_DOCS=OFF \
> +	-DBUILD_MAN_DOCS=OFF \
> +	-DBUILD_QTHELP_DOCS=OFF
> +
>   $(eval $(cmake-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-02-03 20:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 23:37 [Buildroot] [PATCH 1/1] package/kf5/kf5-extra-cmake-modules: do not build documentation Adrian Perez de Castro
2022-02-03 20:39 ` Arnout Vandecappelle [this message]
2022-02-16  8:29   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56d88177-6e09-dba3-6b27-2119cd55db52@mind.be \
    --to=arnout@mind.be \
    --cc=aperez@igalia.com \
    --cc=buildroot@buildroot.org \
    --cc=pinaraf@pinaraf.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.