From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751023AbdEaFpY (ORCPT <rfc822;w@1wt.eu>);
        Wed, 31 May 2017 01:45:24 -0400
Received: from mail-wr0-f179.google.com ([209.85.128.179]:33167 "EHLO
        mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750970AbdEaFpX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 31 May 2017 01:45:23 -0400
Subject: Re: linux-next: build failure after merge of the rtc tree
To: Stephen Rothwell <sfr@canb.auug.org.au>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        David Lowe <dave-lowe@ntlworld.com>
References: <20170531143349.561d5e77@canb.auug.org.au>
From: Heiner Kallweit <hkallweit1@gmail.com>
Message-ID: <56de728c-b7eb-8093-e39e-41cf9b743d16@gmail.com>
Date: Wed, 31 May 2017 07:45:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <20170531143349.561d5e77@canb.auug.org.au>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 31.05.2017 um 06:33 schrieb Stephen Rothwell:
> Hi Alexandre,
> 
> After merging the rtc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/rtc/rtc-ds1307.c: In function 'ds1307_probe':
> drivers/rtc/rtc-ds1307.c:1410:29: error: 'struct ds1307' has no member named 'client'
>    if (chip->alarm && (ds1307->client->irq > 0 ||
>                              ^
ds1307->client->irq would have to be replaced with ds1307->irq.
Same what the regmap patch does e.g. at line 1477.
The regmap patch removes member client from struct ds1307.

Rgds, Heiner

> 
> Caused by commit
> 
>   345b89453dda ("rtc: rtc-ds1307: enable support for mcp794xx as a wakeup source without IRQ")
> 
> interacting with commit
> 
>   11e5890b5342 ("rtc: ds1307: convert driver to regmap")
> 
> I have used the rtc tree from next-20170530 for today.
>