From: Phil Reid <preid@electromag.com.au>
To: Robert Middleton <robert.middleton@rm5248.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH] gpio:mcp23s08 Fixed missing interrupts
Date: Wed, 22 Feb 2017 08:56:08 +0800 [thread overview]
Message-ID: <56e0ad5a-f35a-33d3-182a-d16193f898d3@electromag.com.au> (raw)
In-Reply-To: <CAKpcJVaJ4KrxHSFvLOUQeS-BHAHqKAw_qhE-cdqmnENjphAk-Q@mail.gmail.com>
On 22/02/2017 01:34, Robert Middleton wrote:
> I have re-worked the interrupt handling, and I am reasonably sure at this
> point that it's working correctly. It properly detects the
> rising/falling edges
> at this point, and doesn't trigger all the time.
>
> The logic has become rather complicated at this point though, so it
> may have to be broken up into a separate function. I also found a few
> quirks with the chip on detecting the pin change in INTCAP, so I wasn't
> able to implement exactly as Phil had suggested.
>
> Phil, would you like to take a look at what I've done before I send a patch
> out, or would you prefer that I simply send out the patch as-is and discuss
> in a new thread?
>
Just send a v2 to the list.
--
Regards
Phil Reid
prev parent reply other threads:[~2017-02-22 0:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 20:02 MCP23S08 Interrupts Fix robert.middleton
2017-02-11 20:02 ` [PATCH] gpio:mcp23s08 Fixed missing interrupts robert.middleton
2017-02-13 5:15 ` Phil Reid
2017-02-13 16:25 ` Robert Middleton
2017-02-14 1:12 ` Phil Reid
2017-02-15 2:37 ` Robert Middleton
2017-02-15 6:37 ` Phil Reid
2017-02-21 17:34 ` Robert Middleton
2017-02-22 0:56 ` Phil Reid [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56e0ad5a-f35a-33d3-182a-d16193f898d3@electromag.com.au \
--to=preid@electromag.com.au \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robert.middleton@rm5248.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.