Re: [PATCH v5 2/4] perf record: bind the AIO user space buffers to nodes

[Alexey Budankov <alexey.budankov@linux.intel.com>]

On 05.02.2019 18:15, Arnaldo Carvalho de Melo wrote:
> Em Mon, Feb 04, 2019 at 10:47:03PM +0300, Alexey Budankov escreveu:
>>
>> On 04.02.2019 22:29, Arnaldo Carvalho de Melo wrote:
>>> Em Tue, Jan 22, 2019 at 08:48:54PM +0300, Alexey Budankov escreveu:
>>>>
>>>> Allocate and bind AIO user space buffers to the memory nodes
>>>> that mmap kernel buffers are bound to.
>>>
>>> [root@quaco amazonlinux]# perf test -v python
>>> 18: 'import perf' in python                               :
>>> --- start ---
>>> test child forked, pid 526
>>> Traceback (most recent call last):
>>>   File "<stdin>", line 1, in <module>
>>> ImportError: /tmp/build/perf/python/perf.so: undefined symbol: mbind
>>
>> Argh. Missed that.
>>
>>> test child finished with -1
>>> ---- end ----
>>> 'import perf' in python: FAILED!
>>> [root@quaco amazonlinux]#
>>>
>>>
>>> Please always use 'perf test' before pushing upstream, I'll try to fix
>>> this one, either by linking libnuma into the python binding or by moving
>>> the routines using it to a separate file.
>>
>> Will do. Thanks for followup.
> 
> this seems to do the trick:
> 
> diff --git a/tools/perf/util/setup.py b/tools/perf/util/setup.py
> index d3ffc18424b5..88ffa995b44b 100644
> --- a/tools/perf/util/setup.py
> +++ b/tools/perf/util/setup.py
> @@ -56,6 +56,7 @@ ext_sources = list(map(lambda x: '%s/%s' % (src_perf, x) , ext_sources))
>  perf = Extension('perf',
>  		  sources = ext_sources,
>  		  include_dirs = ['util/include'],
> +		  libraries = ['numa'],
>  		  extra_compile_args = cflags,
>  		  extra_objects = [libtraceevent, libapikfs],
>                   )
> 
> ------------------------------------------------
> 
> [root@quaco ~]# ldd /tmp/build/perf/python/perf.cpython-37m-x86_64-linux-gnu.so
> 	linux-vdso.so.1 (0x00007ffdf53c3000)
> 	libunwind-x86_64.so.8 => /lib64/libunwind-x86_64.so.8 (0x00007fa538b82000)
> 	libunwind.so.8 => /lib64/libunwind.so.8 (0x00007fa538b66000)
> 	liblzma.so.5 => /lib64/liblzma.so.5 (0x00007fa538b3d000)
> 	libnuma.so.1 => /lib64/libnuma.so.1 (0x00007fa538b2f000)
> 	libpython3.7m.so.1.0 => /lib64/libpython3.7m.so.1.0 (0x00007fa5387b7000)
> 	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fa538795000)
> 	libc.so.6 => /lib64/libc.so.6 (0x00007fa5385cd000)
> 	libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007fa5385b2000)
> 	/lib64/ld-linux-x86-64.so.2 (0x00007fa538c1a000)
> 	libdl.so.2 => /lib64/libdl.so.2 (0x00007fa5385ac000)
> 	libutil.so.1 => /lib64/libutil.so.1 (0x00007fa5385a7000)
> 	libm.so.6 => /lib64/libm.so.6 (0x00007fa538423000)
> [root@quaco ~]#
> 
> [root@quaco ~]# perf test python
> 18: 'import perf' in python                               : Ok
> [root@quaco ~]#
> 
> 
> So I'm ammending that hunk to the patch that introduces that mbind
> usage.

Again, thanks a lot, Arnaldo!

Alexey

> 
> Thanks,
> 
> - Arnaldo
>