From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CDF0C433FE for ; Wed, 2 Nov 2022 22:49:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ECED2850A5; Wed, 2 Nov 2022 23:49:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="Bbru93dI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DB4448503A; Wed, 2 Nov 2022 23:49:19 +0100 (CET) Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E04684ED3 for ; Wed, 2 Nov 2022 23:49:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20221102224909epoutp04a725d26f934423ef427e96658a352cdf~j5iimUlbH1561715617epoutp04c for ; Wed, 2 Nov 2022 22:49:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20221102224909epoutp04a725d26f934423ef427e96658a352cdf~j5iimUlbH1561715617epoutp04c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1667429349; bh=iL7meLP+jzY+Vfaqw4N5xoP1SxK3iSKtXDNCUiDX83E=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=Bbru93dIaIHY3uy7Ygrd0nezA52z1EWnVCIIBXTjRsLaqFOBg7Q8hEW5GSAOpPO+0 X0NbCL6haJg1bPKSuonkYiRoCGng59/3j55LijNsjauB56pTCQrxO/oI6QVnRv94NI D1gwO4Ci9Kz0iVFTEaMKPn3GKCCpDc81R33Y0C5M= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20221102224909epcas1p288b9153ed906d625497944fa9f538727~j5iibPKny1866018660epcas1p2_; Wed, 2 Nov 2022 22:49:09 +0000 (GMT) Received: from epsmges1p1.samsung.com (unknown [182.195.38.234]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4N2hs03fz0z4x9Pr; Wed, 2 Nov 2022 22:49:08 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p1.samsung.com (Symantec Messaging Gateway) with SMTP id 3A.26.07146.4E3F2636; Thu, 3 Nov 2022 07:49:08 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p1.samsung.com (KnoxPortal) with ESMTPA id 20221102224908epcas1p19cbf54c2b37615c1ce10516ec970d692~j5ihjpstq1529315293epcas1p1G; Wed, 2 Nov 2022 22:49:08 +0000 (GMT) Received: from epsmgms1p2.samsung.com (unknown [182.195.42.42]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20221102224908epsmtrp1c201163711727202f3cc7af601ed777e~j5ihjFNop0140301403epsmtrp1j; Wed, 2 Nov 2022 22:49:08 +0000 (GMT) X-AuditID: b6c32a35-47bfe70000021bea-49-6362f3e4f3b5 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 9B.FD.18644.4E3F2636; Thu, 3 Nov 2022 07:49:08 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20221102224908epsmtip2c23f620727ad710b05a19fe0571faee7~j5ihZ2HS_1273412734epsmtip2d; Wed, 2 Nov 2022 22:49:07 +0000 (GMT) Message-ID: <56f8eccb-6707-e3f7-b5f9-e1c8f5765502@samsung.com> Date: Thu, 3 Nov 2022 07:49:07 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] cmd: mmc: Print life time info To: Robert Krikke , u-boot@lists.denx.de Cc: Robert Krikke , Harm Berntsen Content-Language: en-US From: Jaehoon Chung In-Reply-To: <20221102141710.63840-1-robert.krikke@nedap.com> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPKsWRmVeSWpSXmKPExsWy7bCmru6Tz0nJBuduSVosWu5u0dG9ksli xp+FrBZv93ayO7B47Jx1l93j7J0djB6dK6cyBzBHZdtkpCampBYppOYl56dk5qXbKnkHxzvH m5oZGOoaWlqYKynkJeam2iq5+AToumXmAG1TUihLzCkFCgUkFhcr6dvZFOWXlqQqZOQXl9gq pRak5BSYFugVJ+YWl+al6+WlllgZGhgYmQIVJmRnLHm9hrGgmb/i69HLjA2M/7i7GDk5JARM JDZ13mPqYuTiEBLYwSjxa851FgjnE6PEn0dT2CGcz4wSU2/vB3I4wFruzwiAiO9ilHixdiIb hPOeUeL83U5WkCJeATuJ2YsqQVawCKhIbJ/3iw3E5hUQlDg58wkLiC0qECVxadMbVhBbWMBY YuH9P0wgtoiAg8S2W9/AapgFwiSOf3jIDGGLS9x6Mh+shk1AR2L7t+NgNqeArcSWNw9YIWrk Jba/ncMMco+EwEt2iU0vpjBC/OkicbBnDguELSzx6vgWdghbSuJlfxs7REMzo8TSJQdZIZwe Rol/DdfZIKqMJfYvncwE8hmzgKbE+l36EGFFiZ2/5zJCbOaTePe1hxUSQrwSHW1CECUqEpde v2SC2XX3yX9WCNtDounmXtYJjIqzkMJlFpI/ZyH5ZxbC4gWMLKsYxVILinPTU4sNCwzhsZ2c n7uJEZwStUx3ME58+0HvECMTB+MhRgkOZiUR3vqz0clCvCmJlVWpRfnxRaU5qcWHGE2BsTOR WUo0OR+YlPNK4g1NLA1MzIyMTSwMzQyVxHkbZmglCwmkJ5akZqemFqQWwfQxcXBKNTB1e375 ypCpKaKQFjW1MtlwEpeqQLTLM91Z7J7ZyqJnT8yo47lupsY031nGM3pTHptwltlGqblFV5+v +ytctjmL442mdR/LrUX3N5uV8czfuJbDTfLwOzV75+NzEp38HJcy8XC0yXyM4m6VTDO06z/+ ySJTUvD1W/ldq/sPdiw4LVa+v5JBvXbSH0ep/6KOlwpS5La/Omh2Rdxegd0+d5rJub1zpfXm K0pP28Xsp7BtttSV8HXaCS3TFi08d8m81d3x7a9zDatvhE1p3H+c45LykofrCmd63r24quV7 k3X3phtpEwPbrkRxFGQFnNl2+JQze2zz9PO9i6ewdrC1XLG9PeX63e0VSyZOORLCN0+JpTgj 0VCLuag4EQALWJSrEgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsWy7bCSvO6Tz0nJBlf7OS0WLXe36OheyWQx 489CVou3ezvZHVg8ds66y+5x9s4ORo/OlVOZA5ijuGxSUnMyy1KL9O0SuDKWvF7DWNDMX/H1 6GXGBsZ/3F2MHBwSAiYS92cEdDFycQgJ7GCU6D/fx9TFyAkUl5L4/HQqG0SNsMThw8UQNW8Z Jb593c4CEucVsJOYvagSpJxFQEVi+7xfbCA2r4CgxMmZT1hAbFGBKImlj3vAbGEBY4mF9/+A jRcRcJDYdusbWJxZIEziwMtdjCAjhQRsJM4ejIIIi0vcejIfrJxNQEdi+7fjYDangK3EljcP WEHKmQXUJdbPE4Iol5fY/nYO8wRGoVlIjpiFZNIshI5ZSDoWMLKsYpRMLSjOTc8tNiwwykst 1ytOzC0uzUvXS87P3cQIDnwtrR2Me1Z90DvEyMTBeIhRgoNZSYS3/mx0shBvSmJlVWpRfnxR aU5q8SFGaQ4WJXHeC10n44UE0hNLUrNTUwtSi2CyTBycUg1MijoPHjaF/DvOd+TQHLVQNp4N Nx7GlO60K2k+ME30x5YKlXuKH/QYQxiubghaJn7VbnpB+eOU3/qnKucqv3+Xv0D6l0Of29Eo 76KH4ldjT7752G+ebP3ksMll1q+nZS4EfrqwKPdmeIe+/p5NakpKh4N+hhrU1HNYSKiuCD7b XyOxaZ5ytIhB6qIbK1jO3rvBKf12gm9+/6Gv7kLinXe4p3r+NP4rrjH34f44uRZOJpNX02UM /j+osM54EGZd5LPJ2ODP1MLV7ML3JytIv2nm+Xyh8sar6HWbfjA38nAa1qqrFJrqfuk62Ber dnpKhKT3XHXRznnK21iPbniv4nRULcBZ85FNwfzNEdOOG/5RYinOSDTUYi4qTgQAFfFAI+sC AAA= X-CMS-MailID: 20221102224908epcas1p19cbf54c2b37615c1ce10516ec970d692 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20221102224908epcas1p19cbf54c2b37615c1ce10516ec970d692 References: <20221102141710.63840-1-robert.krikke@nedap.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, On 11/2/22 23:17, Robert Krikke wrote: > Added life time info: > -EXT_CSD_PRE_EOL_INFO > -EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A > -EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_B I'm not sure that it really needs to display this information as mmc info. I hope that mmc info command should be displayed essential information. > > Signed-off-by: Robert Krikke > Reviewed-by: Harm Berntsen > --- > cmd/mmc.c | 6 ++++++ > include/mmc.h | 3 +++ > 2 files changed, 9 insertions(+) > > diff --git a/cmd/mmc.c b/cmd/mmc.c > index 7bd4cd9e016..b940e320295 100644 > --- a/cmd/mmc.c > +++ b/cmd/mmc.c > @@ -127,6 +127,12 @@ static void print_mmcinfo(struct mmc *mmc) > } > wp >>= 2; > } > + > + if (mmc->version >= MMC_VERSION_5_0) { Move to outside of MMC_VERSION_4_41 if statement. > + printf("Pre EOL Information: 0x%02X\n", ext_csd[EXT_CSD_PRE_EOL_INFO]); > + printf("Life Time Estimation A: 0x%02X\n", ext_csd[EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]); > + printf("Life Time Estimation B: 0x%02X\n", ext_csd[EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_B]); It's not a readable value. If didn't check the eMMC5.0 spec, it's difficult to know what means 0x01, 0x02..etc.. Best Regards, Jaehoon Chung > + } > } > } > > diff --git a/include/mmc.h b/include/mmc.h > index f519d869725..d0c3e684595 100644 > --- a/include/mmc.h > +++ b/include/mmc.h > @@ -242,6 +242,9 @@ static inline bool mmc_is_tuning_cmd(uint cmdidx) > #define EXT_CSD_HC_ERASE_GRP_SIZE 224 /* RO */ > #define EXT_CSD_BOOT_MULT 226 /* RO */ > #define EXT_CSD_GENERIC_CMD6_TIME 248 /* RO */ > +#define EXT_CSD_PRE_EOL_INFO 267 /* RO */ > +#define EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A 268 /* RO */ > +#define EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_B 269 /* RO */ > #define EXT_CSD_BKOPS_SUPPORT 502 /* RO */ > > /*