All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Russkikh <irusskikh@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>,
	Bhaskar Upadhaya <bupadhaya@marvell.com>
Cc: <netdev@vger.kernel.org>, Ariel Elior <aelior@marvell.com>
Subject: Re: [EXT] Re: [PATCH net-next 3/3] qede: set default per queue rx/tx usecs coalescing parameters
Date: Sun, 17 Jan 2021 17:37:23 +0100	[thread overview]
Message-ID: <56fe2942-415e-9341-b3cd-e926559d6e31@marvell.com> (raw)
In-Reply-To: <20210116182806.625c540e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>


>> Here we do the initialization of coalescing values on load.
>> Although the default device values are the same - explicit
>> config is better visible.
> 
> Can you also make the driver store the settings across ifdown / ifup
> and allow the settings to be checked while the interface is down, 
> while at it?

Good suggestion, we'll implement that.

Thanks,
   Igor

      reply	other threads:[~2021-01-17 16:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15  9:06 [PATCH net-next 0/3] qede: add netpoll and per-queue coalesce support Bhaskar Upadhaya
2021-01-15  9:06 ` [PATCH net-next 1/3] qede: add netpoll support for qede driver Bhaskar Upadhaya
2021-01-17  2:26   ` Jakub Kicinski
2021-01-17 16:35     ` [EXT] " Igor Russkikh
2021-01-18 19:10       ` Jakub Kicinski
2021-01-15  9:06 ` [PATCH net-next 2/3] qede: add per queue coalesce " Bhaskar Upadhaya
2021-01-15  9:06 ` [PATCH net-next 3/3] qede: set default per queue rx/tx usecs coalescing parameters Bhaskar Upadhaya
2021-01-17  2:28   ` Jakub Kicinski
2021-01-17 16:37     ` Igor Russkikh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56fe2942-415e-9341-b3cd-e926559d6e31@marvell.com \
    --to=irusskikh@marvell.com \
    --cc=aelior@marvell.com \
    --cc=bupadhaya@marvell.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.