All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles-Antoine Couret <charles-antoine.couret@nexvision.fr>
To: Jean-Michel Hautbois <jean-michel.hautbois@veo-labs.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Add GS1662 driver (a SPI video serializer)
Date: Mon, 4 Apr 2016 11:01:14 +0200	[thread overview]
Message-ID: <57022D5A.5080704@nexvision.fr> (raw)
In-Reply-To: <CAH-u=83J0kJzaV5Mqz7Zt76JgfVz6M_v_nhzPEeqwcRCRKm8VQ@mail.gmail.com>

Le 01/04/2016 21:11, Jean-Michel Hautbois a écrit :
> Hi Charles-Antoine,
Hi,

> FIrst of all, we, on the ML, do prefer reading patches as sent by git
> send-email tool.

Ok, I will configure that.

> Next, you should add a complete description to your commit. Just
> having an object and a signed-off-by line is not enough.
Oh, I'm sorry, I don't have any idea to explicit more details. I will
find something for that.

> You also have to use the scripts/checkpatch.pl script to verify that
> everything is ok with it.
I have executed this script before to send it. And it noticed nothing about that.

> Last thing, I can't see anything related to V4L2 in your patch. It is
> just used to initialize the chip and the spi bus, that's all.
> Adding a subdev is a start, and some operations if it can do something
> else than just serializing.

Maybe I'm in the wrong list for that in fact. I didn't know this list was about V4L2 and related topics.
This driver is only to configure the component to manage the video stream in electronic card, it is not to capture video stream via V4L.

I should improve my driver to be configurable by userspace. But maybe I should submit my future patch in another ML. 

Thanks for all.
Regards,
Charles-Antoine

  reply	other threads:[~2016-04-04  9:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 16:02 [PATCH] Add GS1662 driver (a SPI video serializer) Charles-Antoine Couret
2016-04-01 16:28 ` Charles-Antoine Couret
2016-04-01 19:11   ` Jean-Michel Hautbois
2016-04-04  9:01     ` Charles-Antoine Couret [this message]
2016-04-04 12:35       ` Jean-Michel Hautbois
2016-04-15  8:38         ` Hans Verkuil
2016-04-15  8:42           ` Charles-Antoine Couret
2016-04-01 16:30 ` Fwd: " Charles-Antoine Couret

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57022D5A.5080704@nexvision.fr \
    --to=charles-antoine.couret@nexvision.fr \
    --cc=jean-michel.hautbois@veo-labs.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.