From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id D5AD8E00C39; Mon, 4 Apr 2016 09:32:46 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.217.176 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com [209.85.217.176]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 538D3E00B8C for ; Mon, 4 Apr 2016 09:32:41 -0700 (PDT) Received: by mail-lb0-f176.google.com with SMTP id bc4so167659169lbc.2 for ; Mon, 04 Apr 2016 09:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=v+a+gCHWKse57ssMAfnF24aIbuzvPOSmpDixUq9KI0o=; b=LCeQHo7z81kDgd03S12+G6nZ29XTMDxS1eNRzMxObUpvzvqfLrCMo9pU/7sD29pwVz 1Rn7zTdXh0Z5qQLz5v1MZw2bpYcgAyBaTo3GfVfWmncqMafcyjsTxIJUC7NiZFQMhp5h c6hSPJ0GyroOGRiKT3iPWW8hRDX7EGUEHi/CS16o91S2GJy0qLveu+/LNmfCmJEi6OtB JEXoS5rnrZRdl1aYisxGhBknGobDleIIB9LO6NjNbgg7o/N+jnb5Qc1HW2I1tyXFIF7h 0E5coF1tCDdCu7dlpYNOAHLODACkbdhET+waSpoMkwF0iBqKGzYsY77jHCg6x58hr5FL zryQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=v+a+gCHWKse57ssMAfnF24aIbuzvPOSmpDixUq9KI0o=; b=io90vQJYWjMDcpcRBNaITG+N72yFKnwb7aufZONo1vU1IN0zQdOLcrm9gEVuXQXW8G flYhK35tRenZl08nnYwJSsnc0NAfTNm4kLpPMSqTDofaXrEJdhgNbcwzROJ9Hs4qAXwu 4p0yxYuaXbnmmdYnaJysw02D+u+9SSw/S0omH39ZyNNt3jGN8g472irDIhYpfWJiHfqY s+RZlns+6bFuH3pyi1xHDcLYy5/r3rS5doHcPM9DuJqXq807RCbk8c69iW4IQ2sqIXXp dflBvAXSXL8IMPjHy+aAIVhA0YlfFnFicIeyDc5NjdmkEp61Y5HY4mQA90D67R3kFstt CE6A== X-Gm-Message-State: AD7BkJJsKKt38WHpLG/w8FvIGLVCUj25961Vqo2WPtWuC/mC1Y9nxTVMhmyJAM/WxxDuiw6Q X-Received: by 10.28.133.14 with SMTP id h14mr13461517wmd.100.1459787559524; Mon, 04 Apr 2016 09:32:39 -0700 (PDT) Received: from [192.168.2.24] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id m13sm14750031wma.3.2016.04.04.09.32.38 for (version=TLSv1/SSLv3 cipher=OTHER); Mon, 04 Apr 2016 09:32:38 -0700 (PDT) To: toaster@yoctoproject.org References: From: Michael Wood Message-ID: <5702971E.6020708@intel.com> Date: Mon, 4 Apr 2016 17:32:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Subject: Re: Removing 7844358 from toaster-next ("create Build object earlier in bitbake processing") X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2016 16:32:46 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Yes, let's remove "toaster: create Build object earlier in bitbake processing" from toaster-next. If it's not going up to bitbake-devel in it's current form and It's causing a regression there isn't any point keeping it around in toaster-next. Michael On 04/04/16 09:24, Smith, Elliot wrote: > We currently have this in toaster-next, but after discussion with RP, > we've agreed that this is probably not the right way to do this. > > RP suggested a couple of alternatives, which I can look into this week > (see bug https://bugzilla.yoctoproject.org/show_bug.cgi?id=8440). > > For the moment, can I suggest that we remove this from toaster-next > and force push the branch? > > NOTE: I'm mentioning this because it will mess up everyone's Toaster > database, as the patch included a migration. You'll need to remove any > existing db and start again. It will also affect Ed's branch, as he > rebased on toaster-next with this patch in it. > > There is also a patch created by Michael which fixed an issue with my > patch, which I submitted to bitbake-devel last week. This failed to > apply because 7844358 wasn't accepted. > > So this patch should also be ignored for now: > http://lists.openembedded.org/pipermail/bitbake-devel/2016-April/007258.html > I have already removed it from toaster-next. > > Details of the commit I plan to remove are below for reference. > > Elliot > > > commit 78443585bc92eca7140267126d53f749be3cdd6a > Author: Elliot Smith > > Date: Thu Jan 28 16:21:01 2016 +0000 > > toaster: create Build object earlier in bitbake processing > If a build fails because of a bitbake error occurring before the > BuildStarted event fires, we do not generate a Build object > for command-line builds. This means that failed command-line builds > don't appear in Toaster at all. > To resolve, split build creation into two steps: > 1. Just before buildTargets() is invoked on the XMLRPC server: create > the base Build object. Note that as soon as a Toaster-triggered > build starts, targets are added to it; but this event is the earliest > point when task and targets are available for command-line builds. > (This requires a new TargetsAcquired event to be fired by the XMLRPC > server when the buildTargets() command is called.) > 2. BuildStarted event: add any layer information to either type of > build > (command-line or Toaster-triggered). > Note that the build_name property cannot be set until BuildStarted, > as it is not available until then, which could cause problems > for creating Build objects earlier; however, this property is > redundant, as it's never used anywhere in Toaster, so it has been > removed (along with any functions which refer to it). > [YOCTO #8440] > Signed-off-by: Elliot Smith > > Signed-off-by: Michael Wood > > > > -- > Elliot Smith > Software Engineer > Intel Open Source Technology Centre > >