From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anFGQ-0007nZ-H8 for qemu-devel@nongnu.org; Mon, 04 Apr 2016 20:54:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anFGM-0001db-H0 for qemu-devel@nongnu.org; Mon, 04 Apr 2016 20:54:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anFGM-0001dX-BP for qemu-devel@nongnu.org; Mon, 04 Apr 2016 20:54:34 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9BCE486B2 for ; Tue, 5 Apr 2016 00:54:33 +0000 (UTC) Received: from [10.72.7.181] (vpn1-7-181.pek2.redhat.com [10.72.7.181]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u350sV1K026252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 4 Apr 2016 20:54:33 -0400 References: <1459479208-10452-1-git-send-email-jasowang@redhat.com> From: Jason Wang Message-ID: <57030CC6.10106@redhat.com> Date: Tue, 5 Apr 2016 08:54:30 +0800 MIME-Version: 1.0 In-Reply-To: <1459479208-10452-1-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rtl8139: using CP_TX_OWN for ownership transferring during tx List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 04/01/2016 10:53 AM, Jason Wang wrote: > Through CP_TX_OWN and CP_RX_OWN points to the same bit, we'd better use > CP_TX_OWN for tx descriptor handling. > > Signed-off-by: Jason Wang > --- > hw/net/rtl8139.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c > index fee97bf..1e5ec14 100644 > --- a/hw/net/rtl8139.c > +++ b/hw/net/rtl8139.c > @@ -2046,7 +2046,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) > } > > /* transfer ownership to target */ > - txdw0 &= ~CP_RX_OWN; > + txdw0 &= ~CP_TX_OWN; > > /* reset error indicator bits */ > txdw0 &= ~CP_TX_STATUS_UNF; Applied to -net. Thanks