All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 05/11 v2] package/ktap: use kernel-module helper
Date: Wed, 10 Jun 2015 21:22:09 +0200	[thread overview]
Message-ID: <57032a1bba2511167d80bc55424ad32f5f061869.1433964001.git.yann.morin.1998@free.fr> (raw)
In-Reply-To: <cover.1433964001.git.yann.morin.1998@free.fr>

Passing the KERNEL_SRC variable is no longer needed, since it was only
used to run commands like:
    $(MAKE) -C $(KERNEL_SRC) M=$(PWD) modules

which is basically what the new kernel-module infra is now doing.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

---
Changes v1 -> v2;
  - explain why we get rid of a variable  (Thomas)
---
 package/ktap/ktap.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/package/ktap/ktap.mk b/package/ktap/ktap.mk
index 4a0e51c..966b51c 100644
--- a/package/ktap/ktap.mk
+++ b/package/ktap/ktap.mk
@@ -9,8 +9,6 @@ KTAP_SITE = $(call github,ktap,ktap,$(KTAP_VERSION))
 KTAP_LICENSE = GPLv2
 KTAP_LICENSE_FILES = LICENSE-GPL
 
-KTAP_DEPENDENCIES = linux
-
 ifeq ($(BR2_PACKAGE_ELFUTILS),y)
 KTAP_DEPENDENCIES += elfutils
 else
@@ -19,12 +17,13 @@ endif
 
 define KTAP_BUILD_CMDS
 	$(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) $(KTAP_FLAGS) ktap
-	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) KERNEL_SRC=$(LINUX_DIR) KVERSION=$(LINUX_VERSION_PROBED) mod
 endef
 
 define KTAP_INSTALL_TARGET_CMDS
 	$(INSTALL) -D -m755 $(@D)/ktap  $(TARGET_DIR)/usr/bin/ktap
-	$(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) KERNEL_SRC=$(LINUX_DIR) KVERSION=$(LINUX_VERSION_PROBED) modules_install
 endef
 
+KTAP_MODULE_MAKE_OPTS = KVERSION=$(LINUX_VERSION_PROBED)
+
+$(eval $(kernel-module))
 $(eval $(generic-package))
-- 
1.9.1

  parent reply	other threads:[~2015-06-10 19:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 19:22 [Buildroot] [PATCH 0/11 v2] pkg-kernel-module: new infra to ease building kernel modules (branch yem/kernel-modules) Yann E. MORIN
2015-06-10 19:22 ` [Buildroot] [PATCH 01/11 v2] package-infra: add helper to build kernel modules Yann E. MORIN
2015-06-10 21:08   ` rdkehn at yahoo.com
2015-06-11 18:05     ` Yann E. MORIN
2015-06-11 22:44   ` Arnout Vandecappelle
2015-06-12 17:46     ` Yann E. MORIN
2015-06-12 22:52       ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 02/11 v2] docs/manual: add kernel-module Yann E. MORIN
2015-06-11  7:32   ` Jeremy Rosen
2015-06-11 18:06     ` Yann E. MORIN
2015-06-12  6:54       ` Jeremy Rosen
2015-06-10 19:22 ` [Buildroot] [PATCH 03/11 v2] package/lttng-modules: use kernel-module helper Yann E. MORIN
2015-06-11 22:44   ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 04/11 v2] package/igh-ethercat: " Yann E. MORIN
2015-06-11 22:51   ` Arnout Vandecappelle
2015-06-10 19:22 ` Yann E. MORIN [this message]
2015-06-11 22:53   ` [Buildroot] [PATCH 05/11 v2] package/ktap: " Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 06/11 v2] package/cryptodev-linux: use the " Yann E. MORIN
2015-06-11 23:02   ` Arnout Vandecappelle
2015-06-12 20:48     ` Yann E. MORIN
2015-06-10 19:22 ` [Buildroot] [PATCH 07/11 v2] package/ocf-linux: use " Yann E. MORIN
2015-06-10 19:22 ` [Buildroot] [PATCH 08/11 v2] package/on2-8170-modules: " Yann E. MORIN
2015-06-11 23:04   ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 09/11 v2] package/owl-linux: " Yann E. MORIN
2015-06-11 23:13   ` Arnout Vandecappelle
2015-06-12 17:55     ` Yann E. MORIN
2015-06-12 23:19       ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 10/11 v2] package/simicsfs: " Yann E. MORIN
2015-06-11 23:13   ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 11/11 v2] package/sysdig: " Yann E. MORIN
2015-06-11 18:03 ` [Buildroot] [PATCH 0/11 v2] pkg-kernel-module: new infra to ease building kernel modules (branch yem/kernel-modules) Yann E. MORIN
2015-06-11 23:18   ` Arnout Vandecappelle
2015-06-12 17:47     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57032a1bba2511167d80bc55424ad32f5f061869.1433964001.git.yann.morin.1998@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.