From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757900AbcDEKx6 (ORCPT ); Tue, 5 Apr 2016 06:53:58 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:42258 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755228AbcDEKx4 (ORCPT ); Tue, 5 Apr 2016 06:53:56 -0400 Subject: Re: [PATCH 2/3] phy: rcar-gen3-usb2: Add vbus-supply to handle VBUS on/off To: Yoshihiro Shimoda , , , , , References: <1456999746-2800-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1456999746-2800-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> CC: , , From: Kishon Vijay Abraham I Message-ID: <5703992F.7090601@ti.com> Date: Tue, 5 Apr 2016 16:23:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1456999746-2800-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thursday 03 March 2016 03:39 PM, Yoshihiro Shimoda wrote: > To handle the VBUS on/off by a regulator driver, this patch adds > regulator APIs calling in the driver and description about vbus-supply > in the rcar-gen3-phy-usb2.txt. > > Signed-off-by: Yoshihiro Shimoda > Acked-by: Rob Herring > --- > .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++ > drivers/phy/phy-rcar-gen3-usb2.c | 28 ++++++++++++++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > index 86826ca..7243b3b 100644 > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > @@ -21,6 +21,8 @@ To use a USB channel where USB 2.0 Host and HSUSB (USB 2.0 Peripheral) are > combined, the device tree node should set interrupt properties to use the > channel as USB OTG: > - interrupts: interrupt specifier for the PHY. > +- vbus-supply: Phandle to a regulator that provides power to the VBUS. This > + regulator will be managed during the PHY power on/off sequence. Why not use phy-supply from the generic PHY binding? It can then be managed by the phy core during power_on/power_off. Thanks Kishon > > Example (R-Car H3): > > diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c > index 3c647cd..7b14244 100644 > --- a/drivers/phy/phy-rcar-gen3-usb2.c > +++ b/drivers/phy/phy-rcar-gen3-usb2.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > > /******* USB2.0 Host registers (original offset is +0x200) *******/ > #define USB2_INT_ENABLE 0x000 > @@ -77,6 +78,7 @@ > struct rcar_gen3_chan { > void __iomem *base; > struct phy *phy; > + struct regulator *vbus; > bool has_otg; > }; > > @@ -210,6 +212,13 @@ static int rcar_gen3_phy_usb2_power_on(struct phy *p) > struct rcar_gen3_chan *channel = phy_get_drvdata(p); > void __iomem *usb2_base = channel->base; > u32 val; > + int ret; > + > + if (channel->vbus) { > + ret = regulator_enable(channel->vbus); > + if (ret) > + return ret; > + } > > val = readl(usb2_base + USB2_USBCTR); > val |= USB2_USBCTR_PLL_RST; > @@ -220,10 +229,22 @@ static int rcar_gen3_phy_usb2_power_on(struct phy *p) > return 0; > } > > +static int rcar_gen3_phy_usb2_power_off(struct phy *p) > +{ > + struct rcar_gen3_chan *channel = phy_get_drvdata(p); > + int ret = 0; > + > + if (channel->vbus) > + ret = regulator_disable(channel->vbus); > + > + return ret; > +} > + > static struct phy_ops rcar_gen3_phy_usb2_ops = { > .init = rcar_gen3_phy_usb2_init, > .exit = rcar_gen3_phy_usb2_exit, > .power_on = rcar_gen3_phy_usb2_power_on, > + .power_off = rcar_gen3_phy_usb2_power_off, > .owner = THIS_MODULE, > }; > > @@ -290,6 +311,13 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev) > return PTR_ERR(channel->phy); > } > > + channel->vbus = devm_regulator_get_optional(dev, "vbus"); > + if (IS_ERR(channel->vbus)) { > + if (PTR_ERR(channel->vbus) == -EPROBE_DEFER) > + return PTR_ERR(channel->vbus); > + channel->vbus = NULL; > + } > + > phy_set_drvdata(channel->phy, channel); > > provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 2/3] phy: rcar-gen3-usb2: Add vbus-supply to handle VBUS on/off Date: Tue, 5 Apr 2016 16:23:35 +0530 Message-ID: <5703992F.7090601@ti.com> References: <1456999746-2800-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1456999746-2800-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1456999746-2800-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> Sender: linux-renesas-soc-owner@vger.kernel.org To: Yoshihiro Shimoda , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi, On Thursday 03 March 2016 03:39 PM, Yoshihiro Shimoda wrote: > To handle the VBUS on/off by a regulator driver, this patch adds > regulator APIs calling in the driver and description about vbus-supply > in the rcar-gen3-phy-usb2.txt. > > Signed-off-by: Yoshihiro Shimoda > Acked-by: Rob Herring > --- > .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 ++ > drivers/phy/phy-rcar-gen3-usb2.c | 28 ++++++++++++++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > index 86826ca..7243b3b 100644 > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > @@ -21,6 +21,8 @@ To use a USB channel where USB 2.0 Host and HSUSB (USB 2.0 Peripheral) are > combined, the device tree node should set interrupt properties to use the > channel as USB OTG: > - interrupts: interrupt specifier for the PHY. > +- vbus-supply: Phandle to a regulator that provides power to the VBUS. This > + regulator will be managed during the PHY power on/off sequence. Why not use phy-supply from the generic PHY binding? It can then be managed by the phy core during power_on/power_off. Thanks Kishon > > Example (R-Car H3): > > diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c > index 3c647cd..7b14244 100644 > --- a/drivers/phy/phy-rcar-gen3-usb2.c > +++ b/drivers/phy/phy-rcar-gen3-usb2.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > > /******* USB2.0 Host registers (original offset is +0x200) *******/ > #define USB2_INT_ENABLE 0x000 > @@ -77,6 +78,7 @@ > struct rcar_gen3_chan { > void __iomem *base; > struct phy *phy; > + struct regulator *vbus; > bool has_otg; > }; > > @@ -210,6 +212,13 @@ static int rcar_gen3_phy_usb2_power_on(struct phy *p) > struct rcar_gen3_chan *channel = phy_get_drvdata(p); > void __iomem *usb2_base = channel->base; > u32 val; > + int ret; > + > + if (channel->vbus) { > + ret = regulator_enable(channel->vbus); > + if (ret) > + return ret; > + } > > val = readl(usb2_base + USB2_USBCTR); > val |= USB2_USBCTR_PLL_RST; > @@ -220,10 +229,22 @@ static int rcar_gen3_phy_usb2_power_on(struct phy *p) > return 0; > } > > +static int rcar_gen3_phy_usb2_power_off(struct phy *p) > +{ > + struct rcar_gen3_chan *channel = phy_get_drvdata(p); > + int ret = 0; > + > + if (channel->vbus) > + ret = regulator_disable(channel->vbus); > + > + return ret; > +} > + > static struct phy_ops rcar_gen3_phy_usb2_ops = { > .init = rcar_gen3_phy_usb2_init, > .exit = rcar_gen3_phy_usb2_exit, > .power_on = rcar_gen3_phy_usb2_power_on, > + .power_off = rcar_gen3_phy_usb2_power_off, > .owner = THIS_MODULE, > }; > > @@ -290,6 +311,13 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev) > return PTR_ERR(channel->phy); > } > > + channel->vbus = devm_regulator_get_optional(dev, "vbus"); > + if (IS_ERR(channel->vbus)) { > + if (PTR_ERR(channel->vbus) == -EPROBE_DEFER) > + return PTR_ERR(channel->vbus); > + channel->vbus = NULL; > + } > + > phy_set_drvdata(channel->phy, channel); > > provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); >