From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759006AbcDENok (ORCPT ); Tue, 5 Apr 2016 09:44:40 -0400 Received: from foss.arm.com ([217.140.101.70]:51315 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932880AbcDENoi (ORCPT ); Tue, 5 Apr 2016 09:44:38 -0400 Subject: Re: [PATCH 2/4] irqchip: bcm2836: Drop smp_set_ops on arm64 builds To: Eric Anholt , linux-rpi-kernel@lists.infradead.org References: <1459827858-3871-1-git-send-email-eric@anholt.net> <1459827858-3871-3-git-send-email-eric@anholt.net> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , Thomas Gleixner , Jason Cooper From: Marc Zyngier Organization: ARM Ltd Message-ID: <5703C142.6050904@arm.com> Date: Tue, 5 Apr 2016 14:44:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <1459827858-3871-3-git-send-email-eric@anholt.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric, On 05/04/16 04:44, Eric Anholt wrote: > For arm64, the bootloader will instead be implementing the spin-table > enable method. You may also want to add that SMP ops simply do not exist on arm64, hence the bootloader [...]. > > Signed-off-by: Eric Anholt > --- > drivers/irqchip/irq-bcm2836.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c > index 233ccdd..4ae9f76 100644 > --- a/drivers/irqchip/irq-bcm2836.c > +++ b/drivers/irqchip/irq-bcm2836.c > @@ -223,6 +223,7 @@ static struct notifier_block bcm2836_arm_irqchip_cpu_notifier = { > .priority = 100, > }; > > +#ifdef ARM That should really be CONFIG_ARM. > int __init bcm2836_smp_boot_secondary(unsigned int cpu, > struct task_struct *idle) > { > @@ -238,7 +239,7 @@ int __init bcm2836_smp_boot_secondary(unsigned int cpu, > static const struct smp_operations bcm2836_smp_ops __initconst = { > .smp_boot_secondary = bcm2836_smp_boot_secondary, > }; > - > +#endif > #endif > > static const struct irq_domain_ops bcm2836_arm_irqchip_intc_ops = { > @@ -256,8 +257,11 @@ bcm2836_arm_irqchip_smp_init(void) > register_cpu_notifier(&bcm2836_arm_irqchip_cpu_notifier); > > set_smp_cross_call(bcm2836_arm_irqchip_send_ipi); > + > +#ifdef ARM > smp_set_ops(&bcm2836_smp_ops); > #endif > +#endif > } > > /* > Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Tue, 5 Apr 2016 14:44:34 +0100 Subject: [PATCH 2/4] irqchip: bcm2836: Drop smp_set_ops on arm64 builds In-Reply-To: <1459827858-3871-3-git-send-email-eric@anholt.net> References: <1459827858-3871-1-git-send-email-eric@anholt.net> <1459827858-3871-3-git-send-email-eric@anholt.net> Message-ID: <5703C142.6050904@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Eric, On 05/04/16 04:44, Eric Anholt wrote: > For arm64, the bootloader will instead be implementing the spin-table > enable method. You may also want to add that SMP ops simply do not exist on arm64, hence the bootloader [...]. > > Signed-off-by: Eric Anholt > --- > drivers/irqchip/irq-bcm2836.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-bcm2836.c b/drivers/irqchip/irq-bcm2836.c > index 233ccdd..4ae9f76 100644 > --- a/drivers/irqchip/irq-bcm2836.c > +++ b/drivers/irqchip/irq-bcm2836.c > @@ -223,6 +223,7 @@ static struct notifier_block bcm2836_arm_irqchip_cpu_notifier = { > .priority = 100, > }; > > +#ifdef ARM That should really be CONFIG_ARM. > int __init bcm2836_smp_boot_secondary(unsigned int cpu, > struct task_struct *idle) > { > @@ -238,7 +239,7 @@ int __init bcm2836_smp_boot_secondary(unsigned int cpu, > static const struct smp_operations bcm2836_smp_ops __initconst = { > .smp_boot_secondary = bcm2836_smp_boot_secondary, > }; > - > +#endif > #endif > > static const struct irq_domain_ops bcm2836_arm_irqchip_intc_ops = { > @@ -256,8 +257,11 @@ bcm2836_arm_irqchip_smp_init(void) > register_cpu_notifier(&bcm2836_arm_irqchip_cpu_notifier); > > set_smp_cross_call(bcm2836_arm_irqchip_send_ipi); > + > +#ifdef ARM > smp_set_ops(&bcm2836_smp_ops); > #endif > +#endif > } > > /* > Thanks, M. -- Jazz is not dead. It just smells funny...