From: Edward Cree <ecree@solarflare.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Tom Herbert <tom@herbertland.com>,
David Miller <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Alexander Duyck <alexander.duyck@gmail.com>,
Alex Duyck <aduyck@mirantis.com>, Jesse Gross <jesse@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864
Date: Wed, 6 Apr 2016 16:55:47 +0100 [thread overview]
Message-ID: <57053183.6030002@solarflare.com> (raw)
In-Reply-To: <1459957158.6473.363.camel@edumazet-glaptop3.roam.corp.google.com>
On 06/04/16 16:39, Eric Dumazet wrote:
> Look at the mess of some helpers in net/core/skbuff.c, and imagine the
> super mess it would be if using a concept of 'super packet with various
> headers on each segment'.
Maybe I'm still not explaining this very well, but there is _no_ concept of
'super packet [anything]' in this idea. There is just 'list of skbs that
were all received in the same NAPI poll, and have not yet been determined to
be different'.
Any layer that doesn't want to deal with this stuff will always have the
option of "while (skb = skb_dequeue(list)) my_normal_receive_function(skb);"
and in fact I'd make that happen by default for anything that hadn't
registered a function to take a list.
> netfilter is already complex, it would become a nightmare.
A netfilter hook could, for instance, run on each packet in the list, then
partition the list into sub-lists of packets that all had the same verdict
(letting go of any that were DROP or STOLEN). That doesn't seem like it
should be nightmarish.
-Ed
next prev parent reply other threads:[~2016-04-06 15:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 16:27 [net PATCH v2 0/2] Fixes for GRO and GRE tunnels Alexander Duyck
2016-04-04 16:28 ` [net PATCH v2 1/2] GRE: Disable segmentation offloads w/ CSUM and we are encapsulated via FOU Alexander Duyck
2016-04-04 16:31 ` [net PATCH v2 2/2] ipv4/GRO: Make GRO conform to RFC 6864 Alexander Duyck
2016-04-05 0:38 ` subashab
2016-04-05 3:44 ` Herbert Xu
2016-04-05 4:26 ` Alexander Duyck
2016-04-05 4:32 ` Herbert Xu
2016-04-05 15:07 ` Edward Cree
2016-04-05 15:36 ` Tom Herbert
2016-04-05 17:06 ` Edward Cree
2016-04-05 17:38 ` Tom Herbert
2016-04-06 0:04 ` Marcelo Ricardo Leitner
2016-04-05 23:45 ` David Miller
2016-04-06 11:21 ` Edward Cree
2016-04-06 13:53 ` Tom Herbert
2016-04-06 14:26 ` Edward Cree
2016-04-06 15:39 ` Eric Dumazet
2016-04-06 15:55 ` Edward Cree [this message]
2016-04-06 16:03 ` Eric Dumazet
2016-04-06 15:43 ` David Miller
2016-04-06 17:42 ` Tom Herbert
2016-04-06 19:30 ` David Miller
2016-04-05 15:52 ` Alexander Duyck
2016-04-05 16:30 ` Eric Dumazet
2016-04-05 16:45 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57053183.6030002@solarflare.com \
--to=ecree@solarflare.com \
--cc=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.