From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiang Qiu Subject: Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property Date: Thu, 7 Apr 2016 19:45:30 +0800 Message-ID: <5706485A.1000802@huawei.com> References: <1459926480-32966-1-git-send-email-qiujiang@huawei.com> <1459926480-32966-2-git-send-email-qiujiang@huawei.com> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org To: Andy Shevchenko Cc: Linus Walleij , Alexandre Courbot , Mika Westerberg , Alan Tull , Jamie Iles , charles.chenxin@huawei.com, "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-acpi@vger.kernel.org" , linuxarm@huawei.com List-Id: linux-acpi@vger.kernel.org Hi Andy, Thanks for your reply. See my comments inline. Thanks Jiang =E5=9C=A8 2016/4/6 20:57, Andy Shevchenko =E5=86=99=E9=81=93: > On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote= : >> This patch removed the name property from dwapb_port_property. >> The name property is redundant because we can get those info >> from dwapb_gpio dev and pp->idx property. >=20 > Where idx is used in such replacements? Actually, it is not used so far. As Alan mentioned, the only additional info from the pp->name against dev is the port index. I present here to prevent anyone from missing it. If it is inappropriate, I will remove it. >=20 >> --- a/drivers/gpio/gpio-dwapb.c >> +++ b/drivers/gpio/gpio-dwapb.c >> @@ -409,8 +409,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio= *gpio, >> err =3D bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, = dirout, >> NULL, false); >> if (err) { >> - dev_err(gpio->dev, "failed to init gpio chip for %s\= n", >> - pp->name); >> + dev_err(gpio->dev, "failed to init gpio chip\n"); >=20 > Do we have any port index here available (expected value I suppose)? The 3rd parameter 'offs' can be used, I will add it. >=20 >> @@ -429,8 +428,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio= *gpio, >> >> err =3D gpiochip_add_data(&port->gc, port); >> if (err) >> - dev_err(gpio->dev, "failed to register gpiochip for = %s\n", >> - pp->name); >> + dev_err(gpio->dev, "failed to register gpiochip\n"); >=20 > Ditto. >=20 >=20 >> @@ -499,15 +498,12 @@ dwapb_gpio_get_pdata_of(struct device *dev) >> if (pp->idx =3D=3D 0 && >> of_property_read_bool(port_np, "interrupt-contro= ller")) { >> pp->irq =3D irq_of_parse_and_map(port_np, 0)= ; >> - if (!pp->irq) { >> - dev_warn(dev, "no irq for bank %s\n"= , >> - port_np->full_name); >> - } >> + if (!pp->irq) >> + dev_warn(dev, "no irq for this bank\= n"); >=20 > pp->idx here? >=20 > dev_warn(dev, "no irq for port%d\n", pp->idx); Here, pp->idx should always be zero, means portA, because only portA ca= n be a interrupt controller as dwapb gpio IP defined. So, I omited it. >=20 >> --- a/drivers/mfd/intel_quark_i2c_gpio.c >> +++ b/drivers/mfd/intel_quark_i2c_gpio.c >> @@ -220,7 +220,6 @@ static int intel_quark_gpio_setup(struct pci_dev= *pdev, struct mfd_cell *cell) >> >> /* Set the properties for portA */ >> pdata->properties->node =3D NULL; >> - pdata->properties->name =3D "intel-quark-x1000-gpio-= portA"; >> pdata->properties->idx =3D 0; >> pdata->properties->ngpio =3D INTEL_QUARK_MFD_NGPIO; >> pdata->properties->gpio_base =3D INTEL_QUARK_MFD_GPIO_BAS= E; >=20 > For Quark part: > Acked-by: Andy Shevchenko >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756026AbcDGLqR (ORCPT ); Thu, 7 Apr 2016 07:46:17 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:17866 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755550AbcDGLqN (ORCPT ); Thu, 7 Apr 2016 07:46:13 -0400 Reply-To: Subject: Re: [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property References: <1459926480-32966-1-git-send-email-qiujiang@huawei.com> <1459926480-32966-2-git-send-email-qiujiang@huawei.com> To: Andy Shevchenko CC: Linus Walleij , Alexandre Courbot , Mika Westerberg , "Alan Tull" , Jamie Iles , , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-acpi@vger.kernel.org" , From: Jiang Qiu Message-ID: <5706485A.1000802@huawei.com> Date: Thu, 7 Apr 2016 19:45:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.160.152] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.5706486C.004A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 35d75930301f8f8447ce3cb2ca378ed5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, Thanks for your reply. See my comments inline. Thanks Jiang 在 2016/4/6 20:57, Andy Shevchenko 写道: > On Wed, Apr 6, 2016 at 10:07 AM, qiujiang wrote: >> This patch removed the name property from dwapb_port_property. >> The name property is redundant because we can get those info >> from dwapb_gpio dev and pp->idx property. > > Where idx is used in such replacements? Actually, it is not used so far. As Alan mentioned, the only additional info from the pp->name against dev is the port index. I present here to prevent anyone from missing it. If it is inappropriate, I will remove it. > >> --- a/drivers/gpio/gpio-dwapb.c >> +++ b/drivers/gpio/gpio-dwapb.c >> @@ -409,8 +409,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, >> err = bgpio_init(&port->gc, gpio->dev, 4, dat, set, NULL, dirout, >> NULL, false); >> if (err) { >> - dev_err(gpio->dev, "failed to init gpio chip for %s\n", >> - pp->name); >> + dev_err(gpio->dev, "failed to init gpio chip\n"); > > Do we have any port index here available (expected value I suppose)? The 3rd parameter 'offs' can be used, I will add it. > >> @@ -429,8 +428,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, >> >> err = gpiochip_add_data(&port->gc, port); >> if (err) >> - dev_err(gpio->dev, "failed to register gpiochip for %s\n", >> - pp->name); >> + dev_err(gpio->dev, "failed to register gpiochip\n"); > > Ditto. > > >> @@ -499,15 +498,12 @@ dwapb_gpio_get_pdata_of(struct device *dev) >> if (pp->idx == 0 && >> of_property_read_bool(port_np, "interrupt-controller")) { >> pp->irq = irq_of_parse_and_map(port_np, 0); >> - if (!pp->irq) { >> - dev_warn(dev, "no irq for bank %s\n", >> - port_np->full_name); >> - } >> + if (!pp->irq) >> + dev_warn(dev, "no irq for this bank\n"); > > pp->idx here? > > dev_warn(dev, "no irq for port%d\n", pp->idx); Here, pp->idx should always be zero, means portA, because only portA can be a interrupt controller as dwapb gpio IP defined. So, I omited it. > >> --- a/drivers/mfd/intel_quark_i2c_gpio.c >> +++ b/drivers/mfd/intel_quark_i2c_gpio.c >> @@ -220,7 +220,6 @@ static int intel_quark_gpio_setup(struct pci_dev *pdev, struct mfd_cell *cell) >> >> /* Set the properties for portA */ >> pdata->properties->node = NULL; >> - pdata->properties->name = "intel-quark-x1000-gpio-portA"; >> pdata->properties->idx = 0; >> pdata->properties->ngpio = INTEL_QUARK_MFD_NGPIO; >> pdata->properties->gpio_base = INTEL_QUARK_MFD_GPIO_BASE; > > For Quark part: > Acked-by: Andy Shevchenko >