From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 3/3] drm/i915: Only grab correct forcewake for the engine with execlists Date: Thu, 7 Apr 2016 15:36:04 +0100 Message-ID: <57067054.6090103@linux.intel.com> References: <1460037940-14094-1-git-send-email-tvrtko.ursulin@linux.intel.com> <1460037940-14094-3-git-send-email-tvrtko.ursulin@linux.intel.com> <20160407142431.GE18061@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 039CB6E9AB for ; Thu, 7 Apr 2016 14:36:38 +0000 (UTC) In-Reply-To: <20160407142431.GE18061@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA3LzA0LzE2IDE1OjI0LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gVGh1LCBBcHIgMDcs IDIwMTYgYXQgMDM6MDU6NDBQTSArMDEwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+IEBAIC0y MDk5LDYgKzIxMDEsMTIgQEAgbG9naWNhbF9yaW5nX2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRl diwgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+Pgo+PiAgIAlsb2dpY2FsX3Jpbmdf aW5pdF9wbGF0Zm9ybV9pbnZhcmlhbnRzKGVuZ2luZSk7Cj4+Cj4+ICsJZW5naW5lLT5md19kb21h aW5zX2Vsc3AgPQo+PiArCQlpbnRlbF9yZWdfd3JpdGVfZndfZG9tYWlucyhkZXZfcHJpdiwgUklO R19FTFNQKGVuZ2luZSkpOwo+PiArCWVuZ2luZS0+ZndfZG9tYWluc19jc2IgPQo+PiArCQlpbnRl bF9yZWdfd3JpdGVfZndfZG9tYWlucyhkZXZfcHJpdiwKPj4gKwkJCQkJICAgUklOR19DT05URVhU X1NUQVRVU19QVFIoZW5naW5lKSk7Cj4KPiBTbyBpcyB3cml0ZSBhIHN1cGVyc2V0IG9mIGZ3PyBU ZW5kcyB0byBiZSByZWFkcyB0aGF0IHJlcXVpcmUgZncgbW9yZQo+IHRoYW4gd3JpdGVzIChnZW42 LzcgZmlmbywgZ2VuOCB3cml0ZSBzaGFkb3dpbmcpLgo+Cj4gSSB0aGluayB3ZSBuZWVkIGEgUkVB RCB8IFdSSVRFIGRpcmVjdGlvbiBmaWVsZC4KCkhtLCB5ZXMgZW1iZWRkaW5nIHRvbyBtdWNoIGtu b3dsZWRnZSBpbiB0aGUgY2FsbGVyLCBob3cgYWJvdXQganVzdDoKCgllbmdpbmUtPmZ3X2RvbWFp bnNfY3NiID0gaW50ZWxfcmVnX3JlYWRfZndfZG9tYWlucyhkZXZfcHJpdiwKCQkJCSBSSU5HX0NP TlRFWFRfU1RBVFVTX1BUUihlbmdpbmUpKTsKCgllbmdpbmUtPmZ3X2RvbWFpbnNfY3NiIHw9IGlu dGVsX3JlZ193cml0ZV9md19kb21haW5zKGRldl9wcml2LAoJCQkJICBSSU5HX0NPTlRFWFRfU1RB VFVTX1BUUihlbmdpbmUpKTsKCj8KCj4+ICsvKioKPj4gKyAqIGludGVsX3JlZ193cml0ZV9md19k b21haW5zIC0gd2hpY2ggZm9yY2V3YWtlIGRvbWFpbnMgYXJlIG5lZWRlZCB0byB3cml0ZSBhIHJl Z2lzdGVyCj4+ICsgKiBAZGV2X3ByaXY6IHBvaW50ZXIgdG8gc3RydWN0IGRybV9pOTE1X3ByaXZh dGUKPj4gKyAqIEByZWc6IHJlZ2lzdGVyIGluIHF1ZXN0aW9uCj4+ICsgKgo+PiArICogUmV0dXJu cyBhIHNldCBvZiBmb3JjZXdha2UgZG9tYWlucyByZXF1aXJlZCB0byBiZSB0YWtlbiB3aXRoIGZv ciBleGFtcGxlCj4+ICsgKiBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX2dldCBmb3IgdGhlIHNwZWNp ZmllZCByZWdpc3RlciB0byBiZSB3cml0YWJsZSB3aXRoIHRoZQo+PiArICogcmF3IG1taW8gYWNj ZXNzb3JzLgo+PiArICovCj4+ICtlbnVtIGZvcmNld2FrZV9kb21haW5zCj4+ICtpbnRlbF9yZWdf d3JpdGVfZndfZG9tYWlucyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGk5MTVf cmVnX3QgcmVnKQo+PiArewo+PiArCWVudW0gZm9yY2V3YWtlX2RvbWFpbnMgZndfZG9tYWluczsK Pj4gKwo+PiArCWlmIChpbnRlbF92Z3B1X2FjdGl2ZShkZXZfcHJpdi0+ZGV2KSkKPj4gKwkJcmV0 dXJuIDA7Cj4+ICsKPj4gKwlzd2l0Y2ggKElOVEVMX0lORk8oZGV2X3ByaXYpLT5nZW4pIHsKPj4g KwljYXNlIDk6Cj4+ICsJCWZ3X2RvbWFpbnMgPSBfX2dlbjlfcmVnX3dyaXRlX2Z3X2RvbWFpbnMo aTkxNV9tbWlvX3JlZ19vZmZzZXQocmVnKSk7Cj4+ICsJCWJyZWFrOwo+PiArCWNhc2UgODoKPj4g KwkJaWYgKElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+PiArCQkJZndfZG9tYWlucyA9IF9fY2h2 X3JlZ193cml0ZV9md19kb21haW5zKGk5MTVfbW1pb19yZWdfb2Zmc2V0KHJlZykpOwo+PiArCQll bHNlCj4+ICsJCQlmd19kb21haW5zID0gX19nZW44X3JlZ193cml0ZV9md19kb21haW5zKGk5MTVf bW1pb19yZWdfb2Zmc2V0KHJlZykpOwo+PiArCQlicmVhazsKPj4gKwlkZWZhdWx0Ogo+PiArCQlN SVNTSU5HX0NBU0UoSU5URUxfSU5GTyhkZXZfcHJpdiktPmdlbik7Cj4+ICsJY2FzZSA3Ogo+PiAr CWNhc2UgNjoKPgo+IFRoaXMgaXMgYWN0dWFsbHkgYSB0cmlja3kgb25lLiBnZW42LzcgbWFpbnRh aW4gYSBGSUZPIHRvIHN0b3JlIG1taW8KPiB3cml0ZXMgd2hpbHN0IGl0IGlzIHBvd2VyZWQgZG93 bi4gSWYgd2UgZmlsbCB0aGF0IGZpZm8gd2UgZHJvcCB3cml0ZXMKPiAoYW5kIHRoYXQgZmlmbyBp cyBzaGFyZWQgd2l0aCBmdW5jdGlvbnMgb24gdGhlIGRldmljZSwgaS5lLiBpdCBpcyBub3QKPiBv dXJzIHRvIGZpbGwgZXhjbHVzaXZlbHkpLiBTbyBzaG91bGQgd2UgYmUgc2F2aW5nIHRoYXQgaWYg eW91IHdhbnQgdG8KPiBtYWtlIGxvdHMgb2Ygd3JpdGVzIHlvdSBzaG91bGQgdGFrZSB0aGlzIGZv cmNld2FrZSBkb21haW4uIFllcy4gV2Ugc2hvdWxkCj4gcmVwb3J0IHdoYXQgZG9tYWlucyB0aGV5 IHdvdWxkIHJlcXVpcmUsIGl0IGlzIHN0aWxsIHVwIHRvIHRoZSBjYWxsZXIgYXMKPiB0byB3aGV0 aGVyIHRoZXkgcmlzayB0aGUgRklGTyBvdmVyZmxvd2luZywgYnV0IHRoZXkgc2hvdWxkIGhhdmUg dGhlIHJpZ2h0Cj4gaW5mb3JtYXRpb24gdG8gaGFuZC4KCk1pc3NlZCB0aGF0LiBCdXQgaXQgaXNu J3QgcGFydCBvZiBmb3JjZXdha2UgZG9tYWlucy4gU28gd2hhdCB3b3VsZCB5b3UgCnJldHVybj8g RmFrZSBvdXQgYSBuZXcgZG9tYWluIGp1c3QgY29tcGxpY2F0ZXMgdGhpbmdzIGFuZCBhZGRzIGNv c3QgZm9yIApldmVyeW9uZS4gTWF5YmUgYmV0dGVyIGp1c3QgdG8gbGltaXQgdGhlIHdob2xlIHRo aW5nIHRvIGdlbjgrIGFuZCBsZWF2ZSAKb2xkZXJzIHBsYXRmb3JtcyB1bnRvdWNoZWQ/CgpSZWdh cmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=