From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756756AbcDGP62 (ORCPT ); Thu, 7 Apr 2016 11:58:28 -0400 Received: from mail-by2on0123.outbound.protection.outlook.com ([207.46.100.123]:28346 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751397AbcDGP60 (ORCPT ); Thu, 7 Apr 2016 11:58:26 -0400 Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=hpe.com; Message-ID: <57068395.1080703@hpe.com> Date: Thu, 7 Apr 2016 11:58:13 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Tejun Heo CC: "Theodore Ts'o" , Andreas Dilger , Christoph Lameter , , , Scott J Norton , Douglas Hatch , Toshimitsu Kani Subject: Re: [PATCH 2/3] percpu_stats: Simple per-cpu statistics count helper functions References: <1459566578-30221-1-git-send-email-Waiman.Long@hpe.com> <1459566578-30221-3-git-send-email-Waiman.Long@hpe.com> <20160404160228.GW7822@mtj.duckdns.org> <570584F1.10909@hpe.com> <20160406225424.GK24661@htj.duckdns.org> In-Reply-To: <20160406225424.GK24661@htj.duckdns.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.60] X-ClientProxiedBy: CO2PR11CA0011.namprd11.prod.outlook.com (10.141.242.149) To AT5PR84MB0306.NAMPRD84.PROD.OUTLOOK.COM (10.162.138.28) X-MS-Office365-Filtering-Correlation-Id: 72c57b61-d15d-46b7-7578-08d35efd729f X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0306;2:eAiECUtyHcOwSPEarD+FPsMAeny8A5XaS7B4rMkd2x9qlHLnPv0lTi3CJALuzqsgjyhTU/f7XDe4oRgbdwE0vIUBexfOU2Txfehb9qJQX23ZA9wDj5V6SwX+qQ9ajuPbJHzYVM9JoKRDZ2vUdGgvqZECJnlW9ScD1ciDLt5oXHuDbz94938eyEPIhdvxTaE/;3:LOCHovp/6fsbK7kPctu7adberR7P4t4ikwZShkZhbjcGLv+UFuEev/lc7xcKd9ifT+f+j5A8atXHp4ugs989u8qPjbJ6BUN9B6SfgYH1JrALUhE63U5MHH67Q3R1IPo4;25:Ysyry5srjgs9Jp87HL0ejaLEOndV26N78PxUi6LF/XWQ07MmPIqKuj6hSi9IAcJ/IFNDsLaAf+SxGrRpUOez272BTbPxRJL8CUYMbbghw2RzDorqXKrm/uEMvOTSkToTNimSg3Gvea/tZDDH/EaPMNDO8ImzXICqM3gnhGj8Er5bYA066pKNsVLC6Da3HWBNpv2VXYWybKABvdloyUmqKoJCZVh/AyjC+LZtJiEun5Ms3xW4asiaAhax+02GEYGGGN4jq7+FQX5brtEI4AAXhOjuCT4XnGbtFLJSSon/YfJJdcZejAA2+stILPJvl1WihzsaIddSgAdBWte1FX712HdQkiZxzXqvgaSKP9iGxftuRk76NvJUFEGDd77VVokXo5SnTBY5Bd4Rv+p2+Kwus8OsCn6geTQp66N+egPAWsb6K28Tv5SPfclNfpLPKOqT7Spz40pe3ZnEuQjLYNmEO2gSgFmxJnJGZLaMefsTh7WxbjiCsSQkWlkn+8jkX60UM2Y8235cmV73zd4R+W+FkwGoY2OghKudSqMms62DVzlkGu0gyERs+CeKoIQlf4JnwOldRKWL69qb6dLx0TnZYw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0306; X-LD-Processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0306;20:VGHzge4pE7d08lLdj3RkCbxIw1/AHS2l3Bg8iyLHsS8KQW7MqUCAdfhT5EQuJyv8qkwGvfIUw96FzuRZuO2L4ipCAX/0sJHxQjhxsHmKXy5a6Ib3Z3Bg+VzQu7vpY0pz2Ojv0OgfPkrmKb5wd8j2zNkAYjz+aAnI8+NUsdg2FX3b1tI+g8z5IcYY/P7DtXtcHJ8vhoSCDamqHx6J33ATui0W6j6LmTBzT72/AdwxKwihHVkP2U7jR4ctqnhWjhO54ONLPgCw486kZVqQjiPBHnX/vAoQ0TznP8Z3MQNN8j6Aq0wLgDTdqzYKAJmBLwhmmn89Y+T7bMTkqPnQ6K732w==;4:FsypnsIda8afNFQCUxNyqeDjJDdJazPE8lt74ydVyz4EvN2kvxK/scS5DA6JZPfM6r03OO4hzQP5G3iyxwqHHNAWcsN4M3ZonfmzewkiHug67V2hwyNBc/SgJNiA66/QosXOxyVS+C+s6bbtXReaL2T03Wtp2nsqjTwsxdTNHJ2fzLhjRSKK+Rr1RddpxZl23TNf3oIrglHD9+IC0Zuh3BY70d8aVO9cDDTbaYaL+5fqvUGP6Tx9znQereACf8Gq3GWLR7Govb618m5XrNMYn9dCk8XS8x67zdBd+d5VOcKd+nVbTsUGNAcyAWz1hvnoRR2SmeDAnKTAUSnjg11qiox7JteClbJMHxNfIlVN5TVi/x4QPnr9iStFtzFdcDzhOW9NG8UxFpF4LtR1jpIEkg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:AT5PR84MB0306;BCL:0;PCL:0;RULEID:;SRVR:AT5PR84MB0306; X-Forefront-PRVS: 0905A6B2C7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(377454003)(24454002)(42186005)(83506001)(117156001)(47776003)(93886004)(117636001)(66066001)(87266999)(50986999)(54356999)(92566002)(5004730100002)(65816999)(86362001)(36756003)(76176999)(4326007)(5008740100001)(2950100001)(64126003)(189998001)(1096002)(81166005)(77096005)(2906002)(4001350100001)(50466002)(230700001)(122286003)(586003)(23756003)(3846002)(110136002)(6116002)(62816006);DIR:OUT;SFP:1102;SCL:1;SRVR:AT5PR84MB0306;H:[192.168.142.152];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;AT5PR84MB0306;23:chPcGqELvADnl9WOV3OYz5VPk3chxFKNip4PYnz?= =?iso-8859-1?Q?/0iDm3NY+H5tsLnKbt4qiZyGkYwGhogcbRkrvBAj96sFc9GYzBQzM85nAV?= =?iso-8859-1?Q?EyUE5Ps7ODk7Q0AROLXM2rLZcej4xkkaNebzs6hdmsVFF3i/PWHO7sw5bl?= =?iso-8859-1?Q?OiI6e7G8hLEDLyerA1IZNAzaqh3+lFf0U8ctqWMEJ7tmNjHrzGN+baLptB?= =?iso-8859-1?Q?2rD83gOm9KSAKq8vigza+ZT9m1et2mT/7rP9N/ReUK2VL2XUYHOEsZsoaR?= =?iso-8859-1?Q?FK55hhrrT8va5L83oXOtzXCHaOJcWwAPD9czslcLUPerdX4v396ltWxGWc?= =?iso-8859-1?Q?f8VTjRSVbApOfnjrOtemtNM2xx1ki8GD8t7eaIvPcAFC6qqB0VaNz9U8O7?= =?iso-8859-1?Q?TghSARkC7IFaj516i6GRn7to9K1sB7jQ3AvpHx6zIh2ymol0D2kvYbscwt?= =?iso-8859-1?Q?j4iWb/G5uAz8vSr9KfLcbklwhzLXWOhT7uNRj7goZZk/DaxCq3HYoJlH7a?= =?iso-8859-1?Q?w1yQzgPaHI1+Wsnpp0IzyD81B8vOToId4UxpMMwupvYSCF6IRrzSGQiOou?= =?iso-8859-1?Q?wJmM63fQ9oAXt8OHpXyW9n+KT1iHGBtA0bL8tKQeju9iA7NojYAPNspvBM?= =?iso-8859-1?Q?B4Ow2Zd06iZ2eLB+K4xe904fDxI5aurG1RTxQZ3rHWFaFlYLx1t94vcnwm?= =?iso-8859-1?Q?kXIuE/UhV1brw3Wokc2uMW/W8IBl9afNtOdhRUP5bzMArlVzG3zxRDxNfr?= =?iso-8859-1?Q?q3Go3BoraTHBBGptC3Qm2CY2jBBEoROKvAi/PBbHyFMDIX2WsFkZ3aIxxk?= =?iso-8859-1?Q?0eyL28ZfEUTlf2e4zV+9XxoLdMq80XymjLRchuUSFNV2DwHwG0HEwWBJch?= =?iso-8859-1?Q?obUAdNsgl5pBvDA30tMKfkVzV8Cru9inS8XXo/l934BQ+8UGP/9QTnnWKn?= =?iso-8859-1?Q?tZ0XdZ3wT5tnfreY7P0Q57C+b+nTrgiEsHSoGlirKtaxAEtKEU6FH5qcmS?= =?iso-8859-1?Q?FjFyeGmX5O7oMz4pLSIWMVDVii1Z5/6hg26a8BgLqQTXhoaq3Naeo2sFM9?= =?iso-8859-1?Q?6JOS7zogukItwkMyXGSbUrXz9odYoyUWOpmpkV0Q8c=3D?= X-Microsoft-Exchange-Diagnostics: 1;AT5PR84MB0306;5:DC+uyiJ1Yj5upnT7xK0Dc7rcpO7qNYXxcyXXsBzRdH3LC+ZaoYmAvccYMPbUUvD7nBR2tE4bRrDKClxvzEyh2WlFKI3JL11wpzil5iDu0AMzEPE/6b3dfb6HEkjL/WUfDfBV4MZV3ENAbtFsQt7yiQ==;24:piDlVXijz32g/hZNkSg30DoQ06cjoX6b/F4V4Zg/pjgwtuI1tgCNmxNa5u4NBgTBMVr73QxmfIQ48v5VnBJLA+wN3SdDoyzUCwmlLIBynzo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2016 15:58:21.2786 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0306 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/06/2016 06:54 PM, Tejun Heo wrote: > Hello, > > On Wed, Apr 06, 2016 at 05:51:45PM -0400, Waiman Long wrote: >>>> + /* >>>> + * If a statistics count is in the middle of being updated, it >>>> + * is possible that the above clearing may not work. So we need >>>> + * to double check again to make sure that the counters are really >>>> + * cleared. Still there is a still a very small chance that the >>>> + * second clearing does not work. >>>> + */ >>>> + for_each_possible_cpu(cpu) { >>>> + unsigned long *pstats = per_cpu_ptr(pcs->stats, cpu); >>>> + int stat; >>>> + >>>> + for (stat = 0; stat< pcs->nstats; stat++, pstats++) >>>> + if (*pstats) >>>> + *pstats = 0; >>>> + } >>> I don't think this is acceptable. >> I am not sure what you mean here by not acceptable. Please enlighten me on >> that. > Hmmm... I thought that was pretty clear. Try-twice-and-we-are-probably-okay > is simply not acceptable. Please make it watertight. > > Thanks. OK, I got it now. We can certainly make it watertight. However, that will certainly require adding performance overhead in the percpu stats update fast path which I am not willing to pay. The purpose of this stat counters reset functionality is to allow developers to reset the stat counters, run certain workload and see how things are going in the kernel when the workload completes assuming that those stat counters are exposed via sysfs, debugfs, etc. The developers can certainly check the stat counters after the reset to make sure that they are properly reset. So I don't think we need an airtight way of doing it. If you have scenarios in your mind that require airtight reset of the stat counters, please let me know and I will see what I can do about it. Cheers, Longman