From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04630C4345F for ; Wed, 24 Apr 2024 10:19:59 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.711320.1111190 (Exim 4.92) (envelope-from ) id 1rzZj8-0003Hs-2i; Wed, 24 Apr 2024 10:19:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 711320.1111190; Wed, 24 Apr 2024 10:19:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rzZj8-0003Hl-08; Wed, 24 Apr 2024 10:19:46 +0000 Received: by outflank-mailman (input) for mailman id 711320; Wed, 24 Apr 2024 10:19:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rzZj6-0003Hf-LD for xen-devel@lists.xenproject.org; Wed, 24 Apr 2024 10:19:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rzZj5-0007VF-Up; Wed, 24 Apr 2024 10:19:43 +0000 Received: from [15.248.2.25] (helo=[10.24.67.29]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1rzZj5-0002I1-Oe; Wed, 24 Apr 2024 10:19:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=J8uw2H5mh9dHpvwBAj0hJSbsKzXzjN0dFQBBpFXWTLs=; b=uoSZLnvPhO8q9HMoISPWPK5Qmv zasUlRIsr4hKA1eWlk7R8azP+A6cE11bUmZObNu1v1VrkS86rO1f/blgpM3xOdrSg91oM1LZKwA41 Q+hJ4NFxmvSBzPsFctFifi04G/iX1yZH5mNWQzs+WOi3YcY8rtntVH2qk0TbcouXIIMo=; Message-ID: <57070924-9c38-4524-8e36-76584c7fb3df@xen.org> Date: Wed, 24 Apr 2024 11:19:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/12] xen/arm: List static shared memory regions as /memory nodes Content-Language: en-GB From: Julien Grall To: Michal Orzel , Luca Fancellu Cc: Xen-devel , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20240418073652.3622828-1-luca.fancellu@arm.com> <20240418073652.3622828-13-luca.fancellu@arm.com> <9A107B24-E606-4926-BE1C-6FC0C6E86CF7@arm.com> <5de5dec4-7e2a-4e96-84c6-214ad781562a@xen.org> In-Reply-To: <5de5dec4-7e2a-4e96-84c6-214ad781562a@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 22/04/2024 11:24, Julien Grall wrote: > Hi, > > On 22/04/2024 10:26, Michal Orzel wrote: >> >> >> On 22/04/2024 10:07, Luca Fancellu wrote: >>> >>> >>> Hi Michal, >>> >>>>> +    for ( cells = reg, i = 0; cells < reg + nr_cells; i++, cells >>>>> += reg_size ) >>>>> +    { >>>>> +        u64 start = dt_read_number(cells, addrcells); >>>> We should no longer use Linux derived types like u64. Use uint64_t. >>>> >>>>> +        u64 size = dt_read_number(cells + addrcells, sizecells); >>>>> + >>>>> +        dt_dprintk("  Bank %d: %#"PRIx64"->%#"PRIx64"\n", >>>>> +                   i, start, start + size); >>>> i is unsigned so the correct format specifier should be %u >>> >>> Right, should have been more careful when copying the code from above >>> >>>>> >>>>> +void __init shm_mem_node_fill_reg_range(const struct kernel_info >>>>> *kinfo, >>>>> +                                        __be32 *reg, int *nr_cells, >>>>> +                                        int addrcells, int sizecells) >>>>> +{ >>>>> +    const struct membanks *mem = &kinfo->shm_mem.common; >>>>> +    unsigned int i; >>>>> +    __be32 *cells; >>>>> + >>>>> +    BUG_ON(!nr_cells || !reg); >>>>> + >>>>> +    cells = ®[*nr_cells]; >>>>> +    for ( i = 0; i < mem->nr_banks; i++ ) >>>>> +    { >>>>> +        u64 start = mem->bank[i].start; >>>> ditto >>> >>> Will fix, here paddr_t should be ok isn’t it? >> yes >> >>> >>>> >>>> Rest LGTM: >>>> Reviewed-by: Michal Orzel >>> >>> Thanks, I will send the next one shortly. >> I don't think there is a need to respin the whole series just for >> these fixes. >> You should wait for the committers opinion. > > AFAICT, there are multiple changes requested in various line. So I would > rather prefer if this is respinned. > > If this is the only patch that requires to change. You could send a new > one in reply-to this patch. I think b4 is clever enough to pick up the > new version in that case. I was wrong. b4 didn't picked up the new version. Anyway, I have applied the new patch and send to gitlab for testing. I will merge it once it passes. Cheers, -- Julien Grall