From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758040AbcDHJKL (ORCPT ); Fri, 8 Apr 2016 05:10:11 -0400 Received: from zencphosting06.zen.co.uk ([82.71.204.9]:45819 "EHLO zencphosting06.zen.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbcDHJKI (ORCPT ); Fri, 8 Apr 2016 05:10:08 -0400 Subject: Re: [PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms after reset" To: Tom Rini , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <1460069545-10322-1-git-send-email-trini@konsulko.com> Cc: Olof Johansson , Dmitry Torokhov , Henrik Rydberg From: Nick Dyer Message-ID: <5707756E.30506@itdev.co.uk> Date: Fri, 8 Apr 2016 10:10:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1460069545-10322-1-git-send-email-trini@konsulko.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-0.8 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - zencphosting06.zen.co.uk X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - itdev.co.uk X-Get-Message-Sender-Via: zencphosting06.zen.co.uk: authenticated_id: nick.dyer@itdev.co.uk X-Authenticated-Sender: zencphosting06.zen.co.uk: nick.dyer@itdev.co.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-04-07 23:52, Tom Rini wrote: > This reverts commit 885f3fb9fa1f9e185e8a4e905157087495734349 due to this > change breaking the touchpad on the Chromebook Pixel 2015 on resume from > sleep or warm resets. > > Cc: Olof Johansson > Cc: Nick Dyer > Cc: Dmitry Torokhov > Cc: Henrik Rydberg > Signed-off-by: Tom Rini Hi Tom- Sorry that this has caused a problem. I suggest we try and find a 3rd option other than reverting this patch, because otherwise we will cause problems on other platforms. I have a Pixel 2 here - can you advise how to reproduce? > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c > index 2160512..9b92b60 100644 > --- a/drivers/input/touchscreen/atmel_mxt_ts.c > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c > @@ -1098,9 +1098,7 @@ static int mxt_soft_reset(struct mxt_data *data) > struct device *dev = &data->client->dev; > int ret = 0; > > - dev_info(dev, "Resetting device\n"); > - > - disable_irq(data->irq); > + dev_info(dev, "Resetting chip\n"); > > reinit_completion(&data->reset_completion); > > @@ -1108,11 +1106,6 @@ static int mxt_soft_reset(struct mxt_data *data) > if (ret) > return ret; > > - /* Ignore CHG line for 100ms after reset */ > - msleep(100); > - > - enable_irq(data->irq); I suspect what is going on here is that Pixel 2 is using edge triggering and we are missing the edge during the 100ms delay. Could you try just changing this from "enable_irq" to mxt_acquire_irq(data); > - > ret = mxt_wait_for_completion(data, &data->reset_completion, > MXT_RESET_TIMEOUT); > if (ret) >