All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>, Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	lvivier@redhat.com, qemu-block@nongnu.org,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/2] block: Fix hang with mirroring qcow2
Date: Fri, 8 Apr 2016 14:15:44 +0200	[thread overview]
Message-ID: <5707A0F0.8080302@redhat.com> (raw)
In-Reply-To: <20160408100616.GA29498@stefanha-x1.localdomain>



On 08/04/2016 12:06, Stefan Hajnoczi wrote:
> On Tue, Apr 05, 2016 at 07:20:51PM +0800, Fam Zheng wrote:
>> See patch 1 for the bug analysis.
>>
>> v3: Make bdrv_co_drain a public function and use it directly in block/mirror.c.
>>     [Stefan]
>>
>>
>>
>> Fam Zheng (2):
>>   block: Fix bdrv_drain in coroutine
>>   mirror: Replace bdrv_drain(bs) with bdrv_co_drain(bs)
>>
>>  block/io.c            | 45 +++++++++++++++++++++++++++++++++++++++++++++
>>  block/mirror.c        |  2 +-
>>  include/block/block.h |  1 +
>>  3 files changed, 47 insertions(+), 1 deletion(-)
>>
>> -- 
>> 2.7.4
> 
> Thanks, applied to my block tree:
> https://github.com/stefanha/qemu/commits/block

FWIW, I've now rebased my bdrv_drain patches on top of this, and the
need for the extra bottom half is gone!  This is a much better solution
for that other problem with mirror.c.

Paolo

      reply	other threads:[~2016-04-08 12:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 11:20 [Qemu-devel] [PATCH v3 0/2] block: Fix hang with mirroring qcow2 Fam Zheng
2016-04-05 11:20 ` [Qemu-devel] [PATCH v3 1/2] block: Fix bdrv_drain in coroutine Fam Zheng
2016-04-05 11:20 ` [Qemu-devel] [PATCH v3 2/2] mirror: Replace bdrv_drain(bs) with bdrv_co_drain(bs) Fam Zheng
2016-04-05 13:51 ` [Qemu-devel] [PATCH v3 0/2] block: Fix hang with mirroring qcow2 Paolo Bonzini
2016-04-08  8:59 ` Fam Zheng
2016-04-08 10:06 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-04-08 12:15   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5707A0F0.8080302@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.