From: Nick Dyer <nick.dyer@itdev.co.uk>
To: Tom Rini <trini@konsulko.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Olof Johansson <olof@lixom.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>
Subject: Re: [PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms after reset"
Date: Fri, 8 Apr 2016 13:26:30 +0100 [thread overview]
Message-ID: <5707A376.2080404@itdev.co.uk> (raw)
In-Reply-To: <20160408121418.GT23166@bill-the-cat>
On 2016-04-08 13:14, Tom Rini wrote:
> On Fri, Apr 08, 2016 at 10:10:06AM +0100, Nick Dyer wrote:
>> On 2016-04-07 23:52, Tom Rini wrote:
>>> This reverts commit 885f3fb9fa1f9e185e8a4e905157087495734349 due to this
>>> change breaking the touchpad on the Chromebook Pixel 2015 on resume from
>>> sleep or warm resets.
>>>
>>> Cc: Olof Johansson <olof@lixom.net>
>>> Cc: Nick Dyer <nick.dyer@itdev.co.uk>
>>> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>> Cc: Henrik Rydberg <rydberg@bitmath.org>
>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>
>> Hi Tom-
>>
>> Sorry that this has caused a problem. I suggest we try and find a 3rd
>> option other than reverting this patch, because otherwise we will cause
>> problems on other platforms.
>
> Yeah, it would be good to fix all platforms. I'm curious, was there an
> observed problem on another platform or just a theoretical problem?
Yes, reported by several customers and I've seen it myself in testing
(Beagleboard + MXT Evaluation Kit). What happens is that the interrupt
triggers too early during the power on sequence after a soft reset and you
get an error message when the ISR fails to communicate on the appmode
address. There have been some anecdotal reports that the device may end up
stuck in the bootloader mode if this happens, although I'm not 100%
convinced this is accurate.
>> I have a Pixel 2 here - can you advise how to reproduce?
>
> I (and a bunch of other folks, the linux-samus people now point people
> at using mxt-app every boot to reset the device) see this every time I
> either suspend the laptop or do a warm boot into a new kernel (I didn't
> try kexec but it too is probably broken). Note that I'm not using
> mainline to boot ChromeOS but I've got a regular Linux distro in ROOT-C.
OK. I will try it. My Pixel is running Ubuntu with a mainline kernel, so
should be able to repro.
next prev parent reply other threads:[~2016-04-08 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 22:52 [PATCH] Revert "Input: atmel_mxt_ts - disable interrupt for 50ms after reset" Tom Rini
2016-04-08 9:10 ` Nick Dyer
2016-04-08 12:14 ` Tom Rini
2016-04-08 12:26 ` Nick Dyer [this message]
2016-04-08 12:39 ` Tom Rini
2016-04-08 21:30 ` Nick Dyer
2016-04-08 23:30 ` Tom Rini
2016-04-11 9:31 ` [PATCH] Input: atmel_mxt_ts - use mxt_acquire_irq in mxt_soft_reset Nick Dyer
2016-04-25 21:28 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5707A376.2080404@itdev.co.uk \
--to=nick.dyer@itdev.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rydberg@bitmath.org \
--cc=trini@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.