From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59703)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1apA08-0001x6-D1
	for qemu-devel@nongnu.org; Sun, 10 Apr 2016 03:41:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1apA04-0001CH-3V
	for qemu-devel@nongnu.org; Sun, 10 Apr 2016 03:41:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34974)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1apA03-0001CC-Tr
	for qemu-devel@nongnu.org; Sun, 10 Apr 2016 03:41:40 -0400
References: <1459855602-16727-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<1459855602-16727-3-git-send-email-caoj.fnst@cn.fujitsu.com>
From: Marcel Apfelbaum <marcel@redhat.com>
Message-ID: <570A03A7.6040406@redhat.com>
Date: Sun, 10 Apr 2016 10:41:27 +0300
MIME-Version: 1.0
In-Reply-To: <1459855602-16727-3-git-send-email-caoj.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 2/5] change pvscsi_init_msi() type to
 void
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: kraxel@redhat.com, jsnow@redhat.com, dmitry@daynix.com, jasowang@redhat.com, mst@redhat.com, hare@suse.de, pbonzini@redhat.com, alex.williamson@redhat.com, armbru@redhat.com

On 04/05/2016 02:26 PM, Cao jin wrote:
> Nobody use its return value, so change the type to void
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Dmitry Fleytman <dmitry@daynix.com>
> ---
>   hw/scsi/vmw_pvscsi.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 9abc086..4ce3581 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -1039,7 +1039,7 @@ pvscsi_io_read(void *opaque, hwaddr addr, unsigned size)
>   }
>
>
> -static bool
> +static void
>   pvscsi_init_msi(PVSCSIState *s)
>   {
>       int res;
> @@ -1053,8 +1053,6 @@ pvscsi_init_msi(PVSCSIState *s)
>       } else {
>           s->msi_used = true;
>       }
> -
> -    return s->msi_used;
>   }
>
>   static void
>


Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

Thanks,
Marcel