From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Mon, 11 Apr 2016 09:06:45 +0200 Subject: [U-Boot] [uboot] [PATCH 5/7] net: phy: Move is_rgmii helper to phy.h In-Reply-To: <1460131707-8496-5-git-send-email-dmurphy@ti.com> References: <1460131707-8496-1-git-send-email-dmurphy@ti.com> <1460131707-8496-5-git-send-email-dmurphy@ti.com> Message-ID: <570B4D05.3030603@xilinx.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 8.4.2016 18:08, Dan Murphy wrote: > Move the phy_interface_is_rgmii to the phy.h > file for all phy's to be able to use the API. > > This now aligns with the Linux kernel based on > commit e463d88c36d42211aa72ed76d32fb8bf37820ef1 > > Signed-off-by: Dan Murphy > --- > drivers/net/phy/ti.c | 11 ----------- > include/phy.h | 11 +++++++++++ > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c > index 922f0a4..d503eef 100644 > --- a/drivers/net/phy/ti.c > +++ b/drivers/net/phy/ti.c > @@ -156,17 +156,6 @@ void phy_write_mmd_indirect(struct phy_device *phydev, int prtad, > phy_write(phydev, addr, MII_MMD_DATA, data); > } > > -/** > - * phy_interface_is_rgmii - Convenience function for testing if a PHY interface > - * is RGMII (all variants) > - * @phydev: the phy_device struct > - */ > -static inline bool phy_interface_is_rgmii(struct phy_device *phydev) > -{ > - return phydev->interface >= PHY_INTERFACE_MODE_RGMII && > - phydev->interface <= PHY_INTERFACE_MODE_RGMII_TXID; > -} > - > #if defined(CONFIG_DM_ETH) > /** > * dp83867_data_init - Convenience function for setting PHY specific data > diff --git a/include/phy.h b/include/phy.h > index 21459a8..7b2d1ff 100644 > --- a/include/phy.h > +++ b/include/phy.h > @@ -277,6 +277,17 @@ int get_phy_id(struct mii_dev *bus, int addr, int devad, u32 *phy_id); > */ > int phy_get_interface_by_name(const char *str); > > +/** > + * phy_interface_is_rgmii - Convenience function for testing if a PHY interface > + * is RGMII (all variants) > + * @phydev: the phy_device struct > + */ > +static inline bool phy_interface_is_rgmii(struct phy_device *phydev) > +{ > + return phydev->interface >= PHY_INTERFACE_MODE_RGMII && > + phydev->interface <= PHY_INTERFACE_MODE_RGMII_TXID; > +} > + > /* PHY UIDs for various PHYs that are referenced in external code */ > #define PHY_UID_CS4340 0x13e51002 > #define PHY_UID_TN2020 0x00a19410 > Reviewed-by: Michal Simek Thanks, Michal