From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932928AbcDKNoJ (ORCPT ); Mon, 11 Apr 2016 09:44:09 -0400 Received: from mail-bn1on0074.outbound.protection.outlook.com ([157.56.110.74]:39438 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932158AbcDKNoE (ORCPT ); Mon, 11 Apr 2016 09:44:04 -0400 X-Greylist: delayed 892 seconds by postgrey-1.27 at vger.kernel.org; Mon, 11 Apr 2016 09:44:04 EDT Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu To: "Luis R. Rodriguez" , Joerg Roedel , References: <20160316171719.GE2195@8bytes.org> <1459273313-5139-1-git-send-email-mcgrof@kernel.org> CC: , "linux-kernel@vger.kernel.org" From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <570BA694.8040900@amd.com> Date: Mon, 11 Apr 2016 15:28:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1250:ae81:e81b:ad8c:4800:115c] X-ClientProxiedBy: HE1PR02CA0071.eurprd02.prod.outlook.com (10.163.170.39) To SN1PR12MB0142.namprd12.prod.outlook.com (10.162.3.141) X-MS-Office365-Filtering-Correlation-Id: de1a3dd9-c176-4f8b-721f-08d3620d42ef X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0142;2:Lt0sZr7V0856CxIhFqr4g/Ikglnpa9cAJty/PUvbuUBHtJ2s+gYHbBMbmrRMKVD39YJWXGNrWixfT603ZE47in97VLTkkIyL7hNuVASH8EXGuNWOQpDrfr/9Gu2ormOqH0h76i1j1xrTlbH6YYDVQRN/vo7DxVbGE++62h4+aTab6Qn+8vpfCH3xN+Hxq5ti;3:UxS0tUc4wgOsWpp+bAboNkONBRMU05dUsUNauk/fefaz1/FeZmyhYmIrkcBKU0CVCy4z6NhoPRmKT2aHsYEDekRPHesc/kyc+omAWNtVtSGdCEW3FwCVoOfUQ7KfkkOB X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0142; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0142;25:CwQBtoYJniq1iQLxIAYQ0rNWNDB/bQ/COAkmQf6fV0CS6A0ldD/aYEgY2R3MaCuXcdRaqswR8X4Hhx5PePAg3sWCmrMgyvgMNhUvKXheMwhYPONEBr/m5/bX6zCNh5z10YSnCGp4zWYSnH0lwCO+HDh34EkH5mF+l71ZDUkXFUbtFAbZrrbNKWesTEYnDU3WoI2CtKS28Umjlrr8d9fQN4pdx39E6ieqb6AwbQMBEhechnipQPzmndz0LYczQihNtKE1Q9+XZkTnpn7XiZtTt7/vAtlgqoPXuoxauWPqdRI/1qWSKUb8zU9oow6/VcO4Jw26PyFPxThMVxFcOrSmWnxiPHa8OoZ69yC2th/fyarlfWP5NLSJRqgyc8DYlCBBEiYQLwifhy0MBh7+TdeOXYb7n/m0XUxRkEP1vDe08/DWgJmA/tcJUPUo2WIHOJGw/ftnTSGkg/Xcm0diaVeLxtb2qotZeHuT/GXzbAuLKfdryp2N+VKD/XXWstarsgH1EdRXUlQoXgXF/5r2qU/LqtsLz4i2T/nCHsAbDrJNRYkAYmNd0RICx4lOGlDJRJJXnGHEyi/X4Wr5jLs1aFOpVpGj5G20MTdKPgn4u1Lk70HRj7WM49+EW/+Oe/2gIlBVvFkfVKjLVqVIgessXL8sphZLzApcDcADcECa6VJTjII= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0142;20:LtftpnFlICqpkaPLiTEwI5Hjs21IIY1AjGFi36Iz+aGHCh/QgIHCrA2xSL7iCDytwSVEM3bOvmpnHD7nfURrdqHar3gbB+/2Esz+9qNzEVchzalne400TDICvwg/S/untx/wcgLGpdnwLF+o/mWBjjJJ9i3UPZhkOVbzV86Hlnjc+QbgvjTTy3ruj+UBQ9g95ihGhWXesXgraCXgb+AjowqCxeeCoWNY1QrhSN595lOVc3zBNuegQaQk2Y7x9syo/+dAwp6UviTfwPdy4wMW77VrZWSnoJbYxP4dQRjwuXWGc14d01fq+Kz06FVEgDZ/1Y4JQWcEkJtlgaJ+9ZkR8BYwnGpapTBgyecDrNucVUbyiY7CYHAv2jeg2WnhbkFn5OlImlMHTWykkmeEFqpWB85TN+5GqQ2egDmZP74g4qRk4ILCd9bMiFO7AvKfktp4/70zXWJ5/1dPq268MaXw5Ddsp+KZJe+DakAtOUHkoY8u3uV3vl28X1ttBky+WtCc;4:S29ijOO8GFPB8uka2ZBmkM0m4dcRPq3jBmYFh26joo42LjFrWAxy7l2izZ6WqC8EMtGkpmV5WCa2zJ6Iwr9POGQ4Wp1Dyk5Hj9SVYzMRixCC+qAx3sd6AD9MDHALQMUQRqcKGT7gZPOhT8bopsciXNLfmoc/rKScn1tKMFaY2oHpEYMnMozoGoNrFTJAFarsoHzyGwgLXjxwq27cGGHJNsjS9bF3e/8MON1Ejc4Y0QcHB4YY+GBgEc0T6OZZjIl7ueNKY2DQUctxt4RL+/QS6sI6q8QUjhNgtn6kMWhcUAKlh2MQp2knggALzpSpDIeJNNdDPCs8iWDo9wVdfavxpLybdASDMykhLo+fZRo2QlwV5ztWTuggz/o2QJwadAIa X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:SN1PR12MB0142;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0142; X-Forefront-PRVS: 09090B6B69 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(377454003)(24454002)(50466002)(65956001)(42186005)(19580405001)(19580395003)(80316001)(50986999)(189998001)(64126003)(86362001)(1096002)(5004730100002)(65806001)(47776003)(33656002)(77096005)(2950100001)(4001350100001)(36756003)(4326007)(6116002)(2870700001)(81166005)(83506001)(65816999)(54356999)(76176999)(2906002)(23676002)(87266999)(5008740100001)(92566002)(586003)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0142;H:[IPv6:2a02:908:1250:ae81:e81b:ad8c:4800:115c];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTQyOzIzOnp0TVRnN21CUnBEQ05IUlRzYTRXVUVzY0Nt?= =?utf-8?B?bUVHSlBxcTNsTVIwVGZyY3J4dWhPR3A5QUx0Vi9nVmdMVkM3aUFNTUhFOHFF?= =?utf-8?B?MzNPU3RCS25Kc096QlBEK1dvbTdQWHZTY0JlV21yTlRCUVJJRU9tbS9XaG5m?= =?utf-8?B?OWtKbkJ1bjFvN3BPS1IwZlRjR0MxcytJVSsyVlR5ZkYrYlNOY0JWbUU0am1j?= =?utf-8?B?aWxpMzJaM2M2V2N2aUw5Y05IZHVQSW1XQTdxSElYcG9EZ0hXcFZKU0dzMk5X?= =?utf-8?B?RThGUFZtNnRTUjZocFBDb3lkN1NUMnVIQldraVVSK1U3VDBvbXlERnBjUDAr?= =?utf-8?B?aEwzbGJnRHVkdnUxR0pONnRPUFNObUUxUGZHaXVQdG9IWFZvWW42ckJMM0d6?= =?utf-8?B?ZkJVM1RhMDQ0dVgzaDlaSFU5UlRVV3BiNzNVVmNCM0Rud2xYaG1ESnlaWFZy?= =?utf-8?B?M0NTTkExMEJNRzRuL1N1VUpnKys5MDRMaityMFU4bk8zSUVFU0IxVDhVWnE3?= =?utf-8?B?eVlsbTJsQ1hwU2VNN08reUxwWENleTlJaHFMSnQzUjd5TWJnSnFoN3NpZGpF?= =?utf-8?B?Qk1PV2xDNzlRTWxqejNaQWk4MW9hRGVqN0NNckJ4V3VTbmhQVFNqdDZDeE9i?= =?utf-8?B?TFkvQ29lU3QrZ000NmdMNDE2ejFsZ1M5TEg4Y2EvampuU1lncG9HcUlVbWV5?= =?utf-8?B?UFAzQnJMZXBqM2hmVzlCWkFaWmE1emwremRPbytZWVlHaGJwOGV0S3pjR0gw?= =?utf-8?B?NElsWU1FUHB1U0pNcW1jV3IrL1hWRkl5bjErd0E3WE4rRXB0Wkx4ai9YMzFn?= =?utf-8?B?N0J3TnF4cjZGMk9DTTVqSUN0RkNzelVuK0VSOVNtQ2NzNEdlWlNRckQyUy9t?= =?utf-8?B?OThEaVdVQ3l3cFdkMDBiU1RWT1lqbG5UNkhTTzJpY1FrU1pwTkZQaXI5Z1JF?= =?utf-8?B?ZGY2MU9EWnl0OWJaK1pjc2JnYkRia1RMWHNBREwyNWczU3A2SEp2SDlMamxU?= =?utf-8?B?VitmSWhoWFd6d1FyMTdBNFRlazBsejdCTS9aaHR1U2xFY0pkYUZTc2tGOTFM?= =?utf-8?B?bzIzUDcrejF2N0RXZ0dZYVYzQTgyek1zSDZQUFQ3ZFVlOEI5bEZRa0luWnZN?= =?utf-8?B?a3lDVEE4OHF2V05lS2QxZTJCZkxxZ1V3TGRmcFVMa29tVy83ZTM3ZjMwS1Uz?= =?utf-8?B?eVdsY2h3U3h1bENHYThZY2NMQmxiZlFIWVJETnRoVVVMVlZwdjFXWWRzRXhx?= =?utf-8?B?QzdBSUZwNml6MU15NW82Yk9hR0k1R2E5ZTRTMldUS25rSGxKVjlNT3cvMkR3?= =?utf-8?B?djFFc0RtUFBuMnBhQmlFUUczTnFHdW52bXlFbzZYWmQzcDNCRkwrbTdhSGVn?= =?utf-8?B?bS9YUkJIVzU4VXJ4bTFkT25ZaUFJU2pWeDNBWnBRPT0=?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0142;5:ezsDL/04gSurvLga24+Q0ry8A8gzd1z7p6jJdv2XFXM+4sp6B46XFTQsYC1jSO/HZS/Fh5+l+AGVI62FaJt/r+D4SIuaUkL4Jyg5zIL3+MZMxG1fOKkLuMdvjdgR7pjZJHEcL91JlTsWGQhaiSA8GQ==;24:u2BROHK+g0GR5RyL8KRPsfueui2Qv9m0UfR8gQeY/UX9ZOiYWs4sznM+dDO5PgYrv9SXp8d5KPHlMMfUgTMcwAT+7qEl96XEHHhR60YRnVc=;20:P7tAC7VYOTUsOIAMwZqDM5R12PKTnoPY+RgZ/DTY2yeq2j7Nfcx2jBOv0WpuIYkCsQJExEQIgLBP35xR3qSAw2lFPfEPwMVBvZFwlmFJfqHJdmhptetkpxrQxQ7iqOfjV/++iveFWoXPToA3Xh8pyuqM8MKVNo7RtK6uwPSabXUq7kZ6RNqYhokya++jFnin45D4dN5qVXgYUa+spJgIXW6ShmbRs+aRxTH3W8B9ZmToNfTORzwIj/F3GHO6gK1N SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2016 13:29:07.2876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0142 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez: > On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez wrote: >> We need to ensure amd iommu v2 initializes before >> driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, >> to do this make its init routine a subsys_initcall() which >> ensures its load init is called first than modules when >> built-in. >> >> This reverts the old work around implemented through commit >> 1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in Makefile"), >> instead of making the dependency implicit by linker order this >> makes the ordering requirement explicit through proper kernel >> APIs. >> >> Cc: Oded Gabbay >> Cc: Christian König >> Signed-off-by: Luis R. Rodriguez Sorry for not responding earlier. Just coming back to all the stuff on my TODO list. Patch is Acked-by: Christian König Regards, Christian. > *poke* > > Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu Date: Mon, 11 Apr 2016 15:28:52 +0200 Message-ID: <570BA694.8040900@amd.com> References: <20160316171719.GE2195@8bytes.org> <1459273313-5139-1-git-send-email-mcgrof@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Luis R. Rodriguez" , Joerg Roedel , oded.gabbay-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: iommu@lists.linux-foundation.org QW0gMDkuMDQuMjAxNiB1bSAwMjoyNSBzY2hyaWViIEx1aXMgUi4gUm9kcmlndWV6Ogo+IE9uIFR1 ZSwgTWFyIDI5LCAyMDE2IGF0IDEwOjQxIEFNLCBMdWlzIFIuIFJvZHJpZ3VleiA8bWNncm9mQGtl cm5lbC5vcmc+IHdyb3RlOgo+PiBXZSBuZWVkIHRvIGVuc3VyZSBhbWQgaW9tbXUgdjIgaW5pdGlh bGl6ZXMgYmVmb3JlCj4+IGRyaXZlciB1c2VzIHN1Y2ggYXMgZHJpdmVycy9ncHUvZHJtL2FtZC9h bWRrZmQva2ZkX21vZHVsZS5jLAo+PiB0byBkbyB0aGlzIG1ha2UgaXRzIGluaXQgcm91dGluZSBh IHN1YnN5c19pbml0Y2FsbCgpIHdoaWNoCj4+IGVuc3VyZXMgaXRzIGxvYWQgaW5pdCBpcyBjYWxs ZWQgZmlyc3QgdGhhbiBtb2R1bGVzIHdoZW4KPj4gYnVpbHQtaW4uCj4+Cj4+IFRoaXMgcmV2ZXJ0 cyB0aGUgb2xkIHdvcmsgYXJvdW5kIGltcGxlbWVudGVkIHRocm91Z2ggY29tbWl0Cj4+IDFiYWNj ODk0YzIyN2ZhZDhhNyAoImRyaXZlcnM6IE1vdmUgaW9tbXUvIGJlZm9yZSBncHUvIGluIE1ha2Vm aWxlIiksCj4+IGluc3RlYWQgb2YgbWFraW5nIHRoZSBkZXBlbmRlbmN5IGltcGxpY2l0IGJ5IGxp bmtlciBvcmRlciB0aGlzCj4+IG1ha2VzIHRoZSBvcmRlcmluZyByZXF1aXJlbWVudCBleHBsaWNp dCB0aHJvdWdoIHByb3BlciBrZXJuZWwKPj4gQVBJcy4KPj4KPj4gQ2M6IE9kZWQgR2FiYmF5IDxv ZGVkLmdhYmJheUBhbWQuY29tPgo+PiBDYzogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtv ZW5pZ0BhbWQuY29tPgo+PiBTaWduZWQtb2ZmLWJ5OiBMdWlzIFIuIFJvZHJpZ3VleiA8bWNncm9m QGtlcm5lbC5vcmc+CgpTb3JyeSBmb3Igbm90IHJlc3BvbmRpbmcgZWFybGllci4gSnVzdCBjb21p bmcgYmFjayB0byBhbGwgdGhlIHN0dWZmIG9uIApteSBUT0RPIGxpc3QuCgpQYXRjaCBpcyBBY2tl ZC1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgoKUmVnYXJk cywKQ2hyaXN0aWFuLgoKPiAqcG9rZSoKPgo+ICAgTHVpcwoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3Rz LmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lvbW11