From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755268AbcDKO1w (ORCPT ); Mon, 11 Apr 2016 10:27:52 -0400 Received: from foss.arm.com ([217.140.101.70]:50024 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754352AbcDKO1t (ORCPT ); Mon, 11 Apr 2016 10:27:49 -0400 Subject: Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information To: Hanjun Guo , kvmarm@lists.cs.columbia.edu References: <1459769860-6629-1-git-send-email-julien.grall@arm.com> <1459769860-6629-7-git-send-email-julien.grall@arm.com> <570B35DA.5050600@linaro.org> Cc: christoffer.dall@linaro.org, marc.zyngier@arm.com, fu.wei@linaro.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wei@redhat.com, al.stone@linaro.org, gg@slimlogic.co.uk, Thomas Gleixner , Jason Cooper From: Julien Grall Message-ID: <570BB461.4040704@arm.com> Date: Mon, 11 Apr 2016 15:27:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <570B35DA.5050600@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Hanjun, On 11/04/16 06:27, Hanjun Guo wrote: > On 2016/4/4 19:37, Julien Grall wrote: >> +static void __init gic_acpi_setup_kvm_info(void) >> +{ >> + int irq; >> + >> + if (!gic_acpi_collect_virt_info()) { >> + pr_warn("Unable to get hardware information used for >> virtualization\n"); >> + return; >> + } >> + >> + gic_v3_kvm_info.type = GIC_V3; >> + >> + irq = acpi_register_gsi(NULL, acpi_data.maint_irq, >> + acpi_data.maint_irq_mode, >> + ACPI_ACTIVE_HIGH); >> + if (irq <= 0) >> + return; >> + >> + gic_v3_kvm_info.maint_irq = irq; >> + >> + if (acpi_data.vcpu_base) { > > Sorry, I'm not familiar with KVM, but I got a question here, will > KVM works without valid vcpu_base in GICv3 mode? vcpu_base is only required for supporting GICv2 on GICv3. Regards, -- Julien Grall From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information Date: Mon, 11 Apr 2016 15:27:45 +0100 Message-ID: <570BB461.4040704@arm.com> References: <1459769860-6629-1-git-send-email-julien.grall@arm.com> <1459769860-6629-7-git-send-email-julien.grall@arm.com> <570B35DA.5050600@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: al.stone@linaro.org, kvm@vger.kernel.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, fu.wei@linaro.org, Thomas Gleixner , Jason Cooper , linux-arm-kernel@lists.infradead.org, gg@slimlogic.co.uk To: Hanjun Guo , kvmarm@lists.cs.columbia.edu Return-path: In-Reply-To: <570B35DA.5050600@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org Hello Hanjun, On 11/04/16 06:27, Hanjun Guo wrote: > On 2016/4/4 19:37, Julien Grall wrote: >> +static void __init gic_acpi_setup_kvm_info(void) >> +{ >> + int irq; >> + >> + if (!gic_acpi_collect_virt_info()) { >> + pr_warn("Unable to get hardware information used for >> virtualization\n"); >> + return; >> + } >> + >> + gic_v3_kvm_info.type = GIC_V3; >> + >> + irq = acpi_register_gsi(NULL, acpi_data.maint_irq, >> + acpi_data.maint_irq_mode, >> + ACPI_ACTIVE_HIGH); >> + if (irq <= 0) >> + return; >> + >> + gic_v3_kvm_info.maint_irq = irq; >> + >> + if (acpi_data.vcpu_base) { > > Sorry, I'm not familiar with KVM, but I got a question here, will > KVM works without valid vcpu_base in GICv3 mode? vcpu_base is only required for supporting GICv2 on GICv3. Regards, -- Julien Grall From mboxrd@z Thu Jan 1 00:00:00 1970 From: julien.grall@arm.com (Julien Grall) Date: Mon, 11 Apr 2016 15:27:45 +0100 Subject: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information In-Reply-To: <570B35DA.5050600@linaro.org> References: <1459769860-6629-1-git-send-email-julien.grall@arm.com> <1459769860-6629-7-git-send-email-julien.grall@arm.com> <570B35DA.5050600@linaro.org> Message-ID: <570BB461.4040704@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Hanjun, On 11/04/16 06:27, Hanjun Guo wrote: > On 2016/4/4 19:37, Julien Grall wrote: >> +static void __init gic_acpi_setup_kvm_info(void) >> +{ >> + int irq; >> + >> + if (!gic_acpi_collect_virt_info()) { >> + pr_warn("Unable to get hardware information used for >> virtualization\n"); >> + return; >> + } >> + >> + gic_v3_kvm_info.type = GIC_V3; >> + >> + irq = acpi_register_gsi(NULL, acpi_data.maint_irq, >> + acpi_data.maint_irq_mode, >> + ACPI_ACTIVE_HIGH); >> + if (irq <= 0) >> + return; >> + >> + gic_v3_kvm_info.maint_irq = irq; >> + >> + if (acpi_data.vcpu_base) { > > Sorry, I'm not familiar with KVM, but I got a question here, will > KVM works without valid vcpu_base in GICv3 mode? vcpu_base is only required for supporting GICv2 on GICv3. Regards, -- Julien Grall