From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34393)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1apjYx-0004lQ-8D
	for qemu-devel@nongnu.org; Mon, 11 Apr 2016 17:40:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1apjYs-00079K-97
	for qemu-devel@nongnu.org; Mon, 11 Apr 2016 17:40:03 -0400
Received: from mail-lf0-x235.google.com ([2a00:1450:4010:c07::235]:35637)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1apjYr-00078x-U8
	for qemu-devel@nongnu.org; Mon, 11 Apr 2016 17:39:58 -0400
Received: by mail-lf0-x235.google.com with SMTP id c126so176359313lfb.2
	for <qemu-devel@nongnu.org>; Mon, 11 Apr 2016 14:39:57 -0700 (PDT)
References: <1459870344-16773-1-git-send-email-alex.bennee@linaro.org>
	<1459870344-16773-10-git-send-email-alex.bennee@linaro.org>
From: Sergey Fedorov <serge.fdrv@gmail.com>
Message-ID: <570C19AB.5020106@gmail.com>
Date: Tue, 12 Apr 2016 00:39:55 +0300
MIME-Version: 1.0
In-Reply-To: <1459870344-16773-10-git-send-email-alex.bennee@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC v2 09/11] tcg: add kick timer for
 single-threaded vCPU emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, mttcg@listserver.greensocs.com, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org
Cc: qemu-devel@nongnu.org, mark.burton@greensocs.com, pbonzini@redhat.com, jan.kiszka@siemens.com, rth@twiddle.net, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite <crosthwaite.peter@gmail.com>

On 05/04/16 18:32, Alex Bennée wrote:
> +static void kick_tcg_thread(void *opaque)
> +{
> +    QEMUTimer *self = *(QEMUTimer **) opaque;
> +    timer_mod(self,
> +              qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
> +              NANOSECONDS_PER_SECOND / 10);
> +    qemu_cpu_kick_no_halt();
> +}
>  

It would be nice to have some definition (e.g. macro) of TCG thread kick
period.

(snip)

> @@ -1179,6 +1198,14 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
>          }
>      }
>  
> +    /* Set to kick if we have to do more than one vCPU */
> +    if (CPU_NEXT(first_cpu)) {
> +        kick_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL,  kick_tcg_thread, &kick_timer);
> +        timer_mod(kick_timer,
> +                  qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
> +                  NANOSECONDS_PER_SECOND / 10);
> +    }
> +    

I think cpu_ticks_init() could be more natural place to put this
initialization in.

Kind regards,
Sergey